All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Oded Gabbay" <oded.gabbay@gmail.com>,
	"Oded Gabbay" <ogabbay@kernel.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Gal Pressman" <galpress@amazon.com>,
	sleybo@amazon.com,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	"Linux Media Mailing List" <linux-media@vger.kernel.org>,
	"Doug Ledford" <dledford@redhat.com>,
	"Dave Airlie" <airlied@gmail.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Leon Romanovsky" <leonro@nvidia.com>,
	"Christoph Hellwig" <hch@lst.de>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"moderated list:DMA BUFFER SHARING FRAMEWORK"
	<linaro-mm-sig@lists.linaro.org>
Subject: Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs
Date: Tue, 6 Jul 2021 13:29:53 -0300	[thread overview]
Message-ID: <20210706162953.GQ4604@ziepe.ca> (raw)
In-Reply-To: <CAKMK7uH7Ar6+uAOU_Sj-mf89V9WCru+66CV5bO9h-WAAv7Mgdg@mail.gmail.com>

On Tue, Jul 06, 2021 at 05:49:01PM +0200, Daniel Vetter wrote:

> The other thing to keep in mind is that one of these drivers supports
> 25 years of product generations, and the other one doesn't. 

Sure, but that is the point, isn't it? To have an actually useful
thing you need all of this mess

> > My argument is that an in-tree open kernel driver is a big help to
> > reverse engineering an open userspace. Having the vendors
> > collaboration to build that monstrous thing can only help the end goal
> > of an end to end open stack.
> 
> Not sure where this got lost, but we're totally fine with vendors
> using the upstream driver together with their closed stack. And most
> of the drivers we do have in upstream are actually, at least in parts,
> supported by the vendor. E.g. if you'd have looked the drm/arm driver
> you picked is actually 100% written by ARM engineers. So kinda
> unfitting example.

So the argument with Habana really boils down to how much do they need
to show in the open source space to get a kernel driver? You want to
see the ISA or compiler at least?

That at least doesn't seem "extreme" to me.

> > For instance a vendor with an in-tree driver has a strong incentive to
> > sort out their FW licensing issues so it can be redistributed.
> 
> Nvidia has been claiming to try and sort out the FW problem for years.
> They even managed to release a few things, but I think the last one is
> 2-3 years late now. Partially the reason is that there don't have a
> stable api between the firmware and driver, it's all internal from the
> same source tree, and they don't really want to change that.

Right, companies have no incentive to work in a sane way if they have
their own parallel world. I think drawing them part by part into the
standard open workflows and expectations is actually helpful to
everyone.

> > > I don't think the facts on the ground support your claim here, aside
> > > from the practical problem that nvidia is unwilling to even create an
> > > open driver to begin with. So there isn't anything to merge.
> >
> > The internet tells me there is nvgpu, it doesn't seem to have helped.
> 
> Not sure which one you mean, but every once in a while they open up a
> few headers, or a few programming specs, or a small driver somewhere
> for a very specific thing, and then it dies again or gets obfuscated
> for the next platform, or just never updated. I've never seen anything
> that comes remotely to something complete, aside from tegra socs,
> which are fully supported in upstream afaik.

I understand nvgpu is the tegra driver that people actualy
use. nouveau may have good tegra support but is it used in any actual
commercial product?

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Gal Pressman" <galpress@amazon.com>,
	sleybo@amazon.com, linux-rdma <linux-rdma@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Oded Gabbay" <ogabbay@kernel.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"moderated list:DMA BUFFER SHARING FRAMEWORK"
	<linaro-mm-sig@lists.linaro.org>,
	"Doug Ledford" <dledford@redhat.com>,
	"Christoph Hellwig" <hch@lst.de>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Leon Romanovsky" <leonro@nvidia.com>,
	"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs
Date: Tue, 6 Jul 2021 13:29:53 -0300	[thread overview]
Message-ID: <20210706162953.GQ4604@ziepe.ca> (raw)
In-Reply-To: <CAKMK7uH7Ar6+uAOU_Sj-mf89V9WCru+66CV5bO9h-WAAv7Mgdg@mail.gmail.com>

On Tue, Jul 06, 2021 at 05:49:01PM +0200, Daniel Vetter wrote:

> The other thing to keep in mind is that one of these drivers supports
> 25 years of product generations, and the other one doesn't. 

Sure, but that is the point, isn't it? To have an actually useful
thing you need all of this mess

> > My argument is that an in-tree open kernel driver is a big help to
> > reverse engineering an open userspace. Having the vendors
> > collaboration to build that monstrous thing can only help the end goal
> > of an end to end open stack.
> 
> Not sure where this got lost, but we're totally fine with vendors
> using the upstream driver together with their closed stack. And most
> of the drivers we do have in upstream are actually, at least in parts,
> supported by the vendor. E.g. if you'd have looked the drm/arm driver
> you picked is actually 100% written by ARM engineers. So kinda
> unfitting example.

So the argument with Habana really boils down to how much do they need
to show in the open source space to get a kernel driver? You want to
see the ISA or compiler at least?

That at least doesn't seem "extreme" to me.

> > For instance a vendor with an in-tree driver has a strong incentive to
> > sort out their FW licensing issues so it can be redistributed.
> 
> Nvidia has been claiming to try and sort out the FW problem for years.
> They even managed to release a few things, but I think the last one is
> 2-3 years late now. Partially the reason is that there don't have a
> stable api between the firmware and driver, it's all internal from the
> same source tree, and they don't really want to change that.

Right, companies have no incentive to work in a sane way if they have
their own parallel world. I think drawing them part by part into the
standard open workflows and expectations is actually helpful to
everyone.

> > > I don't think the facts on the ground support your claim here, aside
> > > from the practical problem that nvidia is unwilling to even create an
> > > open driver to begin with. So there isn't anything to merge.
> >
> > The internet tells me there is nvgpu, it doesn't seem to have helped.
> 
> Not sure which one you mean, but every once in a while they open up a
> few headers, or a few programming specs, or a small driver somewhere
> for a very specific thing, and then it dies again or gets obfuscated
> for the next platform, or just never updated. I've never seen anything
> that comes remotely to something complete, aside from tegra socs,
> which are fully supported in upstream afaik.

I understand nvgpu is the tegra driver that people actualy
use. nouveau may have good tegra support but is it used in any actual
commercial product?

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Oded Gabbay" <oded.gabbay@gmail.com>,
	"Gal Pressman" <galpress@amazon.com>,
	sleybo@amazon.com, linux-rdma <linux-rdma@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Oded Gabbay" <ogabbay@kernel.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"moderated list:DMA BUFFER SHARING FRAMEWORK"
	<linaro-mm-sig@lists.linaro.org>,
	"Doug Ledford" <dledford@redhat.com>,
	"Christoph Hellwig" <hch@lst.de>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Dave Airlie" <airlied@gmail.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Leon Romanovsky" <leonro@nvidia.com>,
	"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs
Date: Tue, 6 Jul 2021 13:29:53 -0300	[thread overview]
Message-ID: <20210706162953.GQ4604@ziepe.ca> (raw)
In-Reply-To: <CAKMK7uH7Ar6+uAOU_Sj-mf89V9WCru+66CV5bO9h-WAAv7Mgdg@mail.gmail.com>

On Tue, Jul 06, 2021 at 05:49:01PM +0200, Daniel Vetter wrote:

> The other thing to keep in mind is that one of these drivers supports
> 25 years of product generations, and the other one doesn't. 

Sure, but that is the point, isn't it? To have an actually useful
thing you need all of this mess

> > My argument is that an in-tree open kernel driver is a big help to
> > reverse engineering an open userspace. Having the vendors
> > collaboration to build that monstrous thing can only help the end goal
> > of an end to end open stack.
> 
> Not sure where this got lost, but we're totally fine with vendors
> using the upstream driver together with their closed stack. And most
> of the drivers we do have in upstream are actually, at least in parts,
> supported by the vendor. E.g. if you'd have looked the drm/arm driver
> you picked is actually 100% written by ARM engineers. So kinda
> unfitting example.

So the argument with Habana really boils down to how much do they need
to show in the open source space to get a kernel driver? You want to
see the ISA or compiler at least?

That at least doesn't seem "extreme" to me.

> > For instance a vendor with an in-tree driver has a strong incentive to
> > sort out their FW licensing issues so it can be redistributed.
> 
> Nvidia has been claiming to try and sort out the FW problem for years.
> They even managed to release a few things, but I think the last one is
> 2-3 years late now. Partially the reason is that there don't have a
> stable api between the firmware and driver, it's all internal from the
> same source tree, and they don't really want to change that.

Right, companies have no incentive to work in a sane way if they have
their own parallel world. I think drawing them part by part into the
standard open workflows and expectations is actually helpful to
everyone.

> > > I don't think the facts on the ground support your claim here, aside
> > > from the practical problem that nvidia is unwilling to even create an
> > > open driver to begin with. So there isn't anything to merge.
> >
> > The internet tells me there is nvgpu, it doesn't seem to have helped.
> 
> Not sure which one you mean, but every once in a while they open up a
> few headers, or a few programming specs, or a small driver somewhere
> for a very specific thing, and then it dies again or gets obfuscated
> for the next platform, or just never updated. I've never seen anything
> that comes remotely to something complete, aside from tegra socs,
> which are fully supported in upstream afaik.

I understand nvgpu is the tegra driver that people actualy
use. nouveau may have good tegra support but is it used in any actual
commercial product?

Jason
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2021-07-06 16:29 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 13:03 [PATCH v4 0/2] Add p2p via dmabuf to habanalabs Oded Gabbay
2021-07-05 13:03 ` Oded Gabbay
2021-07-05 13:03 ` Oded Gabbay
2021-07-05 13:03 ` [PATCH v4 1/2] habanalabs: define uAPI to export FD for DMA-BUF Oded Gabbay
2021-07-05 13:03   ` Oded Gabbay
2021-07-05 13:03   ` Oded Gabbay
2021-07-05 13:03 ` [PATCH v4 2/2] habanalabs: add support for dma-buf exporter Oded Gabbay
2021-07-05 13:03   ` Oded Gabbay
2021-07-05 13:03   ` Oded Gabbay
2021-07-05 16:52   ` Jason Gunthorpe
2021-07-05 16:52     ` Jason Gunthorpe
2021-07-05 16:52     ` Jason Gunthorpe
2021-07-06  9:44     ` Oded Gabbay
2021-07-06  9:44       ` Oded Gabbay
2021-07-06  9:44       ` Oded Gabbay
2021-07-06 13:54       ` Jason Gunthorpe
2021-07-06 13:54         ` Jason Gunthorpe
2021-07-06 13:54         ` Jason Gunthorpe
2021-07-06 14:00         ` Oded Gabbay
2021-07-06 14:00           ` Oded Gabbay
2021-07-06  8:40 ` [PATCH v4 0/2] Add p2p via dmabuf to habanalabs Daniel Vetter
2021-07-06  8:40   ` Daniel Vetter
2021-07-06  8:40   ` Daniel Vetter
2021-07-06 10:03   ` Oded Gabbay
2021-07-06 10:03     ` Oded Gabbay
2021-07-06 10:36     ` Daniel Vetter
2021-07-06 10:36       ` Daniel Vetter
2021-07-06 10:36       ` Daniel Vetter
2021-07-06 10:47       ` Daniel Vetter
2021-07-06 10:47         ` Daniel Vetter
2021-07-06 10:47         ` Daniel Vetter
2021-07-06 12:07         ` Daniel Vetter
2021-07-06 12:07           ` Daniel Vetter
2021-07-06 12:07           ` Daniel Vetter
2021-07-06 13:44           ` Jason Gunthorpe
2021-07-06 13:44             ` Jason Gunthorpe
2021-07-06 13:44             ` Jason Gunthorpe
2021-07-06 14:09             ` Daniel Vetter
2021-07-06 14:09               ` Daniel Vetter
2021-07-06 14:09               ` Daniel Vetter
2021-07-06 14:56               ` Jason Gunthorpe
2021-07-06 14:56                 ` Jason Gunthorpe
2021-07-06 14:56                 ` Jason Gunthorpe
2021-07-06 15:52                 ` Daniel Vetter
2021-07-06 15:52                   ` Daniel Vetter
2021-07-06 15:52                   ` Daniel Vetter
2021-07-06 12:23       ` Christoph Hellwig
2021-07-06 12:23         ` Christoph Hellwig
2021-07-06 14:23       ` Jason Gunthorpe
2021-07-06 14:23         ` Jason Gunthorpe
2021-07-06 14:23         ` Jason Gunthorpe
2021-07-06 14:39         ` Daniel Vetter
2021-07-06 14:39           ` Daniel Vetter
2021-07-06 14:39           ` Daniel Vetter
2021-07-06 15:25           ` Jason Gunthorpe
2021-07-06 15:25             ` Jason Gunthorpe
2021-07-06 15:25             ` Jason Gunthorpe
2021-07-06 15:49             ` Daniel Vetter
2021-07-06 15:49               ` Daniel Vetter
2021-07-06 15:49               ` Daniel Vetter
2021-07-06 16:07               ` Daniel Vetter
2021-07-06 16:07                 ` Daniel Vetter
2021-07-06 16:07                 ` Daniel Vetter
2021-07-06 17:28                 ` Jason Gunthorpe
2021-07-06 17:28                   ` Jason Gunthorpe
2021-07-06 17:28                   ` Jason Gunthorpe
2021-07-06 17:31                   ` Christoph Hellwig
2021-07-06 17:31                     ` Christoph Hellwig
2021-07-06 17:59                     ` Jason Gunthorpe
2021-07-06 17:59                       ` Jason Gunthorpe
2021-07-06 17:59                       ` Jason Gunthorpe
2021-07-09 14:47                       ` Dennis Dalessandro
2021-07-09 14:47                         ` Dennis Dalessandro
2021-07-09 14:47                         ` Dennis Dalessandro
2021-07-06 16:29               ` Jason Gunthorpe [this message]
2021-07-06 16:29                 ` Jason Gunthorpe
2021-07-06 16:29                 ` Jason Gunthorpe
2021-07-06 17:35                 ` Daniel Vetter
2021-07-06 17:35                   ` Daniel Vetter
2021-07-06 17:35                   ` Daniel Vetter
2021-07-06 18:03                   ` Daniel Vetter
2021-07-06 18:03                     ` Daniel Vetter
2021-07-06 18:03                     ` Daniel Vetter
2021-07-06 18:31                   ` Jason Gunthorpe
2021-07-06 18:31                     ` Jason Gunthorpe
2021-07-06 18:31                     ` Jason Gunthorpe
2021-07-06 19:06                     ` Daniel Vetter
2021-07-06 19:06                       ` Daniel Vetter
2021-07-06 19:06                       ` Daniel Vetter
2021-07-06 19:09                     ` Alex Deucher
2021-07-06 19:09                       ` Alex Deucher
2021-07-06 19:09                       ` Alex Deucher
2021-07-06 12:21   ` Christoph Hellwig
2021-07-06 12:21     ` Christoph Hellwig
2021-07-06 12:23     ` [Linaro-mm-sig] " Daniel Vetter
2021-07-06 12:23       ` Daniel Vetter
2021-07-06 12:23       ` Daniel Vetter
2021-07-06 12:45       ` Oded Gabbay
2021-07-06 12:45         ` Oded Gabbay
2021-07-06 13:17         ` Daniel Vetter
2021-07-06 13:17           ` Daniel Vetter
2021-07-06 13:17           ` Daniel Vetter
2021-07-06 13:45           ` Oded Gabbay
2021-07-06 13:45             ` Oded Gabbay
2021-07-06 13:45             ` Oded Gabbay
2021-07-07 12:17       ` Christian König
2021-07-07 12:17         ` Christian König
2021-07-07 12:54         ` Daniel Vetter
2021-07-07 12:54           ` Daniel Vetter
2021-07-07 12:54           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210706162953.GQ4604@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dledford@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=galpress@amazon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=leonro@nvidia.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=oded.gabbay@gmail.com \
    --cc=ogabbay@kernel.org \
    --cc=sleybo@amazon.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.