From: Oded Gabbay <oded.gabbay@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Gal Pressman" <galpress@amazon.com>,
sleybo@amazon.com, linux-rdma <linux-rdma@vger.kernel.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Doug Ledford" <dledford@redhat.com>,
"Christoph Hellwig" <hch@lst.de>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Tomer Tayar" <ttayar@habana.ai>,
"Christian König" <christian.koenig@amd.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] habanalabs: add support for dma-buf exporter
Date: Tue, 6 Jul 2021 17:00:07 +0300 [thread overview]
Message-ID: <CAFCwf11p_uNKLV7SgjmShVgoRuSCax4DQmKZEdydK2SBrH6w8A@mail.gmail.com> (raw)
In-Reply-To: <20210706135451.GM4604@ziepe.ca>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Tue, Jul 6, 2021, 16:54 Jason Gunthorpe <jgg@ziepe.ca> wrote:
> On Tue, Jul 06, 2021 at 12:44:49PM +0300, Oded Gabbay wrote:
>
> > > > + /* In case we got a large memory area to export, we need to
> divide it
> > > > + * to smaller areas because each entry in the dmabuf sgt can
> only
> > > > + * describe unsigned int.
> > > > + */
> > >
> > > Huh? This is forming a SGL, it should follow the SGL rules which means
> > > you have to fragment based on the dma_get_max_seg_size() of the
> > > importer device.
> > >
> > hmm
> > I don't see anyone in drm checking this value (and using it) when
> > creating the SGL when exporting dmabuf. (e.g.
> > amdgpu_vram_mgr_alloc_sgt)
>
> For dmabuf the only importer is RDMA and it doesn't care, but you
> certainly should not introduce a hardwired constant instead of using
> the correct function.
>
> Jason
>
Got it, will change
Thanks,
Oded
>
[-- Attachment #2: Type: text/html, Size: 1598 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Gal Pressman" <galpress@amazon.com>,
sleybo@amazon.com, linux-rdma <linux-rdma@vger.kernel.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Doug Ledford" <dledford@redhat.com>,
"Christoph Hellwig" <hch@lst.de>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Tomer Tayar" <ttayar@habana.ai>,
"Dave Airlie" <airlied@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] habanalabs: add support for dma-buf exporter
Date: Tue, 6 Jul 2021 17:00:07 +0300 [thread overview]
Message-ID: <CAFCwf11p_uNKLV7SgjmShVgoRuSCax4DQmKZEdydK2SBrH6w8A@mail.gmail.com> (raw)
In-Reply-To: <20210706135451.GM4604@ziepe.ca>
[-- Attachment #1.1: Type: text/plain, Size: 912 bytes --]
On Tue, Jul 6, 2021, 16:54 Jason Gunthorpe <jgg@ziepe.ca> wrote:
> On Tue, Jul 06, 2021 at 12:44:49PM +0300, Oded Gabbay wrote:
>
> > > > + /* In case we got a large memory area to export, we need to
> divide it
> > > > + * to smaller areas because each entry in the dmabuf sgt can
> only
> > > > + * describe unsigned int.
> > > > + */
> > >
> > > Huh? This is forming a SGL, it should follow the SGL rules which means
> > > you have to fragment based on the dma_get_max_seg_size() of the
> > > importer device.
> > >
> > hmm
> > I don't see anyone in drm checking this value (and using it) when
> > creating the SGL when exporting dmabuf. (e.g.
> > amdgpu_vram_mgr_alloc_sgt)
>
> For dmabuf the only importer is RDMA and it doesn't care, but you
> certainly should not introduce a hardwired constant instead of using
> the correct function.
>
> Jason
>
Got it, will change
Thanks,
Oded
>
[-- Attachment #1.2: Type: text/html, Size: 1598 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-07-06 14:00 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 13:03 [PATCH v4 0/2] Add p2p via dmabuf to habanalabs Oded Gabbay
2021-07-05 13:03 ` Oded Gabbay
2021-07-05 13:03 ` Oded Gabbay
2021-07-05 13:03 ` [PATCH v4 1/2] habanalabs: define uAPI to export FD for DMA-BUF Oded Gabbay
2021-07-05 13:03 ` Oded Gabbay
2021-07-05 13:03 ` Oded Gabbay
2021-07-05 13:03 ` [PATCH v4 2/2] habanalabs: add support for dma-buf exporter Oded Gabbay
2021-07-05 13:03 ` Oded Gabbay
2021-07-05 13:03 ` Oded Gabbay
2021-07-05 16:52 ` Jason Gunthorpe
2021-07-05 16:52 ` Jason Gunthorpe
2021-07-05 16:52 ` Jason Gunthorpe
2021-07-06 9:44 ` Oded Gabbay
2021-07-06 9:44 ` Oded Gabbay
2021-07-06 9:44 ` Oded Gabbay
2021-07-06 13:54 ` Jason Gunthorpe
2021-07-06 13:54 ` Jason Gunthorpe
2021-07-06 13:54 ` Jason Gunthorpe
2021-07-06 14:00 ` Oded Gabbay [this message]
2021-07-06 14:00 ` Oded Gabbay
2021-07-06 8:40 ` [PATCH v4 0/2] Add p2p via dmabuf to habanalabs Daniel Vetter
2021-07-06 8:40 ` Daniel Vetter
2021-07-06 8:40 ` Daniel Vetter
2021-07-06 10:03 ` Oded Gabbay
2021-07-06 10:03 ` Oded Gabbay
2021-07-06 10:36 ` Daniel Vetter
2021-07-06 10:36 ` Daniel Vetter
2021-07-06 10:36 ` Daniel Vetter
2021-07-06 10:47 ` Daniel Vetter
2021-07-06 10:47 ` Daniel Vetter
2021-07-06 10:47 ` Daniel Vetter
2021-07-06 12:07 ` Daniel Vetter
2021-07-06 12:07 ` Daniel Vetter
2021-07-06 12:07 ` Daniel Vetter
2021-07-06 13:44 ` Jason Gunthorpe
2021-07-06 13:44 ` Jason Gunthorpe
2021-07-06 13:44 ` Jason Gunthorpe
2021-07-06 14:09 ` Daniel Vetter
2021-07-06 14:09 ` Daniel Vetter
2021-07-06 14:09 ` Daniel Vetter
2021-07-06 14:56 ` Jason Gunthorpe
2021-07-06 14:56 ` Jason Gunthorpe
2021-07-06 14:56 ` Jason Gunthorpe
2021-07-06 15:52 ` Daniel Vetter
2021-07-06 15:52 ` Daniel Vetter
2021-07-06 15:52 ` Daniel Vetter
2021-07-06 12:23 ` Christoph Hellwig
2021-07-06 12:23 ` Christoph Hellwig
2021-07-06 14:23 ` Jason Gunthorpe
2021-07-06 14:23 ` Jason Gunthorpe
2021-07-06 14:23 ` Jason Gunthorpe
2021-07-06 14:39 ` Daniel Vetter
2021-07-06 14:39 ` Daniel Vetter
2021-07-06 14:39 ` Daniel Vetter
2021-07-06 15:25 ` Jason Gunthorpe
2021-07-06 15:25 ` Jason Gunthorpe
2021-07-06 15:25 ` Jason Gunthorpe
2021-07-06 15:49 ` Daniel Vetter
2021-07-06 15:49 ` Daniel Vetter
2021-07-06 15:49 ` Daniel Vetter
2021-07-06 16:07 ` Daniel Vetter
2021-07-06 16:07 ` Daniel Vetter
2021-07-06 16:07 ` Daniel Vetter
2021-07-06 17:28 ` Jason Gunthorpe
2021-07-06 17:28 ` Jason Gunthorpe
2021-07-06 17:28 ` Jason Gunthorpe
2021-07-06 17:31 ` Christoph Hellwig
2021-07-06 17:31 ` Christoph Hellwig
2021-07-06 17:59 ` Jason Gunthorpe
2021-07-06 17:59 ` Jason Gunthorpe
2021-07-06 17:59 ` Jason Gunthorpe
2021-07-09 14:47 ` Dennis Dalessandro
2021-07-09 14:47 ` Dennis Dalessandro
2021-07-09 14:47 ` Dennis Dalessandro
2021-07-06 16:29 ` Jason Gunthorpe
2021-07-06 16:29 ` Jason Gunthorpe
2021-07-06 16:29 ` Jason Gunthorpe
2021-07-06 17:35 ` Daniel Vetter
2021-07-06 17:35 ` Daniel Vetter
2021-07-06 17:35 ` Daniel Vetter
2021-07-06 18:03 ` Daniel Vetter
2021-07-06 18:03 ` Daniel Vetter
2021-07-06 18:03 ` Daniel Vetter
2021-07-06 18:31 ` Jason Gunthorpe
2021-07-06 18:31 ` Jason Gunthorpe
2021-07-06 18:31 ` Jason Gunthorpe
2021-07-06 19:06 ` Daniel Vetter
2021-07-06 19:06 ` Daniel Vetter
2021-07-06 19:06 ` Daniel Vetter
2021-07-06 19:09 ` Alex Deucher
2021-07-06 19:09 ` Alex Deucher
2021-07-06 19:09 ` Alex Deucher
2021-07-06 12:21 ` Christoph Hellwig
2021-07-06 12:21 ` Christoph Hellwig
2021-07-06 12:23 ` [Linaro-mm-sig] " Daniel Vetter
2021-07-06 12:23 ` Daniel Vetter
2021-07-06 12:23 ` Daniel Vetter
2021-07-06 12:45 ` Oded Gabbay
2021-07-06 12:45 ` Oded Gabbay
2021-07-06 13:17 ` Daniel Vetter
2021-07-06 13:17 ` Daniel Vetter
2021-07-06 13:17 ` Daniel Vetter
2021-07-06 13:45 ` Oded Gabbay
2021-07-06 13:45 ` Oded Gabbay
2021-07-06 13:45 ` Oded Gabbay
2021-07-07 12:17 ` Christian König
2021-07-07 12:17 ` Christian König
2021-07-07 12:54 ` Daniel Vetter
2021-07-07 12:54 ` Daniel Vetter
2021-07-07 12:54 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFCwf11p_uNKLV7SgjmShVgoRuSCax4DQmKZEdydK2SBrH6w8A@mail.gmail.com \
--to=oded.gabbay@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=galpress@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=leonro@nvidia.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=sleybo@amazon.com \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.