From: Mark Brown <broonie@kernel.org>
To: Vijendar Mukunda <vijendar.mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, Alexander.Deucher@amd.com,
Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/12] ASoC: amd: create acp5x platform devices
Date: Wed, 7 Jul 2021 17:22:06 +0100 [thread overview]
Message-ID: <20210707162206.GF4394@sirena.org.uk> (raw)
In-Reply-To: <20210707055623.27371-5-vijendar.mukunda@amd.com>
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Wed, Jul 07, 2021 at 11:26:15AM +0530, Vijendar Mukunda wrote:
> +#define I2S_MODE 0x00
> +#define ACP5x_I2S_MODE 0x00
All the other constants are namespaced so why the plain I2S_MODE?
> + val = acp_readl(adata->acp5x_base + ACP_PIN_CONFIG);
> + switch (val) {
> + case I2S_MODE:
...
> + break;
> + default:
> + dev_info(&pci->dev, "ACP audio mode : %d\n", val);
> + }
Given that anything other than I2S is basically unhandled should we
perhaps print an error rather than just an info message?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Vijendar Mukunda <vijendar.mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, Sunil-kumar.Dommati@amd.com,
open list <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexander.Deucher@amd.com
Subject: Re: [PATCH 04/12] ASoC: amd: create acp5x platform devices
Date: Wed, 7 Jul 2021 17:22:06 +0100 [thread overview]
Message-ID: <20210707162206.GF4394@sirena.org.uk> (raw)
In-Reply-To: <20210707055623.27371-5-vijendar.mukunda@amd.com>
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Wed, Jul 07, 2021 at 11:26:15AM +0530, Vijendar Mukunda wrote:
> +#define I2S_MODE 0x00
> +#define ACP5x_I2S_MODE 0x00
All the other constants are namespaced so why the plain I2S_MODE?
> + val = acp_readl(adata->acp5x_base + ACP_PIN_CONFIG);
> + switch (val) {
> + case I2S_MODE:
...
> + break;
> + default:
> + dev_info(&pci->dev, "ACP audio mode : %d\n", val);
> + }
Given that anything other than I2S is basically unhandled should we
perhaps print an error rather than just an info message?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-07 16:22 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 5:56 [PATCH 00/12] Add Vangogh ACP ASoC driver Vijendar Mukunda
2021-07-07 5:56 ` [PATCH 01/12] ASoC: amd: add Vangogh ACP5x IP register header Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 5:56 ` [PATCH 02/12] ASoC: amd: add Vangogh ACP PCI driver Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 16:17 ` Mark Brown
2021-07-07 16:17 ` Mark Brown
2021-07-08 14:07 ` Mukunda,Vijendar
2021-07-08 14:07 ` Mukunda,Vijendar
2021-07-07 5:56 ` [PATCH 03/12] add acp5x init/de-init functions Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 16:15 ` Pierre-Louis Bossart
2021-07-07 16:15 ` Pierre-Louis Bossart
2021-07-08 13:30 ` Mukunda,Vijendar
2021-07-08 13:30 ` Mukunda,Vijendar
2021-07-07 5:56 ` [PATCH 04/12] ASoC: amd: create acp5x platform devices Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 16:22 ` Mark Brown [this message]
2021-07-07 16:22 ` Mark Brown
2021-07-08 15:02 ` Mukunda,Vijendar
2021-07-08 15:02 ` Mukunda,Vijendar
2021-07-07 5:56 ` [PATCH 05/12] ASoC: amd: add ACP5x PCM platform driver Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 16:17 ` Pierre-Louis Bossart
2021-07-07 16:17 ` Pierre-Louis Bossart
2021-07-08 13:31 ` Mukunda,Vijendar
2021-07-08 13:31 ` Mukunda,Vijendar
2021-07-07 16:24 ` Mark Brown
2021-07-07 16:24 ` Mark Brown
2021-07-08 11:57 ` Mukunda,Vijendar
2021-07-08 11:57 ` Mukunda,Vijendar
2021-07-07 5:56 ` [PATCH 06/12] ASoC: amd: irq handler changes for ACP5x PCM dma driver Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 16:20 ` Pierre-Louis Bossart
2021-07-07 16:20 ` Pierre-Louis Bossart
2021-07-08 13:32 ` Mukunda,Vijendar
2021-07-08 13:32 ` Mukunda,Vijendar
2021-07-07 5:56 ` [PATCH 07/12] ASoC: amd: add ACP5x pcm dma driver ops Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 16:27 ` Pierre-Louis Bossart
2021-07-07 16:27 ` Pierre-Louis Bossart
2021-07-08 11:56 ` Mukunda,Vijendar
2021-07-08 11:56 ` Mukunda,Vijendar
2021-07-07 16:30 ` Mark Brown
2021-07-07 16:30 ` Mark Brown
2021-07-08 11:43 ` Mukunda,Vijendar
2021-07-08 11:43 ` Mukunda,Vijendar
2021-07-07 5:56 ` [PATCH 08/12] ASoC: amd: add vangogh i2s controller driver Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 5:56 ` [PATCH 09/12] ASoC: amd: add vangogh i2s dai driver ops Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 16:35 ` Mark Brown
2021-07-07 16:35 ` Mark Brown
2021-07-08 11:30 ` Mukunda,Vijendar
2021-07-08 11:30 ` Mukunda,Vijendar
2021-07-07 5:56 ` [PATCH 10/12] ASoC: amd: add vangogh pci driver pm ops Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 16:34 ` Pierre-Louis Bossart
2021-07-07 16:34 ` Pierre-Louis Bossart
2021-07-08 11:41 ` Mukunda,Vijendar
2021-07-08 11:41 ` Mukunda,Vijendar
2021-07-13 6:36 ` Mukunda,Vijendar
2021-07-13 6:36 ` Mukunda,Vijendar
2021-07-14 16:23 ` Mark Brown
2021-07-15 23:49 ` Mukunda,Vijendar
2021-07-07 5:56 ` [PATCH 11/12] ASoc: amd: add vangogh i2s dma " Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 5:56 ` [PATCH 12/12] ASoC: amd: enable vangogh acp5x driver build Vijendar Mukunda
2021-07-07 5:56 ` Vijendar Mukunda
2021-07-07 9:00 ` kernel test robot
2021-07-07 9:00 ` kernel test robot
2021-07-07 9:00 ` kernel test robot
2021-07-08 14:08 ` Mukunda,Vijendar
2021-07-08 14:08 ` Mukunda, Vijendar
2021-07-08 14:08 ` Mukunda,Vijendar
2021-07-07 16:55 ` [PATCH 00/12] Add Vangogh ACP ASoC driver Mark Brown
2021-07-16 15:07 [PATCH V2 " Vijendar Mukunda
2021-07-16 15:08 ` [PATCH 04/12] ASoC: amd: create acp5x platform devices Vijendar Mukunda
2021-07-16 15:08 ` Vijendar Mukunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707162206.GF4394@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Alexander.Deucher@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vijendar.mukunda@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.