From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, broonie@kernel.org, alsa-devel@alsa-project.org Cc: Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>, open list <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>, Alexander.Deucher@amd.com Subject: Re: [PATCH 03/12] add acp5x init/de-init functions Date: Thu, 8 Jul 2021 19:00:09 +0530 [thread overview] Message-ID: <654d311a-b625-f7f9-76f6-326653f324a9@amd.com> (raw) In-Reply-To: <dca2f367-59a3-6ea6-7abc-c9817442eb86@linux.intel.com> On 7/7/21 9:45 PM, Pierre-Louis Bossart wrote: > Missing 'ASoC: amd' prefix in commit subject? Will add prefix. > > >> +static int acp5x_power_on(void __iomem *acp5x_base) >> +{ >> + u32 val; >> + int timeout; >> + >> + val = acp_readl(acp5x_base + ACP_PGFSM_STATUS); >> + >> + if (val == 0) >> + return val; >> + >> + if ((val & ACP_PGFSM_STATUS_MASK) != >> + ACP_POWER_ON_IN_PROGRESS) >> + acp_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, >> + acp5x_base + ACP_PGFSM_CONTROL); >> + timeout = 0; >> + while (++timeout < 500) { >> + val = acp_readl(acp5x_base + ACP_PGFSM_STATUS); >> + if (!val) > > Shouldn't you use something like > if ((val & ACP_PGFSM_STATUS_MASK) == ACP_POWERED_ON) > for symmetry with the power-off case? Yes we can do that. will fix it. > >> + return 0; >> + udelay(1); >> + } >> + return -ETIMEDOUT; >> +} >> + >> +static int acp5x_power_off(void __iomem *acp5x_base) >> +{ >> + u32 val; >> + int timeout; >> + >> + acp_writel(ACP_PGFSM_CNTL_POWER_OFF_MASK, >> + acp5x_base + ACP_PGFSM_CONTROL); >> + timeout = 0; >> + while (++timeout < 500) { >> + val = acp_readl(acp5x_base + ACP_PGFSM_STATUS); >> + if ((val & ACP_PGFSM_STATUS_MASK) == ACP_POWERED_OFF) >> + return 0; >> + udelay(1); >> + } >> + return -ETIMEDOUT; >> +} >> + >> +static int acp5x_reset(void __iomem *acp5x_base) >> +{ >> + u32 val; >> + int timeout; >> + >> + acp_writel(1, acp5x_base + ACP_SOFT_RESET); >> + timeout = 0; >> + while (++timeout < 500) { >> + val = acp_readl(acp5x_base + ACP_SOFT_RESET); >> + if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK) >> + break; >> + cpu_relax(); >> + } >> + acp_writel(0, acp5x_base + ACP_SOFT_RESET); >> + timeout = 0; >> + while (++timeout < 500) { >> + val = acp_readl(acp5x_base + ACP_SOFT_RESET); >> + if (!val) >> + return 0; >> + cpu_relax(); >> + } >> + return -ETIMEDOUT; >> +} >> + >> +static void acp5x_enable_interrupts(void __iomem *acp5x_base) >> +{ >> + acp_writel(0x01, acp5x_base + ACP_EXTERNAL_INTR_ENB); >> +} >> + >> +static void acp5x_disable_interrupts(void __iomem *acp5x_base) >> +{ >> + acp_writel(ACP_EXT_INTR_STAT_CLEAR_MASK, acp5x_base + >> + ACP_EXTERNAL_INTR_STAT); >> + acp_writel(0x00, acp5x_base + ACP_EXTERNAL_INTR_CNTL); >> + acp_writel(0x00, acp5x_base + ACP_EXTERNAL_INTR_ENB); >> +} >> + >> +static int acp5x_init(void __iomem *acp5x_base) >> +{ >> + int ret; >> + >> + /* power on */ >> + ret = acp5x_power_on(acp5x_base); >> + if (ret) { >> + pr_err("ACP5x power on failed\n"); >> + return ret; >> + } >> + /* Reset */ >> + ret = acp5x_reset(acp5x_base); >> + if (ret) { >> + pr_err("ACP5x reset failed\n"); >> + return ret; >> + } >> + acp5x_enable_interrupts(acp5x_base); >> + return 0; >> +} >> + >> +static int acp5x_deinit(void __iomem *acp5x_base) >> +{ >> + int ret; >> + >> + acp5x_disable_interrupts(acp5x_base); >> + /* Reset */ >> + ret = acp5x_reset(acp5x_base); >> + if (ret) { >> + pr_err("ACP5x reset failed\n"); >> + return ret; >> + } >> + /* power off */ >> + if (acp_power_gating) { >> + ret = acp5x_power_off(acp5x_base); >> + if (ret) { >> + pr_err("ACP5x power off failed\n"); >> + return ret; >> + } >> + } >> + return 0; > > shouldn't you have a sequence for shutdown that ignores the acp_power_gating parameter? > BIOS will apply ACP Power gating(which is part of ACP power off sequence) when ACP enters D3 state. i.e BIOS will control ACP Power gating. acp5x_power_off() API is no longer required.This was implemented to verify ACP Power gating during initial driver bring up. We will drop acp5x_power_off() API, will remove acp_power_gating parameter and post the new version.
WARNING: multiple messages have this Message-ID (diff)
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, broonie@kernel.org, alsa-devel@alsa-project.org Cc: Alexander.Deucher@amd.com, Takashi Iwai <tiwai@suse.com>, Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 03/12] add acp5x init/de-init functions Date: Thu, 8 Jul 2021 19:00:09 +0530 [thread overview] Message-ID: <654d311a-b625-f7f9-76f6-326653f324a9@amd.com> (raw) In-Reply-To: <dca2f367-59a3-6ea6-7abc-c9817442eb86@linux.intel.com> On 7/7/21 9:45 PM, Pierre-Louis Bossart wrote: > Missing 'ASoC: amd' prefix in commit subject? Will add prefix. > > >> +static int acp5x_power_on(void __iomem *acp5x_base) >> +{ >> + u32 val; >> + int timeout; >> + >> + val = acp_readl(acp5x_base + ACP_PGFSM_STATUS); >> + >> + if (val == 0) >> + return val; >> + >> + if ((val & ACP_PGFSM_STATUS_MASK) != >> + ACP_POWER_ON_IN_PROGRESS) >> + acp_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, >> + acp5x_base + ACP_PGFSM_CONTROL); >> + timeout = 0; >> + while (++timeout < 500) { >> + val = acp_readl(acp5x_base + ACP_PGFSM_STATUS); >> + if (!val) > > Shouldn't you use something like > if ((val & ACP_PGFSM_STATUS_MASK) == ACP_POWERED_ON) > for symmetry with the power-off case? Yes we can do that. will fix it. > >> + return 0; >> + udelay(1); >> + } >> + return -ETIMEDOUT; >> +} >> + >> +static int acp5x_power_off(void __iomem *acp5x_base) >> +{ >> + u32 val; >> + int timeout; >> + >> + acp_writel(ACP_PGFSM_CNTL_POWER_OFF_MASK, >> + acp5x_base + ACP_PGFSM_CONTROL); >> + timeout = 0; >> + while (++timeout < 500) { >> + val = acp_readl(acp5x_base + ACP_PGFSM_STATUS); >> + if ((val & ACP_PGFSM_STATUS_MASK) == ACP_POWERED_OFF) >> + return 0; >> + udelay(1); >> + } >> + return -ETIMEDOUT; >> +} >> + >> +static int acp5x_reset(void __iomem *acp5x_base) >> +{ >> + u32 val; >> + int timeout; >> + >> + acp_writel(1, acp5x_base + ACP_SOFT_RESET); >> + timeout = 0; >> + while (++timeout < 500) { >> + val = acp_readl(acp5x_base + ACP_SOFT_RESET); >> + if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK) >> + break; >> + cpu_relax(); >> + } >> + acp_writel(0, acp5x_base + ACP_SOFT_RESET); >> + timeout = 0; >> + while (++timeout < 500) { >> + val = acp_readl(acp5x_base + ACP_SOFT_RESET); >> + if (!val) >> + return 0; >> + cpu_relax(); >> + } >> + return -ETIMEDOUT; >> +} >> + >> +static void acp5x_enable_interrupts(void __iomem *acp5x_base) >> +{ >> + acp_writel(0x01, acp5x_base + ACP_EXTERNAL_INTR_ENB); >> +} >> + >> +static void acp5x_disable_interrupts(void __iomem *acp5x_base) >> +{ >> + acp_writel(ACP_EXT_INTR_STAT_CLEAR_MASK, acp5x_base + >> + ACP_EXTERNAL_INTR_STAT); >> + acp_writel(0x00, acp5x_base + ACP_EXTERNAL_INTR_CNTL); >> + acp_writel(0x00, acp5x_base + ACP_EXTERNAL_INTR_ENB); >> +} >> + >> +static int acp5x_init(void __iomem *acp5x_base) >> +{ >> + int ret; >> + >> + /* power on */ >> + ret = acp5x_power_on(acp5x_base); >> + if (ret) { >> + pr_err("ACP5x power on failed\n"); >> + return ret; >> + } >> + /* Reset */ >> + ret = acp5x_reset(acp5x_base); >> + if (ret) { >> + pr_err("ACP5x reset failed\n"); >> + return ret; >> + } >> + acp5x_enable_interrupts(acp5x_base); >> + return 0; >> +} >> + >> +static int acp5x_deinit(void __iomem *acp5x_base) >> +{ >> + int ret; >> + >> + acp5x_disable_interrupts(acp5x_base); >> + /* Reset */ >> + ret = acp5x_reset(acp5x_base); >> + if (ret) { >> + pr_err("ACP5x reset failed\n"); >> + return ret; >> + } >> + /* power off */ >> + if (acp_power_gating) { >> + ret = acp5x_power_off(acp5x_base); >> + if (ret) { >> + pr_err("ACP5x power off failed\n"); >> + return ret; >> + } >> + } >> + return 0; > > shouldn't you have a sequence for shutdown that ignores the acp_power_gating parameter? > BIOS will apply ACP Power gating(which is part of ACP power off sequence) when ACP enters D3 state. i.e BIOS will control ACP Power gating. acp5x_power_off() API is no longer required.This was implemented to verify ACP Power gating during initial driver bring up. We will drop acp5x_power_off() API, will remove acp_power_gating parameter and post the new version.
next prev parent reply other threads:[~2021-07-08 13:12 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-07 5:56 [PATCH 00/12] Add Vangogh ACP ASoC driver Vijendar Mukunda 2021-07-07 5:56 ` [PATCH 01/12] ASoC: amd: add Vangogh ACP5x IP register header Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 5:56 ` [PATCH 02/12] ASoC: amd: add Vangogh ACP PCI driver Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:17 ` Mark Brown 2021-07-07 16:17 ` Mark Brown 2021-07-08 14:07 ` Mukunda,Vijendar 2021-07-08 14:07 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 03/12] add acp5x init/de-init functions Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:15 ` Pierre-Louis Bossart 2021-07-07 16:15 ` Pierre-Louis Bossart 2021-07-08 13:30 ` Mukunda,Vijendar [this message] 2021-07-08 13:30 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 04/12] ASoC: amd: create acp5x platform devices Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:22 ` Mark Brown 2021-07-07 16:22 ` Mark Brown 2021-07-08 15:02 ` Mukunda,Vijendar 2021-07-08 15:02 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 05/12] ASoC: amd: add ACP5x PCM platform driver Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:17 ` Pierre-Louis Bossart 2021-07-07 16:17 ` Pierre-Louis Bossart 2021-07-08 13:31 ` Mukunda,Vijendar 2021-07-08 13:31 ` Mukunda,Vijendar 2021-07-07 16:24 ` Mark Brown 2021-07-07 16:24 ` Mark Brown 2021-07-08 11:57 ` Mukunda,Vijendar 2021-07-08 11:57 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 06/12] ASoC: amd: irq handler changes for ACP5x PCM dma driver Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:20 ` Pierre-Louis Bossart 2021-07-07 16:20 ` Pierre-Louis Bossart 2021-07-08 13:32 ` Mukunda,Vijendar 2021-07-08 13:32 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 07/12] ASoC: amd: add ACP5x pcm dma driver ops Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:27 ` Pierre-Louis Bossart 2021-07-07 16:27 ` Pierre-Louis Bossart 2021-07-08 11:56 ` Mukunda,Vijendar 2021-07-08 11:56 ` Mukunda,Vijendar 2021-07-07 16:30 ` Mark Brown 2021-07-07 16:30 ` Mark Brown 2021-07-08 11:43 ` Mukunda,Vijendar 2021-07-08 11:43 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 08/12] ASoC: amd: add vangogh i2s controller driver Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 5:56 ` [PATCH 09/12] ASoC: amd: add vangogh i2s dai driver ops Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:35 ` Mark Brown 2021-07-07 16:35 ` Mark Brown 2021-07-08 11:30 ` Mukunda,Vijendar 2021-07-08 11:30 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 10/12] ASoC: amd: add vangogh pci driver pm ops Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:34 ` Pierre-Louis Bossart 2021-07-07 16:34 ` Pierre-Louis Bossart 2021-07-08 11:41 ` Mukunda,Vijendar 2021-07-08 11:41 ` Mukunda,Vijendar 2021-07-13 6:36 ` Mukunda,Vijendar 2021-07-13 6:36 ` Mukunda,Vijendar 2021-07-14 16:23 ` Mark Brown 2021-07-15 23:49 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 11/12] ASoc: amd: add vangogh i2s dma " Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 5:56 ` [PATCH 12/12] ASoC: amd: enable vangogh acp5x driver build Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 9:00 ` kernel test robot 2021-07-07 9:00 ` kernel test robot 2021-07-07 9:00 ` kernel test robot 2021-07-08 14:08 ` Mukunda,Vijendar 2021-07-08 14:08 ` Mukunda, Vijendar 2021-07-08 14:08 ` Mukunda,Vijendar 2021-07-07 16:55 ` [PATCH 00/12] Add Vangogh ACP ASoC driver Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=654d311a-b625-f7f9-76f6-326653f324a9@amd.com \ --to=vijendar.mukunda@amd.com \ --cc=Alexander.Deucher@amd.com \ --cc=Sunil-kumar.Dommati@amd.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.