From: Lorenzo Pieralisi <firstname.lastname@example.org> To: Dan Williams <email@example.com> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>, Linux PCI <firstname.lastname@example.org>, email@example.com, Bjorn Helgaas <firstname.lastname@example.org>, "Weiny, Ira" <email@example.com>, Ben Widawsky <firstname.lastname@example.org>, Chris Browy <email@example.com>, Linux ACPI <firstname.lastname@example.org>, "Schofield, Alison" <email@example.com>, Vishal L Verma <firstname.lastname@example.org>, Fangjian <email@example.com>, Linuxarm <firstname.lastname@example.org> Subject: Re: [PATCH v4 2/5] PCI/DOE: Add Data Object Exchange support Date: Thu, 8 Jul 2021 09:48:15 +0100 [thread overview] Message-ID: <20210708084815.GA6845@lpieralisi> (raw) In-Reply-To: <CAPcyv4i2ukD4ZQ_KfTaKXLyMakpSk=Y3_QJGV2P_PLHHVkPwFw@mail.gmail.com> On Wed, Jul 07, 2021 at 12:54:33PM -0700, Dan Williams wrote: > On Thu, Jun 10, 2021 at 1:06 PM Dan Williams <email@example.com> wrote: > > > > On Mon, May 24, 2021 at 6:41 AM Jonathan Cameron > > <Jonathan.Cameron@huawei.com> wrote: > > > > > > Introduced in a PCI ECN , DOE provides a config space based mailbox with > > > standard protocol discovery. Each mailbox is accessed through a DOE > > > Extended Capability. > > > > > > A device may have 1 or more DOE mailboxes, each of which is allowed to > > > support any number of protocols (some DOE protocol specifications apply > > > additional restrictions). A given protocol may be supported on more than > > > one DOE mailbox on a given function. > > > > > > If a driver wishes to access any number of DOE instances / protocols it > > > makes a single call to pci_doe_register_all() which will find available > > > DOEs, create the required infrastructure and cache the protocols they > > > support. pci_doe_find() can then retrieve a pointer to an appropriate DOE > > > instance. > > > > > > A synchronous interface is provided in pci_doe_exchange_sync() to perform a > > > single query / response exchange. > > > > > > Testing conducted against QEMU using: > > > > > > https://firstname.lastname@example.org/ > > > > Nice. > > > > I was hoping that by now QEMU upstream would have given us some > > indication that this useful work that has a chance of being merged. I > > fear it's only us CXL practitioner's that care. Perhaps the PCI IDE > > support will get them to move on at least the DOE patches? > > > > > > > >  https://members.pcisig.com/wg/PCI-SIG/document/14143 > > > Data Object Exchange (DOE) - Approved 12 March 2020 > > > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > The core logic of this looks good to me. The interfaces for other code > > to make use of this I feel can lean heavier on existing mechanics. A > > few points come to mind: > > > > - Does this need to support anything more than queue depth 1? I know > > the specification seems to allow for some overlapping and queueing, > > but I don't think there are any use cases that are precluded if the > > max number of tasks in flight for a given DOE is one. > > > > - Once its queue depth 1 then the list of tasks can be replaced with a > > wait_queue_head_t where submitters wait for the previous task to > > finish. > > > > - This appears to be the prototypical scenario for deploying the new > > auxiliary bus facility. Rather than custom code device-like facilities > > (lists and parents etc) in 'struct pci_doe' just make pci_doe a device > > directly (auxiliary-device) and separate the infrastructure that > > drives that device to a driver (auxiliary-driver). That makes the > > lifetime management more idiomatic, allows for user space to have > > typical driver-binding controls to manage kernel-user DOE conflicts, > > and it allows for typical driver services like devm. > > Hi Jonathan, > > Are you waiting on me to take a shot at refactoring the DOE driver > into this proposed auxiliary device/driver organization? I am happy to > do that if you've moved on to looking at the kernel-side SPDM > implementation . > > I would expect DOE, SPDM, and IDE would be a useful topic to discuss > at the the Plumbers PCI Microconference assuming we do not solve all > the open issues before September. Definitely, I will make sure we schedule a slot on these topics. Thanks, Lorenzo > : https://lore.kernel.org/r/20210629132520.00000d1f@Huawei.com
next prev parent reply other threads:[~2021-07-08 8:48 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-24 13:39 [PATCH v4 0/5] PCI Data Object Exchange support + CXL CDAT Jonathan Cameron 2021-05-24 13:39 ` [PATCH v4 1/5] PCI: Add vendor ID for the PCI SIG Jonathan Cameron 2021-06-10 15:17 ` Dan Williams 2021-06-10 17:39 ` Jonathan Cameron 2021-06-10 20:10 ` Dan Williams 2021-05-24 13:39 ` [PATCH v4 2/5] PCI/DOE: Add Data Object Exchange support Jonathan Cameron 2021-06-10 20:06 ` Dan Williams 2021-07-07 19:54 ` Dan Williams 2021-07-08 8:48 ` Lorenzo Pieralisi [this message] 2021-07-08 17:28 ` Jonathan Cameron 2021-05-24 13:39 ` [PATCH v4 3/5] cxl/mem: Add CDAT table reading from DOE Jonathan Cameron 2021-06-10 21:46 ` Dan Williams 2021-05-24 13:39 ` [PATCH v4 4/5] DONOTMERGE: PCI/DOE: Add per DOE chrdev for ioctl based access Jonathan Cameron 2021-05-25 10:26 ` kernel test robot 2021-05-24 13:39 ` [PATCH v4 5/5] DONOTMERGE: PCI/DOE: Add userspace example program to tools/pci Jonathan Cameron 2021-06-10 14:30 ` [PATCH v4 0/5] PCI Data Object Exchange support + CXL CDAT Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210708084815.GA6845@lpieralisi \ --email@example.com \ --cc=Jonathan.Cameron@huawei.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4 2/5] PCI/DOE: Add Data Object Exchange support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.