All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 6/7] drm/i915/display/adl_p: Correctly program MBUS DBOX A credits
Date: Thu,  8 Jul 2021 14:18:26 -0700	[thread overview]
Message-ID: <20210708211827.288601-6-jose.souza@intel.com> (raw)
In-Reply-To: <20210708211827.288601-1-jose.souza@intel.com>

Alderlake-P have different values for MBUS DBOX A credits depending
if MBUS join is enabled or not.

BSpec: 50343
BSpec: 54369
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 65ddb6ca16e67..fe380896eb99e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -3400,13 +3400,17 @@ static void glk_pipe_scaler_clock_gating_wa(struct drm_i915_private *dev_priv,
 	intel_de_write(dev_priv, CLKGATE_DIS_PSL(pipe), val);
 }
 
-static void icl_pipe_mbus_enable(struct intel_crtc *crtc)
+static void icl_pipe_mbus_enable(struct intel_crtc *crtc, bool joined_mbus)
 {
 	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
 	enum pipe pipe = crtc->pipe;
 	u32 val;
 
-	val = MBUS_DBOX_A_CREDIT(2);
+	/* Wa_22010947358:adl-p */
+	if (IS_ALDERLAKE_P(dev_priv))
+		val = joined_mbus ? MBUS_DBOX_A_CREDIT(6) : MBUS_DBOX_A_CREDIT(4);
+	else
+		val = MBUS_DBOX_A_CREDIT(2);
 
 	if (DISPLAY_VER(dev_priv) >= 12) {
 		val |= MBUS_DBOX_BW_CREDIT(2);
@@ -3561,8 +3565,12 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
 	if (dev_priv->display.initial_watermarks)
 		dev_priv->display.initial_watermarks(state, crtc);
 
-	if (DISPLAY_VER(dev_priv) >= 11)
-		icl_pipe_mbus_enable(crtc);
+	if (DISPLAY_VER(dev_priv) >= 11) {
+		const struct intel_dbuf_state *dbuf_state =
+				intel_atomic_get_new_dbuf_state(state);
+
+		icl_pipe_mbus_enable(crtc, dbuf_state->joined_mbus);
+	}
 
 	if (new_crtc_state->bigjoiner_slave)
 		intel_crtc_vblank_on(new_crtc_state);
-- 
2.32.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-07-08 21:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 21:18 [Intel-gfx] [PATCH 1/7] drm/i915: Settle on "adl-x" in WA comments José Roberto de Souza
2021-07-08 21:18 ` [Intel-gfx] [PATCH 2/7] drm/i915: Implement Wa_1508744258 José Roberto de Souza
2021-07-10  5:06   ` Matt Roper
2021-08-12  3:27   ` Timo Aaltonen
2021-08-12  6:29     ` Timo Aaltonen
2021-08-12 15:56       ` Souza, Jose
2021-07-08 21:18 ` [Intel-gfx] [PATCH 3/7] drm/i915/adl_s: Extend Wa_1406941453 José Roberto de Souza
2021-07-10  5:07   ` Matt Roper
2021-07-08 21:18 ` [Intel-gfx] [PATCH 4/7] drm/i915: Limit maximum number of memory channels José Roberto de Souza
2021-07-08 21:18 ` [Intel-gfx] [PATCH 5/7] drm/i915: Limit Wa_22010178259 to affected platforms José Roberto de Souza
2021-07-10  5:29   ` Matt Roper
2021-07-08 21:18 ` José Roberto de Souza [this message]
2021-07-10  5:41   ` [Intel-gfx] [PATCH 6/7] drm/i915/display/adl_p: Correctly program MBUS DBOX A credits Matt Roper
2021-08-03 20:19     ` Souza, Jose
2021-08-03 22:39       ` Matt Roper
2021-07-08 21:18 ` [Intel-gfx] [PATCH 7/7] drm/i915/display/xelpd: Exetend Wa_14011508470 José Roberto de Souza
2021-07-10  5:42   ` Matt Roper
2021-07-08 23:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: Settle on "adl-x" in WA comments Patchwork
2021-07-08 23:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-09 14:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-07-10  4:55 ` [Intel-gfx] [PATCH 1/7] " Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210708211827.288601-6-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.