non-DM SPI_FLASH removal?

non-DM SPI_FLASH removal?

[Marek Behun]

Tom,

there are 16 boards left with CONFIG_SPI_FLASH
(git grep CONFIG_SPI_FLASH=y)
and Makefile says this was supposed to be deprecated in v2019.07.

Are we going to remove them so that we can simplify the SPI subsystem?

Marek

Re: non-DM SPI_FLASH removal?

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

On Mon, Jul 12, 2021 at 04:01:13PM +0200, Marek Behun wrote:

> Tom,
> 
> there are 16 boards left with CONFIG_SPI_FLASH
> (git grep CONFIG_SPI_FLASH=y)
> and Makefile says this was supposed to be deprecated in v2019.07.
> 
> Are we going to remove them so that we can simplify the SPI subsystem?

The warning is on CONFIG_SPI_FLASH without CONFIG_DM_SPI_FLASH and of
course outside of SPL.  When I asked Jagan about this off-list last
month or so, he said everything had been migrated, and I couldn't make
any boards fail by making the migration warning in the makefile be an
error.  I think that means that if you have SPI subsystem cleanups you
want to do / post, please do so, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: non-DM SPI_FLASH removal?

[Marek Behun]

On Mon, 12 Jul 2021 16:01:13 +0200
Marek Behun <marek.behun@nic.cz> wrote:

> Tom,
> 
> there are 16 boards left with CONFIG_SPI_FLASH
> (git grep CONFIG_SPI_FLASH=y)
> and Makefile says this was supposed to be deprecated in v2019.07.
> 
> Are we going to remove them so that we can simplify the SPI subsystem?
> 
> Marek

Alternatively it seems all those boards have devicetrees, and
at91-vinco even has "jedec,spi-nor" compatible device defined.

The m68k devices don't have SPI-NOR device under their spi controller
in device-tree, though.

Re: non-DM SPI_FLASH removal?

[Marek Behun]

On Mon, 12 Jul 2021 10:10:14 -0400
Tom Rini <trini@konsulko.com> wrote:

> On Mon, Jul 12, 2021 at 04:01:13PM +0200, Marek Behun wrote:
> 
> > Tom,
> > 
> > there are 16 boards left with CONFIG_SPI_FLASH
> > (git grep CONFIG_SPI_FLASH=y)
> > and Makefile says this was supposed to be deprecated in v2019.07.
> > 
> > Are we going to remove them so that we can simplify the SPI subsystem?  
> 
> The warning is on CONFIG_SPI_FLASH without CONFIG_DM_SPI_FLASH and of
> course outside of SPL.  When I asked Jagan about this off-list last
> month or so, he said everything had been migrated, and I couldn't make
> any boards fail by making the migration warning in the makefile be an
> error.  I think that means that if you have SPI subsystem cleanups you
> want to do / post, please do so, thanks!
> 

None of the boards from
  git grep CONFIG_SPI_FLASH=y
have CONFIG_DM_SPI_FLASH defined. These boards are not migrated.

Marek

Re: non-DM SPI_FLASH removal?

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]

On Mon, Jul 12, 2021 at 04:15:10PM +0200, Marek Behun wrote:
> On Mon, 12 Jul 2021 10:10:14 -0400
> Tom Rini <trini@konsulko.com> wrote:
> 
> > On Mon, Jul 12, 2021 at 04:01:13PM +0200, Marek Behun wrote:
> > 
> > > Tom,
> > > 
> > > there are 16 boards left with CONFIG_SPI_FLASH
> > > (git grep CONFIG_SPI_FLASH=y)
> > > and Makefile says this was supposed to be deprecated in v2019.07.
> > > 
> > > Are we going to remove them so that we can simplify the SPI subsystem?  
> > 
> > The warning is on CONFIG_SPI_FLASH without CONFIG_DM_SPI_FLASH and of
> > course outside of SPL.  When I asked Jagan about this off-list last
> > month or so, he said everything had been migrated, and I couldn't make
> > any boards fail by making the migration warning in the makefile be an
> > error.  I think that means that if you have SPI subsystem cleanups you
> > want to do / post, please do so, thanks!
> > 
> 
> None of the boards from
>   git grep CONFIG_SPI_FLASH=y
> have CONFIG_DM_SPI_FLASH defined. These boards are not migrated.

Well, hunh.  I guess I messed up my "find all of the boards that need
removing, for DM_SPI_FLASH" test.  I see that warning popping up when I
build it locally, right now.  Time to fire off a removal series then,
thanks for bringing this up!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]