* [PATCH 1/1] RDMA/irdma: change the returned type to void
@ 2021-07-08 6:47 yanjun.zhu
2021-07-07 14:33 ` Majd Dibbiny
2021-07-12 18:11 ` Jason Gunthorpe
0 siblings, 2 replies; 4+ messages in thread
From: yanjun.zhu @ 2021-07-08 6:47 UTC (permalink / raw)
To: yanjun.zhu, zyjzyj2000, mustafa.ismail, shiraz.saleem, dledford,
jgg, linux-rdma
From: Zhu Yanjun <yanjun.zhu@linux.dev>
Since the function irdma_sc_parse_fpm_commit_buf always returns 0,
remove the returned value check and change the returned type to void.
Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/infiniband/hw/irdma/ctrl.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/irdma/ctrl.c b/drivers/infiniband/hw/irdma/ctrl.c
index b1023a7d0bd1..c3880a85e255 100644
--- a/drivers/infiniband/hw/irdma/ctrl.c
+++ b/drivers/infiniband/hw/irdma/ctrl.c
@@ -2845,7 +2845,7 @@ static u64 irdma_sc_decode_fpm_commit(struct irdma_sc_dev *dev, __le64 *buf,
* parses fpm commit info and copy base value
* of hmc objects in hmc_info
*/
-static enum irdma_status_code
+static void
irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,
struct irdma_hmc_obj_info *info, u32 *sd)
{
@@ -2915,7 +2915,6 @@ irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,
else
*sd = (u32)(size >> 21);
- return 0;
}
/**
@@ -4434,9 +4433,9 @@ static enum irdma_status_code irdma_sc_cfg_iw_fpm(struct irdma_sc_dev *dev,
ret_code = irdma_sc_commit_fpm_val(dev->cqp, 0, hmc_info->hmc_fn_id,
&commit_fpm_mem, true, wait_type);
if (!ret_code)
- ret_code = irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
- hmc_info->hmc_obj,
- &hmc_info->sd_table.sd_cnt);
+ irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
+ hmc_info->hmc_obj,
+ &hmc_info->sd_table.sd_cnt);
print_hex_dump_debug("HMC: COMMIT FPM BUFFER", DUMP_PREFIX_OFFSET, 16,
8, commit_fpm_mem.va, IRDMA_COMMIT_FPM_BUF_SIZE,
false);
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] RDMA/irdma: change the returned type to void
2021-07-08 6:47 [PATCH 1/1] RDMA/irdma: change the returned type to void yanjun.zhu
@ 2021-07-07 14:33 ` Majd Dibbiny
2021-07-07 16:57 ` Nikolova, Tatyana E
2021-07-12 18:11 ` Jason Gunthorpe
1 sibling, 1 reply; 4+ messages in thread
From: Majd Dibbiny @ 2021-07-07 14:33 UTC (permalink / raw)
To: yanjun.zhu
Cc: zyjzyj2000, mustafa.ismail, shiraz.saleem, dledford, jgg, linux-rdma
> On 7 Jul 2021, at 17:24, yanjun.zhu@linux.dev wrote:
>
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> Since the function irdma_sc_parse_fpm_commit_buf always returns 0,
> remove the returned value check and change the returned type to void.
>
> Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: Majd Dibbiny <majd@nvidia.com>
> ---
> drivers/infiniband/hw/irdma/ctrl.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/infiniband/hw/irdma/ctrl.c b/drivers/infiniband/hw/irdma/ctrl.c
> index b1023a7d0bd1..c3880a85e255 100644
> --- a/drivers/infiniband/hw/irdma/ctrl.c
> +++ b/drivers/infiniband/hw/irdma/ctrl.c
> @@ -2845,7 +2845,7 @@ static u64 irdma_sc_decode_fpm_commit(struct irdma_sc_dev *dev, __le64 *buf,
> * parses fpm commit info and copy base value
> * of hmc objects in hmc_info
> */
> -static enum irdma_status_code
> +static void
> irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,
> struct irdma_hmc_obj_info *info, u32 *sd)
> {
> @@ -2915,7 +2915,6 @@ irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,
> else
> *sd = (u32)(size >> 21);
>
> - return 0;
> }
>
> /**
> @@ -4434,9 +4433,9 @@ static enum irdma_status_code irdma_sc_cfg_iw_fpm(struct irdma_sc_dev *dev,
> ret_code = irdma_sc_commit_fpm_val(dev->cqp, 0, hmc_info->hmc_fn_id,
> &commit_fpm_mem, true, wait_type);
> if (!ret_code)
> - ret_code = irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
> - hmc_info->hmc_obj,
> - &hmc_info->sd_table.sd_cnt);
> + irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
> + hmc_info->hmc_obj,
> + &hmc_info->sd_table.sd_cnt);
> print_hex_dump_debug("HMC: COMMIT FPM BUFFER", DUMP_PREFIX_OFFSET, 16,
> 8, commit_fpm_mem.va, IRDMA_COMMIT_FPM_BUF_SIZE,
> false);
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH 1/1] RDMA/irdma: change the returned type to void
2021-07-07 14:33 ` Majd Dibbiny
@ 2021-07-07 16:57 ` Nikolova, Tatyana E
0 siblings, 0 replies; 4+ messages in thread
From: Nikolova, Tatyana E @ 2021-07-07 16:57 UTC (permalink / raw)
To: Majd Dibbiny, yanjun.zhu
Cc: zyjzyj2000, Ismail, Mustafa, Saleem, Shiraz, dledford, jgg, linux-rdma
> -----Original Message-----
> From: Majd Dibbiny <majd@nvidia.com>
> Sent: Wednesday, July 7, 2021 7:33 AM
> To: yanjun.zhu@linux.dev
> Cc: zyjzyj2000@gmail.com; Ismail, Mustafa <mustafa.ismail@intel.com>;
> Saleem, Shiraz <shiraz.saleem@intel.com>; dledford@redhat.com;
> jgg@ziepe.ca; linux-rdma@vger.kernel.org
> Subject: Re: [PATCH 1/1] RDMA/irdma: change the returned type to void
>
>
> > On 7 Jul 2021, at 17:24, yanjun.zhu@linux.dev wrote:
> >
> > From: Zhu Yanjun <yanjun.zhu@linux.dev>
> >
> > Since the function irdma_sc_parse_fpm_commit_buf always returns 0,
> > remove the returned value check and change the returned type to void.
> >
> > Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
> > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Reviewed-by: Majd Dibbiny <majd@nvidia.com>
> > ---
> > drivers/infiniband/hw/irdma/ctrl.c | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/irdma/ctrl.c
> > b/drivers/infiniband/hw/irdma/ctrl.c
> > index b1023a7d0bd1..c3880a85e255 100644
> > --- a/drivers/infiniband/hw/irdma/ctrl.c
> > +++ b/drivers/infiniband/hw/irdma/ctrl.c
> > @@ -2845,7 +2845,7 @@ static u64 irdma_sc_decode_fpm_commit(struct
> > irdma_sc_dev *dev, __le64 *buf,
> > * parses fpm commit info and copy base value
> > * of hmc objects in hmc_info
> > */
> > -static enum irdma_status_code
> > +static void
> > irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64
> *buf,
> > struct irdma_hmc_obj_info *info, u32 *sd) { @@
> > -2915,7 +2915,6 @@ irdma_sc_parse_fpm_commit_buf(struct
> irdma_sc_dev *dev, __le64 *buf,
> > else
> > *sd = (u32)(size >> 21);
> >
> > - return 0;
> > }
> >
> > /**
> > @@ -4434,9 +4433,9 @@ static enum irdma_status_code
> irdma_sc_cfg_iw_fpm(struct irdma_sc_dev *dev,
> > ret_code = irdma_sc_commit_fpm_val(dev->cqp, 0, hmc_info-
> >hmc_fn_id,
> > &commit_fpm_mem, true, wait_type);
> > if (!ret_code)
> > - ret_code = irdma_sc_parse_fpm_commit_buf(dev, dev-
> >fpm_commit_buf,
> > - hmc_info->hmc_obj,
> > - &hmc_info->sd_table.sd_cnt);
> > + irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
> > + hmc_info->hmc_obj,
> > + &hmc_info->sd_table.sd_cnt);
> > print_hex_dump_debug("HMC: COMMIT FPM BUFFER",
> DUMP_PREFIX_OFFSET, 16,
> > 8, commit_fpm_mem.va, IRDMA_COMMIT_FPM_BUF_SIZE,
> > false);
> > --
> > 2.27.0
> >
Acked-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] RDMA/irdma: change the returned type to void
2021-07-08 6:47 [PATCH 1/1] RDMA/irdma: change the returned type to void yanjun.zhu
2021-07-07 14:33 ` Majd Dibbiny
@ 2021-07-12 18:11 ` Jason Gunthorpe
1 sibling, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2021-07-12 18:11 UTC (permalink / raw)
To: yanjun.zhu
Cc: zyjzyj2000, mustafa.ismail, shiraz.saleem, dledford, linux-rdma
On Thu, Jul 08, 2021 at 02:47:52AM -0400, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> Since the function irdma_sc_parse_fpm_commit_buf always returns 0,
> remove the returned value check and change the returned type to void.
>
> Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Reviewed-by: Majd Dibbiny <majd@nvidia.com>
> Acked-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
> ---
> drivers/infiniband/hw/irdma/ctrl.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-12 18:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 6:47 [PATCH 1/1] RDMA/irdma: change the returned type to void yanjun.zhu
2021-07-07 14:33 ` Majd Dibbiny
2021-07-07 16:57 ` Nikolova, Tatyana E
2021-07-12 18:11 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.