From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: John Stultz <john.stultz@linaro.org> Cc: Serge Semin <fancer.lancer@gmail.com>, Felipe Balbi <balbi@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Rob Herring <robh+dt@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Linux USB List <linux-usb@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Amit Pundir <amit.pundir@linaro.org> Subject: Re: [PATCH 29/29] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name Date: Wed, 14 Jul 2021 15:48:07 +0300 [thread overview] Message-ID: <20210714124807.o22mottsrg3tv6nt@mobilestation> (raw) In-Reply-To: <CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com> Hello John, On Tue, Jul 13, 2021 at 05:07:00PM -0700, John Stultz wrote: > On Tue, Oct 20, 2020 at 5:10 AM Serge Semin > <Sergey.Semin@baikalelectronics.ru> wrote: > > > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > I know folks like to ignore this, but this patch breaks AOSP on db845c. :( Sorry to hear that. Alas there is no much can be done about it. DT-nodes name is a subject of DT-schema convention and as we've finally unified USB-controller nodes it shouldn't be reverted back. You can find the final USB-controller bindings in: Documentation/devicetree/bindings/usb/usb.yaml It strictly defines to have USB-nodes with names like "usb(@.*)". Reverting this patch will cause the DT-bindings check procedure failure. You can also find the naming convention defined in the latest DT spec: https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 See also device-tree bindings requirements listed in the file: Documentation/devicetree/bindings/writing-bindings.rst It says: "DO use node names matching the class of the device. Many standard names are defined in the DT Spec. If there isn't one, consider adding it." > > In the exact same way an earlier patch broke HiKey960: > https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ > > (which I still have to carry a revert for). > > I get that this change is useful so more dynamic userland can find > devices using consistent naming with future kernels (but doesn't the > dynamic userland have to handle the case for older kernels as well?) > But for userland that uses static configs, its painful as updating > userland to use the new node ids then causes older kernels to fail. > > I'm looking into how we might be able to probe and set the property > dynamically, but AOSP's init system is far more aligned to static > configs. > As Krzysztof said in https://lore.kernel.org/lkml/20201221210423.GA2504@kozik-lap/ and Bjorn noted in his response to your email, the only way to solve the problem is to fix the user-land app so one would be able to deal with both old and new DT-nodes name. Alternatively you can just replace the dts with older one, where the name still have the "dwc3"-prefix. -Sergey > This will probably be ignored again, but it would be nice if we could > have a release where DTS changes don't break userland for one of my > boards. As it feels like its been awhile. > > thanks > -john
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: John Stultz <john.stultz@linaro.org> Cc: Serge Semin <fancer.lancer@gmail.com>, Felipe Balbi <balbi@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Rob Herring <robh+dt@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Linux USB List <linux-usb@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Amit Pundir <amit.pundir@linaro.org> Subject: Re: [PATCH 29/29] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name Date: Wed, 14 Jul 2021 15:48:07 +0300 [thread overview] Message-ID: <20210714124807.o22mottsrg3tv6nt@mobilestation> (raw) In-Reply-To: <CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com> Hello John, On Tue, Jul 13, 2021 at 05:07:00PM -0700, John Stultz wrote: > On Tue, Oct 20, 2020 at 5:10 AM Serge Semin > <Sergey.Semin@baikalelectronics.ru> wrote: > > > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > I know folks like to ignore this, but this patch breaks AOSP on db845c. :( Sorry to hear that. Alas there is no much can be done about it. DT-nodes name is a subject of DT-schema convention and as we've finally unified USB-controller nodes it shouldn't be reverted back. You can find the final USB-controller bindings in: Documentation/devicetree/bindings/usb/usb.yaml It strictly defines to have USB-nodes with names like "usb(@.*)". Reverting this patch will cause the DT-bindings check procedure failure. You can also find the naming convention defined in the latest DT spec: https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 See also device-tree bindings requirements listed in the file: Documentation/devicetree/bindings/writing-bindings.rst It says: "DO use node names matching the class of the device. Many standard names are defined in the DT Spec. If there isn't one, consider adding it." > > In the exact same way an earlier patch broke HiKey960: > https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ > > (which I still have to carry a revert for). > > I get that this change is useful so more dynamic userland can find > devices using consistent naming with future kernels (but doesn't the > dynamic userland have to handle the case for older kernels as well?) > But for userland that uses static configs, its painful as updating > userland to use the new node ids then causes older kernels to fail. > > I'm looking into how we might be able to probe and set the property > dynamically, but AOSP's init system is far more aligned to static > configs. > As Krzysztof said in https://lore.kernel.org/lkml/20201221210423.GA2504@kozik-lap/ and Bjorn noted in his response to your email, the only way to solve the problem is to fix the user-land app so one would be able to deal with both old and new DT-nodes name. Alternatively you can just replace the dts with older one, where the name still have the "dwc3"-prefix. -Sergey > This will probably be ignored again, but it would be nice if we could > have a release where DTS changes don't break userland for one of my > boards. As it feels like its been awhile. > > thanks > -john _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-14 12:55 UTC|newest] Thread overview: 234+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-20 11:59 [PATCH 00/29] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 11:59 ` [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:15 ` Andy Shevchenko 2020-10-20 12:15 ` [PATCH 01/29] usb: dwc3: Discard synopsys, dwc3 " Andy Shevchenko 2020-10-20 12:28 ` [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 " Krzysztof Kozlowski 2020-10-20 12:28 ` Krzysztof Kozlowski 2020-10-20 12:33 ` Serge Semin 2020-10-20 12:33 ` Serge Semin 2020-10-20 12:27 ` Felipe Balbi 2020-10-20 12:27 ` Felipe Balbi 2020-10-20 11:59 ` [PATCH 02/29] arm: dts: keystone: Correct DWC USB3 compatible string Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:30 ` Krzysztof Kozlowski 2020-10-20 12:30 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 03/29] arm: dts: am437x: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:31 ` Krzysztof Kozlowski 2020-10-20 12:31 ` Krzysztof Kozlowski 2020-11-10 13:17 ` Tony Lindgren 2020-11-10 13:17 ` Tony Lindgren 2020-10-20 11:59 ` [PATCH 04/29] arm: dts: exynos: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-26 18:55 ` Krzysztof Kozlowski 2020-10-26 18:55 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:34 ` Krzysztof Kozlowski 2020-10-20 12:34 ` Krzysztof Kozlowski 2020-10-20 12:34 ` Krzysztof Kozlowski 2020-10-20 12:44 ` Serge Semin 2020-10-20 12:44 ` Serge Semin 2020-10-20 12:44 ` Serge Semin 2020-10-20 12:46 ` Krzysztof Kozlowski 2020-10-20 12:46 ` Krzysztof Kozlowski 2020-10-20 12:46 ` Krzysztof Kozlowski 2020-10-20 13:06 ` Neil Armstrong 2020-10-20 13:06 ` Neil Armstrong 2020-10-20 13:06 ` Neil Armstrong 2020-10-20 19:38 ` Martin Blumenstingl 2020-10-20 19:38 ` Martin Blumenstingl 2020-10-20 19:38 ` Martin Blumenstingl 2020-10-20 11:59 ` [PATCH 06/29] arc: dts: Harmonize EHCI/OHCI DT nodes name Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:35 ` Krzysztof Kozlowski 2020-10-20 12:35 ` Krzysztof Kozlowski 2020-10-20 12:35 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 07/29] arm: dts: bcm53x: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:34 ` Krzysztof Kozlowski 2020-10-20 12:34 ` Krzysztof Kozlowski 2020-10-22 20:43 ` Florian Fainelli 2020-10-22 20:43 ` Florian Fainelli 2020-10-20 11:59 ` [PATCH 08/29] arm: dts: stm32: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:36 ` Krzysztof Kozlowski 2020-10-20 12:36 ` Krzysztof Kozlowski 2020-11-09 10:43 ` Alexandre Torgue 2020-11-09 10:43 ` Alexandre Torgue 2020-10-20 11:59 ` [PATCH 09/29] arm: dts: hisi-x5hd2: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:36 ` Krzysztof Kozlowski 2020-10-20 12:36 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 10/29] arm: dts: lpc18xx: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:37 ` Krzysztof Kozlowski 2020-10-20 12:37 ` Krzysztof Kozlowski 2020-10-21 19:02 ` Vladimir Zapolskiy 2020-10-21 19:02 ` Vladimir Zapolskiy 2020-10-20 11:59 ` [PATCH 11/29] arm64: dts: hisi: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:37 ` Krzysztof Kozlowski 2020-10-20 12:37 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 12/29] mips: dts: jz47x: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:40 ` Krzysztof Kozlowski 2020-10-20 12:40 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 13/29] mips: dts: sead3: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:37 ` Krzysztof Kozlowski 2020-10-20 12:37 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 14/29] mips: dts: ralink: mt7628a: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:38 ` Krzysztof Kozlowski 2020-10-20 12:38 ` Krzysztof Kozlowski 2020-10-20 12:38 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 15/29] powerpc: dts: akebono: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:38 ` Krzysztof Kozlowski 2020-10-20 12:38 ` Krzysztof Kozlowski 2020-10-20 12:38 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 16/29] arm: dts: bcm5301x: Harmonize xHCI " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:38 ` Krzysztof Kozlowski 2020-10-20 12:38 ` Krzysztof Kozlowski 2020-10-22 20:44 ` Florian Fainelli 2020-10-22 20:44 ` Florian Fainelli 2020-10-20 11:59 ` [PATCH 17/29] arm64: dts: marvell: cp11x: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:40 ` Krzysztof Kozlowski 2020-10-20 12:40 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 18/29] arm: dts: marvell: armada-375: Harmonize DWC USB3 " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:43 ` Krzysztof Kozlowski 2020-10-20 12:43 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 19/29] arm: dts: exynos: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-26 18:56 ` Krzysztof Kozlowski 2020-10-26 18:56 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 20/29] arm: dts: keystone: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:41 ` Krzysztof Kozlowski 2020-10-20 12:41 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 21/29] arm: dts: ls1021a: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:46 ` Krzysztof Kozlowski 2020-10-20 12:46 ` Krzysztof Kozlowski 2020-11-01 7:37 ` Shawn Guo 2020-11-01 7:37 ` Shawn Guo 2020-10-20 11:59 ` [PATCH 22/29] arm: dts: omap5: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:41 ` Krzysztof Kozlowski 2020-10-20 12:41 ` Krzysztof Kozlowski 2020-11-10 13:18 ` Tony Lindgren 2020-11-10 13:18 ` Tony Lindgren 2020-10-20 11:59 ` [PATCH 23/29] arm: dts: stih407-family: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:41 ` Krzysztof Kozlowski 2020-10-20 12:41 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 24/29] arm64: dts: allwinner: h6: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:42 ` Krzysztof Kozlowski 2020-10-20 12:42 ` Krzysztof Kozlowski 2020-10-22 16:13 ` Maxime Ripard 2020-10-22 16:13 ` Maxime Ripard 2020-10-20 11:59 ` [PATCH 25/29] arm64: dts: apm: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:42 ` Krzysztof Kozlowski 2020-10-20 12:42 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 26/29] arm64: dts: exynos: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:43 ` Krzysztof Kozlowski 2020-10-20 12:43 ` Krzysztof Kozlowski 2020-10-22 11:25 ` Serge Semin 2020-10-22 11:25 ` Serge Semin 2020-10-26 18:57 ` Krzysztof Kozlowski 2020-10-26 18:57 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 27/29] arm64: dts: layerscape: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:47 ` Krzysztof Kozlowski 2020-10-20 12:47 ` Krzysztof Kozlowski 2020-11-01 7:37 ` Shawn Guo 2020-11-01 7:37 ` Shawn Guo 2020-10-20 11:59 ` [PATCH 28/29] arm64: dts: hi3660: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:44 ` Krzysztof Kozlowski 2020-10-20 12:44 ` Krzysztof Kozlowski 2020-10-20 11:59 ` [PATCH 29/29] arm64: dts: qcom: " Serge Semin 2020-10-20 11:59 ` Serge Semin 2020-10-20 12:44 ` Krzysztof Kozlowski 2020-10-20 12:44 ` Krzysztof Kozlowski 2020-11-02 7:34 ` Jun Li 2020-11-02 7:34 ` Jun Li 2020-11-03 23:23 ` Bjorn Andersson 2020-11-03 23:23 ` Bjorn Andersson 2020-11-10 12:12 ` Serge Semin 2020-11-10 12:12 ` Serge Semin 2021-07-14 0:07 ` John Stultz 2021-07-14 0:07 ` John Stultz 2021-07-14 2:27 ` Bjorn Andersson 2021-07-14 2:27 ` Bjorn Andersson 2021-07-21 7:39 ` Greg Kroah-Hartman 2021-07-21 7:39 ` Greg Kroah-Hartman 2021-07-14 12:48 ` Serge Semin [this message] 2021-07-14 12:48 ` Serge Semin 2021-07-14 14:59 ` Bjorn Andersson 2021-07-14 14:59 ` Bjorn Andersson 2021-07-21 7:38 ` Greg Kroah-Hartman 2021-07-21 7:38 ` Greg Kroah-Hartman 2021-07-21 10:02 ` Serge Semin 2021-07-21 10:02 ` Serge Semin 2021-07-21 10:29 ` Greg Kroah-Hartman 2021-07-21 10:29 ` Greg Kroah-Hartman 2021-07-21 10:45 ` Krzysztof Kozlowski 2021-07-21 10:45 ` Krzysztof Kozlowski 2021-07-21 11:02 ` Greg Kroah-Hartman 2021-07-21 11:02 ` Greg Kroah-Hartman 2021-07-21 11:10 ` Krzysztof Kozlowski 2021-07-21 11:10 ` Krzysztof Kozlowski 2021-07-21 11:25 ` Serge Semin 2021-07-21 11:25 ` Serge Semin 2021-07-21 18:08 ` John Stultz 2021-07-21 18:08 ` John Stultz 2021-07-22 18:12 ` Serge Semin 2021-07-22 18:12 ` Serge Semin 2021-07-22 19:17 ` Bjorn Andersson 2021-07-22 19:17 ` Bjorn Andersson 2021-07-22 20:09 ` John Stultz 2021-07-22 20:09 ` John Stultz 2021-07-22 22:09 ` Serge Semin 2021-07-22 22:09 ` Serge Semin 2021-08-14 1:06 ` John Stultz 2021-08-14 1:06 ` John Stultz 2021-08-15 19:46 ` Serge Semin 2021-08-15 19:46 ` Serge Semin 2021-08-18 3:44 ` Bjorn Andersson 2021-08-18 3:44 ` Bjorn Andersson 2021-08-19 11:03 ` Serge Semin 2021-08-19 11:03 ` Serge Semin 2021-07-22 21:54 ` Serge Semin 2021-07-22 21:54 ` Serge Semin 2021-07-23 8:17 ` Greg Kroah-Hartman 2021-07-23 8:17 ` Greg Kroah-Hartman 2021-07-21 20:09 ` Bjorn Andersson 2021-07-21 20:09 ` Bjorn Andersson 2021-07-23 8:18 ` Greg Kroah-Hartman 2021-07-23 8:18 ` Greg Kroah-Hartman 2021-07-23 14:34 ` Bjorn Andersson 2021-07-23 14:34 ` Bjorn Andersson 2021-07-23 15:54 ` Greg Kroah-Hartman 2021-07-23 15:54 ` Greg Kroah-Hartman 2021-07-23 19:54 ` Bjorn Andersson 2021-07-23 19:54 ` Bjorn Andersson 2021-07-24 7:50 ` Greg Kroah-Hartman 2021-07-24 7:50 ` Greg Kroah-Hartman 2021-07-21 7:37 ` Greg Kroah-Hartman 2021-07-21 7:37 ` Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210714124807.o22mottsrg3tv6nt@mobilestation \ --to=sergey.semin@baikalelectronics.ru \ --cc=agross@kernel.org \ --cc=amit.pundir@linaro.org \ --cc=balbi@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=fancer.lancer@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=john.stultz@linaro.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.