All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	Serge Semin <fancer.lancer@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string
Date: Tue, 20 Oct 2020 15:27:25 +0300	[thread overview]
Message-ID: <877drlf5g2.fsf@kernel.org> (raw)
In-Reply-To: <20201020115959.2658-2-Sergey.Semin@baikalelectronics.ru>

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]


Hi,

Serge Semin <Sergey.Semin@baikalelectronics.ru> writes:
> Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix.
> Discard a DW USB3 compatible string with the deprecated prefix seeing
> one isn't used by any dts file anymore.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/usb/dwc3/core.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 2eb34c8b4065..28440250e798 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1878,9 +1878,6 @@ static const struct of_device_id of_dwc3_match[] = {
>  	{
>  		.compatible = "snps,dwc3"
>  	},
> -	{
> -		.compatible = "synopsys,dwc3"
> -	},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, of_dwc3_match);

sorry, no. You can't guarantee that there isn't a FW in ROM somewhere
using the old string.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Serge Semin <fancer.lancer@gmail.com>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string
Date: Tue, 20 Oct 2020 15:27:25 +0300	[thread overview]
Message-ID: <877drlf5g2.fsf@kernel.org> (raw)
In-Reply-To: <20201020115959.2658-2-Sergey.Semin@baikalelectronics.ru>


[-- Attachment #1.1: Type: text/plain, Size: 929 bytes --]


Hi,

Serge Semin <Sergey.Semin@baikalelectronics.ru> writes:
> Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix.
> Discard a DW USB3 compatible string with the deprecated prefix seeing
> one isn't used by any dts file anymore.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/usb/dwc3/core.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 2eb34c8b4065..28440250e798 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1878,9 +1878,6 @@ static const struct of_device_id of_dwc3_match[] = {
>  	{
>  		.compatible = "snps,dwc3"
>  	},
> -	{
> -		.compatible = "synopsys,dwc3"
> -	},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, of_dwc3_match);

sorry, no. You can't guarantee that there isn't a FW in ROM somewhere
using the old string.

-- 
balbi

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-10-20 12:27 UTC|newest]

Thread overview: 234+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 11:59 [PATCH 00/29] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
2020-10-20 11:59 ` Serge Semin
2020-10-20 11:59 ` Serge Semin
2020-10-20 11:59 ` Serge Semin
2020-10-20 11:59 ` [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:15   ` Andy Shevchenko
2020-10-20 12:15     ` [PATCH 01/29] usb: dwc3: Discard synopsys, dwc3 " Andy Shevchenko
2020-10-20 12:28     ` [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 " Krzysztof Kozlowski
2020-10-20 12:28       ` Krzysztof Kozlowski
2020-10-20 12:33       ` Serge Semin
2020-10-20 12:33         ` Serge Semin
2020-10-20 12:27   ` Felipe Balbi [this message]
2020-10-20 12:27     ` Felipe Balbi
2020-10-20 11:59 ` [PATCH 02/29] arm: dts: keystone: Correct DWC USB3 compatible string Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:30   ` Krzysztof Kozlowski
2020-10-20 12:30     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 03/29] arm: dts: am437x: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:31   ` Krzysztof Kozlowski
2020-10-20 12:31     ` Krzysztof Kozlowski
2020-11-10 13:17     ` Tony Lindgren
2020-11-10 13:17       ` Tony Lindgren
2020-10-20 11:59 ` [PATCH 04/29] arm: dts: exynos: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-26 18:55   ` Krzysztof Kozlowski
2020-10-26 18:55     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:34   ` Krzysztof Kozlowski
2020-10-20 12:34     ` Krzysztof Kozlowski
2020-10-20 12:34     ` Krzysztof Kozlowski
2020-10-20 12:44     ` Serge Semin
2020-10-20 12:44       ` Serge Semin
2020-10-20 12:44       ` Serge Semin
2020-10-20 12:46       ` Krzysztof Kozlowski
2020-10-20 12:46         ` Krzysztof Kozlowski
2020-10-20 12:46         ` Krzysztof Kozlowski
2020-10-20 13:06   ` Neil Armstrong
2020-10-20 13:06     ` Neil Armstrong
2020-10-20 13:06     ` Neil Armstrong
2020-10-20 19:38   ` Martin Blumenstingl
2020-10-20 19:38     ` Martin Blumenstingl
2020-10-20 19:38     ` Martin Blumenstingl
2020-10-20 11:59 ` [PATCH 06/29] arc: dts: Harmonize EHCI/OHCI DT nodes name Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:35   ` Krzysztof Kozlowski
2020-10-20 12:35     ` Krzysztof Kozlowski
2020-10-20 12:35     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 07/29] arm: dts: bcm53x: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:34   ` Krzysztof Kozlowski
2020-10-20 12:34     ` Krzysztof Kozlowski
2020-10-22 20:43   ` Florian Fainelli
2020-10-22 20:43     ` Florian Fainelli
2020-10-20 11:59 ` [PATCH 08/29] arm: dts: stm32: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:36   ` Krzysztof Kozlowski
2020-10-20 12:36     ` Krzysztof Kozlowski
2020-11-09 10:43     ` Alexandre Torgue
2020-11-09 10:43       ` Alexandre Torgue
2020-10-20 11:59 ` [PATCH 09/29] arm: dts: hisi-x5hd2: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:36   ` Krzysztof Kozlowski
2020-10-20 12:36     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 10/29] arm: dts: lpc18xx: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:37   ` Krzysztof Kozlowski
2020-10-20 12:37     ` Krzysztof Kozlowski
2020-10-21 19:02   ` Vladimir Zapolskiy
2020-10-21 19:02     ` Vladimir Zapolskiy
2020-10-20 11:59 ` [PATCH 11/29] arm64: dts: hisi: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:37   ` Krzysztof Kozlowski
2020-10-20 12:37     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 12/29] mips: dts: jz47x: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:40   ` Krzysztof Kozlowski
2020-10-20 12:40     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 13/29] mips: dts: sead3: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:37   ` Krzysztof Kozlowski
2020-10-20 12:37     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 14/29] mips: dts: ralink: mt7628a: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:38   ` Krzysztof Kozlowski
2020-10-20 12:38     ` Krzysztof Kozlowski
2020-10-20 12:38     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 15/29] powerpc: dts: akebono: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:38   ` Krzysztof Kozlowski
2020-10-20 12:38     ` Krzysztof Kozlowski
2020-10-20 12:38     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 16/29] arm: dts: bcm5301x: Harmonize xHCI " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:38   ` Krzysztof Kozlowski
2020-10-20 12:38     ` Krzysztof Kozlowski
2020-10-22 20:44   ` Florian Fainelli
2020-10-22 20:44     ` Florian Fainelli
2020-10-20 11:59 ` [PATCH 17/29] arm64: dts: marvell: cp11x: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:40   ` Krzysztof Kozlowski
2020-10-20 12:40     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 18/29] arm: dts: marvell: armada-375: Harmonize DWC USB3 " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:43   ` Krzysztof Kozlowski
2020-10-20 12:43     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 19/29] arm: dts: exynos: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-26 18:56   ` Krzysztof Kozlowski
2020-10-26 18:56     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 20/29] arm: dts: keystone: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:41   ` Krzysztof Kozlowski
2020-10-20 12:41     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 21/29] arm: dts: ls1021a: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:46   ` Krzysztof Kozlowski
2020-10-20 12:46     ` Krzysztof Kozlowski
2020-11-01  7:37   ` Shawn Guo
2020-11-01  7:37     ` Shawn Guo
2020-10-20 11:59 ` [PATCH 22/29] arm: dts: omap5: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:41   ` Krzysztof Kozlowski
2020-10-20 12:41     ` Krzysztof Kozlowski
2020-11-10 13:18     ` Tony Lindgren
2020-11-10 13:18       ` Tony Lindgren
2020-10-20 11:59 ` [PATCH 23/29] arm: dts: stih407-family: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:41   ` Krzysztof Kozlowski
2020-10-20 12:41     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 24/29] arm64: dts: allwinner: h6: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:42   ` Krzysztof Kozlowski
2020-10-20 12:42     ` Krzysztof Kozlowski
2020-10-22 16:13   ` Maxime Ripard
2020-10-22 16:13     ` Maxime Ripard
2020-10-20 11:59 ` [PATCH 25/29] arm64: dts: apm: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:42   ` Krzysztof Kozlowski
2020-10-20 12:42     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 26/29] arm64: dts: exynos: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:43   ` Krzysztof Kozlowski
2020-10-20 12:43     ` Krzysztof Kozlowski
2020-10-22 11:25     ` Serge Semin
2020-10-22 11:25       ` Serge Semin
2020-10-26 18:57   ` Krzysztof Kozlowski
2020-10-26 18:57     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 27/29] arm64: dts: layerscape: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:47   ` Krzysztof Kozlowski
2020-10-20 12:47     ` Krzysztof Kozlowski
2020-11-01  7:37   ` Shawn Guo
2020-11-01  7:37     ` Shawn Guo
2020-10-20 11:59 ` [PATCH 28/29] arm64: dts: hi3660: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:44   ` Krzysztof Kozlowski
2020-10-20 12:44     ` Krzysztof Kozlowski
2020-10-20 11:59 ` [PATCH 29/29] arm64: dts: qcom: " Serge Semin
2020-10-20 11:59   ` Serge Semin
2020-10-20 12:44   ` Krzysztof Kozlowski
2020-10-20 12:44     ` Krzysztof Kozlowski
2020-11-02  7:34   ` Jun Li
2020-11-02  7:34     ` Jun Li
2020-11-03 23:23     ` Bjorn Andersson
2020-11-03 23:23       ` Bjorn Andersson
2020-11-10 12:12       ` Serge Semin
2020-11-10 12:12         ` Serge Semin
2021-07-14  0:07   ` John Stultz
2021-07-14  0:07     ` John Stultz
2021-07-14  2:27     ` Bjorn Andersson
2021-07-14  2:27       ` Bjorn Andersson
2021-07-21  7:39       ` Greg Kroah-Hartman
2021-07-21  7:39         ` Greg Kroah-Hartman
2021-07-14 12:48     ` Serge Semin
2021-07-14 12:48       ` Serge Semin
2021-07-14 14:59       ` Bjorn Andersson
2021-07-14 14:59         ` Bjorn Andersson
2021-07-21  7:38       ` Greg Kroah-Hartman
2021-07-21  7:38         ` Greg Kroah-Hartman
2021-07-21 10:02         ` Serge Semin
2021-07-21 10:02           ` Serge Semin
2021-07-21 10:29           ` Greg Kroah-Hartman
2021-07-21 10:29             ` Greg Kroah-Hartman
2021-07-21 10:45             ` Krzysztof Kozlowski
2021-07-21 10:45               ` Krzysztof Kozlowski
2021-07-21 11:02               ` Greg Kroah-Hartman
2021-07-21 11:02                 ` Greg Kroah-Hartman
2021-07-21 11:10                 ` Krzysztof Kozlowski
2021-07-21 11:10                   ` Krzysztof Kozlowski
2021-07-21 11:25                   ` Serge Semin
2021-07-21 11:25                     ` Serge Semin
2021-07-21 18:08                     ` John Stultz
2021-07-21 18:08                       ` John Stultz
2021-07-22 18:12                       ` Serge Semin
2021-07-22 18:12                         ` Serge Semin
2021-07-22 19:17                         ` Bjorn Andersson
2021-07-22 19:17                           ` Bjorn Andersson
2021-07-22 20:09                           ` John Stultz
2021-07-22 20:09                             ` John Stultz
2021-07-22 22:09                             ` Serge Semin
2021-07-22 22:09                               ` Serge Semin
2021-08-14  1:06                               ` John Stultz
2021-08-14  1:06                                 ` John Stultz
2021-08-15 19:46                                 ` Serge Semin
2021-08-15 19:46                                   ` Serge Semin
2021-08-18  3:44                                   ` Bjorn Andersson
2021-08-18  3:44                                     ` Bjorn Andersson
2021-08-19 11:03                                     ` Serge Semin
2021-08-19 11:03                                       ` Serge Semin
2021-07-22 21:54                           ` Serge Semin
2021-07-22 21:54                             ` Serge Semin
2021-07-23  8:17                             ` Greg Kroah-Hartman
2021-07-23  8:17                               ` Greg Kroah-Hartman
2021-07-21 20:09             ` Bjorn Andersson
2021-07-21 20:09               ` Bjorn Andersson
2021-07-23  8:18               ` Greg Kroah-Hartman
2021-07-23  8:18                 ` Greg Kroah-Hartman
2021-07-23 14:34                 ` Bjorn Andersson
2021-07-23 14:34                   ` Bjorn Andersson
2021-07-23 15:54                   ` Greg Kroah-Hartman
2021-07-23 15:54                     ` Greg Kroah-Hartman
2021-07-23 19:54                     ` Bjorn Andersson
2021-07-23 19:54                       ` Bjorn Andersson
2021-07-24  7:50                       ` Greg Kroah-Hartman
2021-07-24  7:50                         ` Greg Kroah-Hartman
2021-07-21  7:37     ` Greg Kroah-Hartman
2021-07-21  7:37       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877drlf5g2.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=fancer.lancer@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.