From: Rob Herring <robh@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Yunfei Dong <Yunfei.Dong@mediatek.com>,
Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Irui Wang <irui.wang@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings
Date: Wed, 14 Jul 2021 17:13:59 -0600 [thread overview]
Message-ID: <20210714231359.GA3715372@robh.at.kernel.org> (raw)
In-Reply-To: <CA+Px+wWQREny2KSjDfgdnMvk8GKKqr+QvRdSR8YXc1i73wbJSQ@mail.gmail.com>
On Thu, Jul 08, 2021 at 06:04:54PM +0800, Tzung-Bi Shih wrote:
> On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong <yunfei.dong@mediatek.com> wrote:
> > .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++
> > .../media/mediatek-vcodec-encoder.txt | 73 ++++++++
> > 2 files changed, 242 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt
> The patch is weird. Its title says "separate" but the changes are all
> creating new content.
>
> Would expect the patch to remove content from some files (e.g.
> Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and
> separate into 2 files.
Except h/w doesn't change. Using the component framework is not a reason
to change bindings.
Also, note that any major changes or additions should be in schema
format now.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Yunfei Dong <Yunfei.Dong@mediatek.com>,
Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Irui Wang <irui.wang@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings
Date: Wed, 14 Jul 2021 17:13:59 -0600 [thread overview]
Message-ID: <20210714231359.GA3715372@robh.at.kernel.org> (raw)
In-Reply-To: <CA+Px+wWQREny2KSjDfgdnMvk8GKKqr+QvRdSR8YXc1i73wbJSQ@mail.gmail.com>
On Thu, Jul 08, 2021 at 06:04:54PM +0800, Tzung-Bi Shih wrote:
> On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong <yunfei.dong@mediatek.com> wrote:
> > .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++
> > .../media/mediatek-vcodec-encoder.txt | 73 ++++++++
> > 2 files changed, 242 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt
> The patch is weird. Its title says "separate" but the changes are all
> creating new content.
>
> Would expect the patch to remove content from some files (e.g.
> Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and
> separate into 2 files.
Except h/w doesn't change. Using the component framework is not a reason
to change bindings.
Also, note that any major changes or additions should be in schema
format now.
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Yunfei Dong <Yunfei.Dong@mediatek.com>,
Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Irui Wang <irui.wang@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings
Date: Wed, 14 Jul 2021 17:13:59 -0600 [thread overview]
Message-ID: <20210714231359.GA3715372@robh.at.kernel.org> (raw)
In-Reply-To: <CA+Px+wWQREny2KSjDfgdnMvk8GKKqr+QvRdSR8YXc1i73wbJSQ@mail.gmail.com>
On Thu, Jul 08, 2021 at 06:04:54PM +0800, Tzung-Bi Shih wrote:
> On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong <yunfei.dong@mediatek.com> wrote:
> > .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++
> > .../media/mediatek-vcodec-encoder.txt | 73 ++++++++
> > 2 files changed, 242 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt
> The patch is weird. Its title says "separate" but the changes are all
> creating new content.
>
> Would expect the patch to remove content from some files (e.g.
> Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and
> separate into 2 files.
Except h/w doesn't change. Using the component framework is not a reason
to change bindings.
Also, note that any major changes or additions should be in schema
format now.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-14 23:14 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 6:21 [PATCH v1, 00/14] Using component framework to support multi hardware decode Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 01/14] media: mtk-vcodec: Get numbers of register bases from DT Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 02/14] media: mtk-vcodec: Refactor vcodec pm interface Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 03/14] media: mtk-vcodec: Use component framework to manage each hardware information Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-08 10:04 ` Tzung-Bi Shih
2021-07-08 10:04 ` Tzung-Bi Shih
2021-07-08 10:04 ` Tzung-Bi Shih
2021-07-07 6:21 ` [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-08 10:04 ` Tzung-Bi Shih
2021-07-08 10:04 ` Tzung-Bi Shih
2021-07-08 10:04 ` Tzung-Bi Shih
2021-07-14 23:13 ` Rob Herring [this message]
2021-07-14 23:13 ` Rob Herring
2021-07-14 23:13 ` Rob Herring
2021-07-07 6:21 ` [PATCH v1, 05/14] media: mtk-vcodec: Use pure single core for MT8183 Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 06/14] media: mtk-vcodec: Add irq interface for core hardware Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-09 7:59 ` Tzung-Bi Shih
2021-07-09 7:59 ` Tzung-Bi Shih
2021-07-09 7:59 ` Tzung-Bi Shih
2021-07-12 8:07 ` mtk12024
2021-07-12 8:07 ` mtk12024
2021-07-12 8:07 ` mtk12024
2021-07-07 6:21 ` [PATCH v1, 07/14] media: mtk-vcodec: Add msg queue feature for lat and core architecture Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-09 9:39 ` Tzung-Bi Shih
2021-07-09 9:39 ` Tzung-Bi Shih
2021-07-09 9:39 ` Tzung-Bi Shih
2021-07-12 7:27 ` mtk12024
2021-07-12 7:27 ` mtk12024
2021-07-12 7:27 ` mtk12024
2021-07-13 8:55 ` Tzung-Bi Shih
2021-07-13 8:55 ` Tzung-Bi Shih
2021-07-13 8:55 ` Tzung-Bi Shih
2021-07-07 6:21 ` [PATCH v1, 08/14] media: mtk-vcodec: Generalize power and clock on/off interfaces Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 09/14] media: mtk-vcodec: Add new interface to lock different hardware Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 10/14] media: mtk-vcodec: Add core thread Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 11/14] media: mtk-vcodec: Support 34bits dma address for vdec Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 12/14] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192 Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-14 23:14 ` Rob Herring
2021-07-14 23:14 ` Rob Herring
2021-07-14 23:14 ` Rob Herring
2021-07-07 6:21 ` [PATCH v1, 13/14] media: mtk-vcodec: Add core dec and dec end ipi msg Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` [PATCH v1, 14/14] media: mtk-vcodec: Use codec type to separate different hardware Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
2021-07-07 6:21 ` Yunfei Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714231359.GA3715372@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Yunfei.Dong@mediatek.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@chromium.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.