All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc: alsa-devel@alsa-project.org,
	pierre-louis.bossart@linux.intel.com, robh+dt@kernel.org,
	devicetree@vger.kernel.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com,
	kai.vehmanen@linux.intel.com, perex@perex.cz, tiwai@suse.com,
	daniel.baluta@gmail.com, Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH 1/3] ASoC: SOF: Parse fw/tplg filename from DT
Date: Thu, 15 Jul 2021 15:39:06 +0100	[thread overview]
Message-ID: <20210715143906.GD4590@sirena.org.uk> (raw)
In-Reply-To: <20210715141802.880911-2-daniel.baluta@oss.nxp.com>

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

On Thu, Jul 15, 2021 at 05:18:00PM +0300, Daniel Baluta wrote:

> Introduce two DT properties in dsp node:
> 	* fw-filename, optional property giving the firmware filename
> 	(if this is missing fw filename is read from board description)
> 	* tplg-filename, mandatory giving the topology filename.

These sound entirely like operating system configuration which I'd
expect to be inferred from the machine identification.  What happens if
a system has multiple options for firmware files, or if the OS ships the
topology and firmware bundled up in a single image to avoid them getting
out of sync?  What's the benefit of putting them in the DT?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	kai.vehmanen@linux.intel.com, lgirdwood@gmail.com,
	tiwai@suse.com, pierre-louis.bossart@linux.intel.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	daniel.baluta@gmail.com, ranjani.sridharan@linux.intel.com,
	Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH 1/3] ASoC: SOF: Parse fw/tplg filename from DT
Date: Thu, 15 Jul 2021 15:39:06 +0100	[thread overview]
Message-ID: <20210715143906.GD4590@sirena.org.uk> (raw)
In-Reply-To: <20210715141802.880911-2-daniel.baluta@oss.nxp.com>

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

On Thu, Jul 15, 2021 at 05:18:00PM +0300, Daniel Baluta wrote:

> Introduce two DT properties in dsp node:
> 	* fw-filename, optional property giving the firmware filename
> 	(if this is missing fw filename is read from board description)
> 	* tplg-filename, mandatory giving the topology filename.

These sound entirely like operating system configuration which I'd
expect to be inferred from the machine identification.  What happens if
a system has multiple options for firmware files, or if the OS ships the
topology and firmware bundled up in a single image to avoid them getting
out of sync?  What's the benefit of putting them in the DT?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-07-15 14:39 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 14:17 [PATCH 0/3] Read firmware, tplg and machine driver name from dts node Daniel Baluta
2021-07-15 14:17 ` Daniel Baluta
2021-07-15 14:18 ` [PATCH 1/3] ASoC: SOF: Parse fw/tplg filename from DT Daniel Baluta
2021-07-15 14:18   ` Daniel Baluta
2021-07-15 14:39   ` Mark Brown [this message]
2021-07-15 14:39     ` Mark Brown
2021-07-16 14:31     ` Daniel Baluta
2021-07-16 14:31       ` Daniel Baluta
2021-07-20 14:54       ` Daniel Baluta
2021-07-20 14:54         ` Daniel Baluta
2021-07-20 15:28         ` Pierre-Louis Bossart
2021-07-20 15:28           ` Pierre-Louis Bossart
2021-07-21 12:59           ` Mark Brown
2021-07-21 12:59             ` Mark Brown
2021-07-21 13:28             ` Pierre-Louis Bossart
2021-07-21 13:28               ` Pierre-Louis Bossart
2021-07-21 17:00               ` Mark Brown
2021-07-21 17:00                 ` Mark Brown
2021-07-15 18:06   ` kernel test robot
2021-07-15 14:18 ` [PATCH 2/3] ASoC: SOF: Introduce machine driver name Daniel Baluta
2021-07-15 14:18   ` Daniel Baluta
2021-07-15 14:18 ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl,properties Daniel Baluta
2021-07-15 14:18   ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties Daniel Baluta
2021-07-15 14:59   ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl,properties Rob Herring
2021-07-15 14:59     ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties Rob Herring
2021-07-16 14:25     ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl,properties Daniel Baluta
2021-07-16 14:25       ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties Daniel Baluta
2021-07-15 15:51   ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl,properties Rob Herring
2021-07-15 15:51     ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210715143906.GD4590@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel.baluta@gmail.com \
    --cc=daniel.baluta@nxp.com \
    --cc=daniel.baluta@oss.nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.