From: Rob Herring <robh+dt@kernel.org> To: Daniel Baluta <daniel.baluta@oss.nxp.com> Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, kai.vehmanen@linux.intel.com, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Daniel Baluta <daniel.baluta@gmail.com>, Daniel Baluta <daniel.baluta@nxp.com> Subject: Re: [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl,properties Date: Thu, 15 Jul 2021 08:59:21 -0600 [thread overview] Message-ID: <CAL_Jsq+r0Tw46=iW8etyR9H=V7M+sE=dguqsEMm3R4B=Xg=qSA@mail.gmail.com> (raw) In-Reply-To: <20210715141802.880911-4-daniel.baluta@oss.nxp.com> On Thu, Jul 15, 2021 at 8:18 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote: > > From: Daniel Baluta <daniel.baluta@nxp.com> > > Document firmware-name, tplg-name and machine-drv-name properties. That's obvious from the diff. Why do you need these? > > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > --- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > index 7afc9f2be13a..8095aa178e7c 100644 > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > @@ -60,6 +60,22 @@ properties: > used by DSP (see bindings/reserved-memory/reserved-memory.txt) > maxItems: 1 > > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + If present, name of the file within the firmware search path containing > + the DSP firmware loaded by SOF at DSP boot time. > + > + tplg-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Should contain the audio topology file name loaded by SOF driver. Is this some format the DSP requires? Why do we need a separate file? This is defined by the board or user config? > + > + machine-drv-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Contains the ASoC machine driver name used by SOF to handle DSP audio scenario. Umm, no. > + > required: > - compatible > - reg > @@ -69,6 +85,8 @@ required: > - mboxes > - mbox-names > - memory-region > + - tplg-name > + - machine-drv-name > > additionalProperties: false > > @@ -90,4 +108,6 @@ examples: > mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; > mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>; > memory-region = <&dsp_reserved>; > + tplg-name = "sof-imx8-wm8960.tplg"; > + machine-drv-name = "asoc-simple-card"; > }; > -- > 2.27.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org> To: Daniel Baluta <daniel.baluta@oss.nxp.com> Cc: devicetree@vger.kernel.org, Linux-ALSA <alsa-devel@alsa-project.org>, kai.vehmanen@linux.intel.com, Liam Girdwood <lgirdwood@gmail.com>, Takashi Iwai <tiwai@suse.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>, Daniel Baluta <daniel.baluta@gmail.com>, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, Daniel Baluta <daniel.baluta@nxp.com> Subject: Re: [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties Date: Thu, 15 Jul 2021 08:59:21 -0600 [thread overview] Message-ID: <CAL_Jsq+r0Tw46=iW8etyR9H=V7M+sE=dguqsEMm3R4B=Xg=qSA@mail.gmail.com> (raw) In-Reply-To: <20210715141802.880911-4-daniel.baluta@oss.nxp.com> On Thu, Jul 15, 2021 at 8:18 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote: > > From: Daniel Baluta <daniel.baluta@nxp.com> > > Document firmware-name, tplg-name and machine-drv-name properties. That's obvious from the diff. Why do you need these? > > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > --- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > index 7afc9f2be13a..8095aa178e7c 100644 > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > @@ -60,6 +60,22 @@ properties: > used by DSP (see bindings/reserved-memory/reserved-memory.txt) > maxItems: 1 > > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + If present, name of the file within the firmware search path containing > + the DSP firmware loaded by SOF at DSP boot time. > + > + tplg-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Should contain the audio topology file name loaded by SOF driver. Is this some format the DSP requires? Why do we need a separate file? This is defined by the board or user config? > + > + machine-drv-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Contains the ASoC machine driver name used by SOF to handle DSP audio scenario. Umm, no. > + > required: > - compatible > - reg > @@ -69,6 +85,8 @@ required: > - mboxes > - mbox-names > - memory-region > + - tplg-name > + - machine-drv-name > > additionalProperties: false > > @@ -90,4 +108,6 @@ examples: > mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; > mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>; > memory-region = <&dsp_reserved>; > + tplg-name = "sof-imx8-wm8960.tplg"; > + machine-drv-name = "asoc-simple-card"; > }; > -- > 2.27.0 >
next prev parent reply other threads:[~2021-07-15 14:59 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-15 14:17 [PATCH 0/3] Read firmware, tplg and machine driver name from dts node Daniel Baluta 2021-07-15 14:17 ` Daniel Baluta 2021-07-15 14:18 ` [PATCH 1/3] ASoC: SOF: Parse fw/tplg filename from DT Daniel Baluta 2021-07-15 14:18 ` Daniel Baluta 2021-07-15 14:39 ` Mark Brown 2021-07-15 14:39 ` Mark Brown 2021-07-16 14:31 ` Daniel Baluta 2021-07-16 14:31 ` Daniel Baluta 2021-07-20 14:54 ` Daniel Baluta 2021-07-20 14:54 ` Daniel Baluta 2021-07-20 15:28 ` Pierre-Louis Bossart 2021-07-20 15:28 ` Pierre-Louis Bossart 2021-07-21 12:59 ` Mark Brown 2021-07-21 12:59 ` Mark Brown 2021-07-21 13:28 ` Pierre-Louis Bossart 2021-07-21 13:28 ` Pierre-Louis Bossart 2021-07-21 17:00 ` Mark Brown 2021-07-21 17:00 ` Mark Brown 2021-07-15 18:06 ` kernel test robot 2021-07-15 14:18 ` [PATCH 2/3] ASoC: SOF: Introduce machine driver name Daniel Baluta 2021-07-15 14:18 ` Daniel Baluta 2021-07-15 14:18 ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl,properties Daniel Baluta 2021-07-15 14:18 ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties Daniel Baluta 2021-07-15 14:59 ` Rob Herring [this message] 2021-07-15 14:59 ` Rob Herring 2021-07-16 14:25 ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl,properties Daniel Baluta 2021-07-16 14:25 ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties Daniel Baluta 2021-07-15 15:51 ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl,properties Rob Herring 2021-07-15 15:51 ` [PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_Jsq+r0Tw46=iW8etyR9H=V7M+sE=dguqsEMm3R4B=Xg=qSA@mail.gmail.com' \ --to=robh+dt@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=daniel.baluta@gmail.com \ --cc=daniel.baluta@nxp.com \ --cc=daniel.baluta@oss.nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=kai.vehmanen@linux.intel.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.