Re: [PATCH 02/11] drm/msm/disp/dpu1: Add support for DSC

From: kernel test robot <lkp@intel.com>
To: Vinod Koul <vkoul@kernel.org>, Rob Clark <robdclark@gmail.com>
Cc: kbuild-all@lists.01.org, Jonathan Marek <jonathan@marek.ca>,
	Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
	David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Abhinav Kumar <abhinavk@codeaurora.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 02/11] drm/msm/disp/dpu1: Add support for DSC
Date: Mon, 19 Jul 2021 16:28:07 +0800	[thread overview]
Message-ID: <202107191617.GTgifw9l-lkp@intel.com> (raw)
In-Reply-To: <20210715065203.709914-3-vkoul@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2902 bytes --]

Hi Vinod,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v5.13]
[also build test WARNING on next-20210716]
[cannot apply to linus/master v5.14-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vinod-Koul/drm-msm-Add-Display-Stream-Compression-Support/20210715-145540
base:    62fb9874f5da54fdb243003b386128037319b219
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/032a82b57221a13f65c55870ae3f64d0e5a07390
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vinod-Koul/drm-msm-Add-Display-Stream-Compression-Support/20210715-145540
        git checkout 032a82b57221a13f65c55870ae3f64d0e5a07390
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c: In function 'dpu_hw_dsc_config_thresh':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c:128:7: warning: variable 'lp' set but not used [-Wunused-but-set-variable]
     128 |  u16 *lp;
         |       ^~

vim +/lp +128 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c

   121	
   122	static void dpu_hw_dsc_config_thresh(struct dpu_hw_dsc *hw_dsc,
   123					     struct msm_display_dsc_config *dsc)
   124	{
   125		struct drm_dsc_rc_range_parameters *rc = dsc->drm->rc_range_params;
   126		struct dpu_hw_blk_reg_map *c = &hw_dsc->hw;
   127		u32 off;
 > 128		u16 *lp;
   129		int i;
   130	
   131		lp = dsc->drm->rc_buf_thresh;
   132		off = DSC_RC_BUF_THRESH;
   133		for (i = 0; i < DSC_NUM_BUF_RANGES - 1 ; i++) {
   134			DPU_REG_WRITE(c, off, dsc->drm->rc_buf_thresh[i]);
   135			off += 4;
   136		}
   137	
   138		off = DSC_RANGE_MIN_QP;
   139		for (i = 0; i < DSC_NUM_BUF_RANGES; i++) {
   140			DPU_REG_WRITE(c, off, rc[i].range_min_qp);
   141			off += 4;
   142		}
   143	
   144		off = DSC_RANGE_MAX_QP;
   145		for (i = 0; i < 15; i++) {
   146			DPU_REG_WRITE(c, off, rc[i].range_max_qp);
   147			off += 4;
   148		}
   149	
   150		off = DSC_RANGE_BPG_OFFSET;
   151		for (i = 0; i < 15; i++) {
   152			DPU_REG_WRITE(c, off, rc[i].range_bpg_offset);
   153			off += 4;
   154		}
   155	}
   156	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54713 bytes --]