* [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
@ 2021-07-20 3:40 Xianting Tian
2021-07-20 6:25 ` Jason Wang
0 siblings, 1 reply; 6+ messages in thread
From: Xianting Tian @ 2021-07-20 3:40 UTC (permalink / raw)
To: stefanha, sgarzare, davem, kuba, jasowang
Cc: kvm, netdev, linux-kernel, Xianting Tian
Add the missed virtio_device_ready() to set vsock frontend ready.
Signed-off-by: Xianting Tian <tianxianting.txt@linux.alibaba.com>
---
net/vmw_vsock/virtio_transport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index e0c2c992a..eb4c607c4 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
vdev->priv = vsock;
rcu_assign_pointer(the_virtio_vsock, vsock);
+ virtio_device_ready(vdev);
+
mutex_unlock(&the_virtio_vsock_mutex);
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
2021-07-20 3:40 [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe() Xianting Tian
@ 2021-07-20 6:25 ` Jason Wang
0 siblings, 0 replies; 6+ messages in thread
From: Jason Wang @ 2021-07-20 6:25 UTC (permalink / raw)
To: Xianting Tian, stefanha, sgarzare, davem, kuba; +Cc: kvm, netdev, linux-kernel
在 2021/7/20 上午11:40, Xianting Tian 写道:
> Add the missed virtio_device_ready() to set vsock frontend ready.
>
> Signed-off-by: Xianting Tian <tianxianting.txt@linux.alibaba.com>
> ---
> net/vmw_vsock/virtio_transport.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index e0c2c992a..eb4c607c4 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
> vdev->priv = vsock;
> rcu_assign_pointer(the_virtio_vsock, vsock);
>
> + virtio_device_ready(vdev);
> +
> mutex_unlock(&the_virtio_vsock_mutex);
It's better to do this after the mutex.
Thanks
>
> return 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
@ 2021-07-20 3:42 Xianting Tian
2021-07-20 3:44 ` tianxianting
2021-07-20 6:28 ` Jason Wang
0 siblings, 2 replies; 6+ messages in thread
From: Xianting Tian @ 2021-07-20 3:42 UTC (permalink / raw)
To: stefanha, sgarzare, davem, kuba, jasowang
Cc: kvm, netdev, linux-kernel, Xianting Tian
From: Xianting Tian <xianting.tian@linux.alibaba.com>
Add the missed virtio_device_ready() to set vsock frontend ready.
Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
net/vmw_vsock/virtio_transport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index e0c2c992a..eb4c607c4 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
vdev->priv = vsock;
rcu_assign_pointer(the_virtio_vsock, vsock);
+ virtio_device_ready(vdev);
+
mutex_unlock(&the_virtio_vsock_mutex);
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
2021-07-20 3:42 Xianting Tian
@ 2021-07-20 3:44 ` tianxianting
2021-07-20 6:28 ` Jason Wang
1 sibling, 0 replies; 6+ messages in thread
From: tianxianting @ 2021-07-20 3:44 UTC (permalink / raw)
To: Xianting Tian, stefanha, sgarzare, davem, kuba, jasowang
Cc: kvm, netdev, linux-kernel
Please help review this one, thanks
ignore the one https://lkml.org/lkml/2021/7/19/3279
<https://lkml.org/lkml/2021/7/19/3279>, which contains wrong mail address.
在 2021/7/20 上午11:42, Xianting Tian 写道:
> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>
> Add the missed virtio_device_ready() to set vsock frontend ready.
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> ---
> net/vmw_vsock/virtio_transport.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index e0c2c992a..eb4c607c4 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
> vdev->priv = vsock;
> rcu_assign_pointer(the_virtio_vsock, vsock);
>
> + virtio_device_ready(vdev);
> +
> mutex_unlock(&the_virtio_vsock_mutex);
>
> return 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
2021-07-20 3:42 Xianting Tian
2021-07-20 3:44 ` tianxianting
@ 2021-07-20 6:28 ` Jason Wang
2021-07-20 7:05 ` tianxianting
1 sibling, 1 reply; 6+ messages in thread
From: Jason Wang @ 2021-07-20 6:28 UTC (permalink / raw)
To: Xianting Tian, stefanha, sgarzare, davem, kuba
Cc: kvm, netdev, linux-kernel, Xianting Tian
在 2021/7/20 上午11:42, Xianting Tian 写道:
> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>
> Add the missed virtio_device_ready() to set vsock frontend ready.
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> ---
> net/vmw_vsock/virtio_transport.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index e0c2c992a..eb4c607c4 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
> vdev->priv = vsock;
> rcu_assign_pointer(the_virtio_vsock, vsock);
>
> + virtio_device_ready(vdev);
> +
> mutex_unlock(&the_virtio_vsock_mutex);
It's better to do this after the mutex_lock().
Thanks
>
> return 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
2021-07-20 6:28 ` Jason Wang
@ 2021-07-20 7:05 ` tianxianting
0 siblings, 0 replies; 6+ messages in thread
From: tianxianting @ 2021-07-20 7:05 UTC (permalink / raw)
To: Jason Wang, Xianting Tian, stefanha, sgarzare, davem, kuba
Cc: kvm, netdev, linux-kernel
thanks ,
I will sent V2 patch.
在 2021/7/20 下午2:28, Jason Wang 写道:
>
> 在 2021/7/20 上午11:42, Xianting Tian 写道:
>> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>>
>> Add the missed virtio_device_ready() to set vsock frontend ready.
>>
>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>> ---
>> net/vmw_vsock/virtio_transport.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/net/vmw_vsock/virtio_transport.c
>> b/net/vmw_vsock/virtio_transport.c
>> index e0c2c992a..eb4c607c4 100644
>> --- a/net/vmw_vsock/virtio_transport.c
>> +++ b/net/vmw_vsock/virtio_transport.c
>> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct
>> virtio_device *vdev)
>> vdev->priv = vsock;
>> rcu_assign_pointer(the_virtio_vsock, vsock);
>> + virtio_device_ready(vdev);
>> +
>> mutex_unlock(&the_virtio_vsock_mutex);
>
>
> It's better to do this after the mutex_lock().
>
> Thanks
>
>
>> return 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-20 7:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 3:40 [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe() Xianting Tian
2021-07-20 6:25 ` Jason Wang
2021-07-20 3:42 Xianting Tian
2021-07-20 3:44 ` tianxianting
2021-07-20 6:28 ` Jason Wang
2021-07-20 7:05 ` tianxianting
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.