[Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs

[Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs

[Giulio Benetti]

At the moment if package is not available due to binutils bugs comment
only states that it's not available because toolchain is missing C++,
wchar. But this is not correct, so let's add other 2 comments for the 2
binutils bugs and move dependencies to them.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libgeos/Config.in | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
index 86a1cddcf3..949a5ff94a 100644
--- a/package/libgeos/Config.in
+++ b/package/libgeos/Config.in
@@ -13,7 +13,11 @@ config BR2_PACKAGE_LIBGEOS
 
 	  https://trac.osgeo.org/geos
 
-comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
-		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
+comment "libgeos needs a toolchain w/ C++, wchar"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
+
+comment "libgeos needs a toolchain not affected by BINUTILS bug 21464"
+	depends on BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
+
+comment "libgeos needs a toolchain not affected by BINUTILS bug 27597"
+	depends on BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs

[Thomas Petazzoni]

Hello Giulio,

On Sat, 24 Jul 2021 22:55:37 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> At the moment if package is not available due to binutils bugs comment
> only states that it's not available because toolchain is missing C++,
> wchar.

I don't understand why you're saying that, the existing comment says:

> -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"

And it is probably printed if at least one of the following conditions is met:

 * Toolchain doesn't have C++

 * Toolchain doesn't have wchar

 * Toolchain has bug 21464

 * Toolchain has bug 27597

So, I don't understand the purpose of your patch, I'm sorry :/

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs

[Giulio Benetti]

Hello Thomas,

> Il giorno 25 lug 2021, alle ore 14:52, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> 
> Hello Giulio,
> 
>> On Sat, 24 Jul 2021 22:55:37 +0200
>> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>> 
>> At the moment if package is not available due to binutils bugs comment
>> only states that it's not available because toolchain is missing C++,
>> wchar.
> 
> I don't understand why you're saying that, the existing comment says:
> 
>> -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
> 
> And it is probably printed if at least one of the following conditions is met:
> 
> * Toolchain doesn't have C++
> 
> * Toolchain doesn't have wchar
> 
> * Toolchain has bug 21464
> 
> * Toolchain has bug 27597
> 
> So, I don't understand the purpose of your patch, I'm sorry :/

My bad, it was fixed previously. Please drop this patch.

Sorry for the noise

Best regards
Giulio Benetti

> 
> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot