* [Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs
@ 2021-07-24 20:55 Giulio Benetti
2021-07-25 12:51 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Giulio Benetti @ 2021-07-24 20:55 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti
At the moment if package is not available due to binutils bugs comment
only states that it's not available because toolchain is missing C++,
wchar. But this is not correct, so let's add other 2 comments for the 2
binutils bugs and move dependencies to them.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/libgeos/Config.in | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
index 86a1cddcf3..949a5ff94a 100644
--- a/package/libgeos/Config.in
+++ b/package/libgeos/Config.in
@@ -13,7 +13,11 @@ config BR2_PACKAGE_LIBGEOS
https://trac.osgeo.org/geos
-comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
- depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
- BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464 || \
- BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
+comment "libgeos needs a toolchain w/ C++, wchar"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
+
+comment "libgeos needs a toolchain not affected by BINUTILS bug 21464"
+ depends on BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
+
+comment "libgeos needs a toolchain not affected by BINUTILS bug 27597"
+ depends on BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs
2021-07-24 20:55 [Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs Giulio Benetti
@ 2021-07-25 12:51 ` Thomas Petazzoni
2021-07-25 12:58 ` Giulio Benetti
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2021-07-25 12:51 UTC (permalink / raw)
To: Giulio Benetti; +Cc: buildroot
Hello Giulio,
On Sat, 24 Jul 2021 22:55:37 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> At the moment if package is not available due to binutils bugs comment
> only states that it's not available because toolchain is missing C++,
> wchar.
I don't understand why you're saying that, the existing comment says:
> -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
And it is probably printed if at least one of the following conditions is met:
* Toolchain doesn't have C++
* Toolchain doesn't have wchar
* Toolchain has bug 21464
* Toolchain has bug 27597
So, I don't understand the purpose of your patch, I'm sorry :/
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs
2021-07-25 12:51 ` Thomas Petazzoni
@ 2021-07-25 12:58 ` Giulio Benetti
0 siblings, 0 replies; 3+ messages in thread
From: Giulio Benetti @ 2021-07-25 12:58 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
Hello Thomas,
> Il giorno 25 lug 2021, alle ore 14:52, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
>
> Hello Giulio,
>
>> On Sat, 24 Jul 2021 22:55:37 +0200
>> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>>
>> At the moment if package is not available due to binutils bugs comment
>> only states that it's not available because toolchain is missing C++,
>> wchar.
>
> I don't understand why you're saying that, the existing comment says:
>
>> -comment "libgeos needs a toolchain w/ C++, wchar, not binutils bug 21464, 27597"
>
> And it is probably printed if at least one of the following conditions is met:
>
> * Toolchain doesn't have C++
>
> * Toolchain doesn't have wchar
>
> * Toolchain has bug 21464
>
> * Toolchain has bug 27597
>
> So, I don't understand the purpose of your patch, I'm sorry :/
My bad, it was fixed previously. Please drop this patch.
Sorry for the noise
Best regards
Giulio Benetti
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-25 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-24 20:55 [Buildroot] [PATCH] package/libgeos: improve Config.in comments with binutils bugs Giulio Benetti
2021-07-25 12:51 ` Thomas Petazzoni
2021-07-25 12:58 ` Giulio Benetti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.