From: Christoph Hellwig <hch@lst.de> To: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com> Cc: Christoph Hellwig <hch@lst.de>, Andreas Gruenbacher <agruenba@redhat.com>, Gao Xiang <hsiangkao@linux.alibaba.com>, "Darrick J . Wong" <djwong@kernel.org>, Matthew Wilcox <willy@infradead.org>, Huang Jianan <huangjianan@oppo.com>, linux-erofs@lists.ozlabs.org, Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v7] iomap: make inline data support more flexible Date: Mon, 26 Jul 2021 15:27:49 +0200 [thread overview] Message-ID: <20210726132749.GA6535@lst.de> (raw) In-Reply-To: <CAHpGcMJhuSApy4eg9jKe2pYq4d7bY-Lg-Bmo9tOANghQ2Hxo-A@mail.gmail.com> On Mon, Jul 26, 2021 at 02:27:12PM +0200, Andreas Grünbacher wrote: > > That is how can size be different from iomap->length? > > Quoting from my previous reply, > > "In the iomap_readpage case (iomap_begin with flags == 0), > iomap->length will be the amount of data up to the end of the inode. > In the iomap_file_buffered_write case (iomap_begin with flags == > IOMAP_WRITE), iomap->length will be the size of iomap->inline_data. > (For extending writes, we need to write beyond the current end of > inode.) So iomap->length isn't all that useful for > iomap_read_inline_data." I think we should fix that now that we have the srcmap concept. That is or IOMAP_WRITE|IOMAP_ZERO return the inline map as the soure map, and return the actual block map we plan to write into as the main iomap. > > > Shouldn't the offset_in_page also go into iomap_inline_data_size_valid, > > which should probably be called iomap_inline_data_valid then? > > Hmm, not sure what you mean: iomap_inline_data_size_valid does take > offset_in_page(iomap->inline_data) into account. Indeed, orry for the braino. > I thought people were okay with 80 character long lines? No.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com> Cc: Andreas Gruenbacher <agruenba@redhat.com>, "Darrick J . Wong" <djwong@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Matthew Wilcox <willy@infradead.org>, Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>, linux-erofs@lists.ozlabs.org, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH v7] iomap: make inline data support more flexible Date: Mon, 26 Jul 2021 15:27:49 +0200 [thread overview] Message-ID: <20210726132749.GA6535@lst.de> (raw) In-Reply-To: <CAHpGcMJhuSApy4eg9jKe2pYq4d7bY-Lg-Bmo9tOANghQ2Hxo-A@mail.gmail.com> On Mon, Jul 26, 2021 at 02:27:12PM +0200, Andreas Grünbacher wrote: > > That is how can size be different from iomap->length? > > Quoting from my previous reply, > > "In the iomap_readpage case (iomap_begin with flags == 0), > iomap->length will be the amount of data up to the end of the inode. > In the iomap_file_buffered_write case (iomap_begin with flags == > IOMAP_WRITE), iomap->length will be the size of iomap->inline_data. > (For extending writes, we need to write beyond the current end of > inode.) So iomap->length isn't all that useful for > iomap_read_inline_data." I think we should fix that now that we have the srcmap concept. That is or IOMAP_WRITE|IOMAP_ZERO return the inline map as the soure map, and return the actual block map we plan to write into as the main iomap. > > > Shouldn't the offset_in_page also go into iomap_inline_data_size_valid, > > which should probably be called iomap_inline_data_valid then? > > Hmm, not sure what you mean: iomap_inline_data_size_valid does take > offset_in_page(iomap->inline_data) into account. Indeed, orry for the braino. > I thought people were okay with 80 character long lines? No.
next prev parent reply other threads:[~2021-07-26 13:27 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-23 17:41 [PATCH v7] iomap: make inline data support more flexible Gao Xiang 2021-07-23 17:41 ` Gao Xiang 2021-07-23 19:40 ` Matthew Wilcox 2021-07-23 19:40 ` Matthew Wilcox 2021-07-24 0:54 ` Gao Xiang 2021-07-24 0:54 ` Gao Xiang 2021-07-25 21:39 ` Andreas Grünbacher 2021-07-25 21:39 ` Andreas Grünbacher 2021-07-25 22:16 ` Andreas Gruenbacher 2021-07-25 22:16 ` Andreas Gruenbacher 2021-07-26 2:36 ` Gao Xiang 2021-07-26 2:36 ` Gao Xiang 2021-07-26 7:22 ` Andreas Gruenbacher 2021-07-26 7:22 ` Andreas Gruenbacher 2021-07-26 7:38 ` Gao Xiang 2021-07-26 7:38 ` Gao Xiang 2021-07-26 21:36 ` Darrick J. Wong 2021-07-26 21:36 ` Darrick J. Wong 2021-07-26 22:20 ` Andreas Grünbacher 2021-07-26 22:20 ` Andreas Grünbacher 2021-07-26 3:06 ` Matthew Wilcox 2021-07-26 3:06 ` Matthew Wilcox 2021-07-26 6:56 ` Andreas Gruenbacher 2021-07-26 6:56 ` Andreas Gruenbacher 2021-07-26 4:00 ` Gao Xiang 2021-07-26 4:00 ` Gao Xiang 2021-07-26 8:08 ` Andreas Grünbacher 2021-07-26 8:08 ` Andreas Grünbacher 2021-07-26 8:17 ` Gao Xiang 2021-07-26 8:17 ` Gao Xiang 2021-07-26 11:06 ` Andreas Gruenbacher 2021-07-26 11:06 ` Andreas Gruenbacher 2021-07-26 12:17 ` Christoph Hellwig 2021-07-26 12:17 ` Christoph Hellwig 2021-07-26 12:27 ` Andreas Grünbacher 2021-07-26 12:27 ` Andreas Grünbacher 2021-07-26 12:50 ` Gao Xiang 2021-07-26 12:50 ` Gao Xiang 2021-07-26 13:10 ` Andreas Gruenbacher 2021-07-26 13:27 ` Christoph Hellwig [this message] 2021-07-26 13:27 ` Christoph Hellwig 2021-07-27 8:20 ` David Sterba 2021-07-27 8:20 ` David Sterba 2021-07-27 13:35 ` Matthew Wilcox 2021-07-27 15:04 ` Gao Xiang 2021-07-27 15:04 ` Gao Xiang 2021-07-27 16:53 ` David Sterba 2021-07-27 16:53 ` David Sterba 2021-07-26 12:32 ` Matthew Wilcox 2021-07-26 12:32 ` Matthew Wilcox 2021-07-26 13:03 ` Andreas Gruenbacher 2021-07-26 13:03 ` Andreas Gruenbacher 2021-07-26 13:12 ` Gao Xiang 2021-07-26 13:12 ` Gao Xiang 2021-07-26 13:30 ` Christoph Hellwig 2021-07-26 8:08 ` Joseph Qi 2021-07-26 8:08 ` Joseph Qi 2021-08-01 10:29 Andreas Gruenbacher 2021-08-01 10:29 ` Andreas Gruenbacher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210726132749.GA6535@lst.de \ --to=hch@lst.de \ --cc=agruenba@redhat.com \ --cc=andreas.gruenbacher@gmail.com \ --cc=djwong@kernel.org \ --cc=hsiangkao@linux.alibaba.com \ --cc=huangjianan@oppo.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.