All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
To: buildroot@buildroot.org
Cc: Norbert Lange <nolange79@gmail.com>
Subject: [Buildroot] [PATCH for-next] package/gtest: remove partial host package
Date: Mon,  2 Aug 2021 14:33:00 +0200	[thread overview]
Message-ID: <20210802123300.564709-1-arnout@mind.be> (raw)

gmock (which is part of the gtest package) has a host variant that is
not actually the full host package, but instead just installs a single
python script.

This script, however, is no longer maintained and is not needed for most
practical uses of gmock. Even if it is used, its output is meant to be
hand-edited, so it shouldn't be used as part of the build flow.

Therefore, remove the host-gtest package. A proper, full host package
may make sense (for building other host packages that use gtest), but
this single script really doesn't.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Norbert Lange <nolange79@gmail.com>
---
Since we're so close to the 2021.08 release, this should probably be
delayed a little.
---
 package/gtest/gtest.mk | 27 ---------------------------
 1 file changed, 27 deletions(-)

diff --git a/package/gtest/gtest.mk b/package/gtest/gtest.mk
index 6447954e36..a9ac49957b 100644
--- a/package/gtest/gtest.mk
+++ b/package/gtest/gtest.mk
@@ -13,23 +13,6 @@ GTEST_LICENSE_FILES = LICENSE
 GTEST_CPE_ID_VENDOR = google
 GTEST_CPE_ID_PRODUCT = google_test
 
-ifeq ($(BR2_PACKAGE_GTEST_GMOCK),y)
-GTEST_DEPENDENCIES += host-gtest
-endif
-
-HOST_GTEST_LICENSE = Apache-2.0
-HOST_GTEST_LICENSE_FILES = googlemock/scripts/generator/LICENSE
-ifeq ($(BR2_PACKAGE_PYTHON3),y)
-HOST_GTEST_PYTHON_VERSION = $(PYTHON3_VERSION_MAJOR)
-HOST_GTEST_DEPENDENCIES += host-python3
-else
-HOST_GTEST_PYTHON_VERSION = $(PYTHON_VERSION_MAJOR)
-HOST_GTEST_DEPENDENCIES += host-python
-endif
-
-HOST_GTEST_GMOCK_PYTHONPATH = \
-	$(HOST_DIR)/lib/python$(HOST_GTEST_PYTHON_VERSION)/site-packages
-
 # While it is possible to build gtest as shared library, using this gtest shared
 # library requires to set some special configure option in the project using
 # gtest.
@@ -52,14 +35,4 @@ else
 GTEST_CONF_OPTS += -DBUILD_GMOCK=OFF
 endif
 
-define HOST_GTEST_INSTALL_CMDS
-	$(INSTALL) -D -m 0755 $(@D)/googlemock/scripts/generator/gmock_gen.py \
-		$(HOST_DIR)/bin/gmock_gen
-	cp -rp $(@D)/googlemock/scripts/generator/cpp \
-		$(HOST_GTEST_GMOCK_PYTHONPATH)
-endef
-
 $(eval $(cmake-package))
-# The host package does not build anything, just installs gmock_gen stuff, so
-# it does not need to be a host-cmake-package.
-$(eval $(host-generic-package))
-- 
2.31.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

             reply	other threads:[~2021-08-02 12:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 12:33 Arnout Vandecappelle (Essensium/Mind) [this message]
2021-08-02 13:09 ` [Buildroot] [PATCH for-next] package/gtest: remove partial host package Norbert Lange
2021-08-02 13:35   ` Arnout Vandecappelle
2021-08-19 21:31   ` Thomas Petazzoni
2021-08-20  8:12     ` Norbert Lange
2022-01-10  8:14 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802123300.564709-1-arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=nolange79@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.