All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Norbert Lange <nolange79@gmail.com>
Cc: buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH for-next] package/gtest: remove partial host package
Date: Thu, 19 Aug 2021 23:31:45 +0200	[thread overview]
Message-ID: <20210819233145.1802a72f@windsurf> (raw)
In-Reply-To: <CADYdroNf7PmpdHsfO_Hxz9ynWsLEcFVL9oX=+2nCMykuV3fNmw@mail.gmail.com>

Hello Norbert,

On Mon, 2 Aug 2021 15:09:06 +0200
Norbert Lange <nolange79@gmail.com> wrote:

> >  $(eval $(cmake-package))  
> 
> add this here:
> $(eval $(host-cmake-package))
> 
> It works, and I see no particular reason not to allow the host package.
> 
> > -# The host package does not build anything, just installs gmock_gen stuff, so
> > -# it does not need to be a host-cmake-package.
> > -$(eval $(host-generic-package))
> > --
> > 2.31.1
> >  
> 
> With this change the patch is identical to my local version, and thus
> Reviewed-by: Norbert Lange <nolange79@gmail.com>

Are you saying that you are using the gmock_gen script in your
workflow? If so, how does that fit with the commit description from
Arnout, which says:

  This script, however, is no longer maintained and is not needed for most
  practical uses of gmock. Even if it is used, its output is meant to be
  hand-edited, so it shouldn't be used as part of the build flow.

Thanks for your feedback,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  parent reply	other threads:[~2021-08-19 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 12:33 [Buildroot] [PATCH for-next] package/gtest: remove partial host package Arnout Vandecappelle (Essensium/Mind)
2021-08-02 13:09 ` Norbert Lange
2021-08-02 13:35   ` Arnout Vandecappelle
2021-08-19 21:31   ` Thomas Petazzoni [this message]
2021-08-20  8:12     ` Norbert Lange
2022-01-10  8:14 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210819233145.1802a72f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=nolange79@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.