Re: [Buildroot] [PATCH for-next] package/gtest: remove partial host package

[Norbert Lange <nolange79@gmail.com>]

Am Do., 19. Aug. 2021 um 23:31 Uhr schrieb Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> Hello Norbert,
>
> On Mon, 2 Aug 2021 15:09:06 +0200
> Norbert Lange <nolange79@gmail.com> wrote:
>
> > >  $(eval $(cmake-package))
> >
> > add this here:
> > $(eval $(host-cmake-package))
> >
> > It works, and I see no particular reason not to allow the host package.
> >
> > > -# The host package does not build anything, just installs gmock_gen stuff, so
> > > -# it does not need to be a host-cmake-package.
> > > -$(eval $(host-generic-package))
> > > --
> > > 2.31.1
> > >
> >
> > With this change the patch is identical to my local version, and thus
> > Reviewed-by: Norbert Lange <nolange79@gmail.com>
>
> Are you saying that you are using the gmock_gen script in your
> workflow? If so, how does that fit with the commit description from
> Arnout, which says:

I am saying that I agree with the patch, not that I use the script.

>
>   This script, however, is no longer maintained and is not needed for most
>   practical uses of gmock. Even if it is used, its output is meant to be
>   hand-edited, so it shouldn't be used as part of the build flow.

My original patch [2] did only install the script if python2/3
was built with buildroot. I had a similar commit message then,
suggesting the removal.

The script is only used to create some boilerplate code automatically,
but any reference of it is already removed from the docs [1].
To be clear, this was used manually and only one time when writing a test.

Given that the script is old and unmaintained, C++ is evolving,
its only a matter of time when parsing using this script turns into a
hit-and-miss.

Norbert

[1] - https://github.com/google/googletest/blob/master/docs/gmock_for_dummies.md#writing-the-mock-class
[2] - http://lists.busybox.net/pipermail/buildroot/2021-July/616335.html
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot