[PATCH 1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold"

[PATCH 1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold"

[derek.fang]

From: Derek Fang <derek.fang@realtek.com>

This reverts commit 6d20bf7c020f417fdef1810a22da17c126603472.
Since it may risk affecting other headset Vol- button.

Signed-off-by: Derek Fang <derek.fang@realtek.com>

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 7dc01ae6bb66..fcf442b8a732 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -44,7 +44,6 @@ static const struct reg_sequence patch_list[] = {
 	{RT5682_I2C_CTRL, 0x000f},
 	{RT5682_PLL2_INTERNAL, 0x8266},
 	{RT5682_SAR_IL_CMD_3, 0x8365},
-	{RT5682_SAR_IL_CMD_6, 0x0180},
 };
 
 void rt5682_apply_patch_list(struct rt5682_priv *rt5682, struct device *dev)
-- 
2.17.1

[PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold

[derek.fang]

From: Derek Fang <derek.fang@realtek.com>

Set a safe threshold of headset button volume+ to fix
the wrong button detection issue with some brand headsets.

Signed-off-by: Derek Fang <derek.fang@realtek.com>

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index fcf442b8a732..fad827368c5e 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -44,6 +44,7 @@ static const struct reg_sequence patch_list[] = {
 	{RT5682_I2C_CTRL, 0x000f},
 	{RT5682_PLL2_INTERNAL, 0x8266},
 	{RT5682_SAR_IL_CMD_3, 0x8365},
+	{RT5682_SAR_IL_CMD_6, 0x0110},
 };
 
 void rt5682_apply_patch_list(struct rt5682_priv *rt5682, struct device *dev)
-- 
2.17.1

RE: [PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold

[Derek [方德義]]

Hi Mark,


Please ignore this patch.

Sorry.



Thanks,

Derek


________________________________
寄件者: Derek [方德義]
寄件日期: 2021年8月2日 下午 08:37
收件者: broonie@kernel.org; lgirdwood@gmail.com
副本: alsa-devel@alsa-project.org; lars@metafoo.de; Flove(HsinFu); Oder Chiou; Jack Yu; Shuming [范書銘]; Albert Chen; Derek [方德義]
主旨: [PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold

From: Derek Fang <derek.fang@realtek.com>

Set a safe threshold of headset button volume+ to fix
the wrong button detection issue with some brand headsets.

Signed-off-by: Derek Fang <derek.fang@realtek.com>

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index fcf442b8a732..fad827368c5e 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -44,6 +44,7 @@ static const struct reg_sequence patch_list[] = {
         {RT5682_I2C_CTRL, 0x000f},
         {RT5682_PLL2_INTERNAL, 0x8266},
         {RT5682_SAR_IL_CMD_3, 0x8365},
+       {RT5682_SAR_IL_CMD_6, 0x0110},
 };

 void rt5682_apply_patch_list(struct rt5682_priv *rt5682, struct device *dev)
--
2.17.1

Re: [PATCH 1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold"

[Mark Brown]

On Wed, 11 Aug 2021 16:37:49 +0800, derek.fang@realtek.com wrote:
> From: Derek Fang <derek.fang@realtek.com>
> 
> This reverts commit 6d20bf7c020f417fdef1810a22da17c126603472.
> Since it may risk affecting other headset Vol- button.
> 
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold"
      commit: cf2a19f7d2b7d777b4a0ec6f3faa7fe3e4ad568e
[2/2] ASoC: rt5682: Fix the vol+ button detection issue
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

On Wed, Aug 11, 2021 at 04:37:49PM +0800, derek.fang@realtek.com wrote:
> From: Derek Fang <derek.fang@realtek.com>
> 
> This reverts commit 6d20bf7c020f417fdef1810a22da17c126603472.
> Since it may risk affecting other headset Vol- button.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH 1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold"

[derek.fang]

From: Derek Fang <derek.fang@realtek.com>

This reverts commit 6d20bf7c020f417fdef1810a22da17c126603472.
Since it may risk affecting other headset Vol- button.

Signed-off-by: Derek Fang <derek.fang@realtek.com>

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 7dc01ae6bb66..fcf442b8a732 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -44,7 +44,6 @@ static const struct reg_sequence patch_list[] = {
 	{RT5682_I2C_CTRL, 0x000f},
 	{RT5682_PLL2_INTERNAL, 0x8266},
 	{RT5682_SAR_IL_CMD_3, 0x8365},
-	{RT5682_SAR_IL_CMD_6, 0x0180},
 };
 
 void rt5682_apply_patch_list(struct rt5682_priv *rt5682, struct device *dev)
-- 
2.17.1