All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold"
@ 2021-08-02 12:37 derek.fang
  2021-08-02 12:37 ` [PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold derek.fang
  0 siblings, 1 reply; 3+ messages in thread
From: derek.fang @ 2021-08-02 12:37 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: oder_chiou, jack.yu, alsa-devel, lars, albertchen, Derek Fang,
	shumingf, flove

From: Derek Fang <derek.fang@realtek.com>

This reverts commit 6d20bf7c020f417fdef1810a22da17c126603472.
Since it may risk affecting other headset Vol- button.

Signed-off-by: Derek Fang <derek.fang@realtek.com>

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 7dc01ae6bb66..fcf442b8a732 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -44,7 +44,6 @@ static const struct reg_sequence patch_list[] = {
 	{RT5682_I2C_CTRL, 0x000f},
 	{RT5682_PLL2_INTERNAL, 0x8266},
 	{RT5682_SAR_IL_CMD_3, 0x8365},
-	{RT5682_SAR_IL_CMD_6, 0x0180},
 };
 
 void rt5682_apply_patch_list(struct rt5682_priv *rt5682, struct device *dev)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold
  2021-08-02 12:37 [PATCH 1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold" derek.fang
@ 2021-08-02 12:37 ` derek.fang
  2021-08-03 12:50   ` Derek [方德義]
  0 siblings, 1 reply; 3+ messages in thread
From: derek.fang @ 2021-08-02 12:37 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: oder_chiou, jack.yu, alsa-devel, lars, albertchen, Derek Fang,
	shumingf, flove

From: Derek Fang <derek.fang@realtek.com>

Set a safe threshold of headset button volume+ to fix
the wrong button detection issue with some brand headsets.

Signed-off-by: Derek Fang <derek.fang@realtek.com>

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index fcf442b8a732..fad827368c5e 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -44,6 +44,7 @@ static const struct reg_sequence patch_list[] = {
 	{RT5682_I2C_CTRL, 0x000f},
 	{RT5682_PLL2_INTERNAL, 0x8266},
 	{RT5682_SAR_IL_CMD_3, 0x8365},
+	{RT5682_SAR_IL_CMD_6, 0x0110},
 };
 
 void rt5682_apply_patch_list(struct rt5682_priv *rt5682, struct device *dev)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold
  2021-08-02 12:37 ` [PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold derek.fang
@ 2021-08-03 12:50   ` Derek [方德義]
  0 siblings, 0 replies; 3+ messages in thread
From: Derek [方德義] @ 2021-08-03 12:50 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: Oder Chiou, Jack Yu, alsa-devel, lars, Albert Chen,
	Shuming [范書銘], Flove(HsinFu)

Hi Mark,


Please ignore this patch.

Sorry.



Thanks,

Derek


________________________________
寄件者: Derek [方德義]
寄件日期: 2021年8月2日 下午 08:37
收件者: broonie@kernel.org; lgirdwood@gmail.com
副本: alsa-devel@alsa-project.org; lars@metafoo.de; Flove(HsinFu); Oder Chiou; Jack Yu; Shuming [范書銘]; Albert Chen; Derek [方德義]
主旨: [PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold

From: Derek Fang <derek.fang@realtek.com>

Set a safe threshold of headset button volume+ to fix
the wrong button detection issue with some brand headsets.

Signed-off-by: Derek Fang <derek.fang@realtek.com>

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index fcf442b8a732..fad827368c5e 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -44,6 +44,7 @@ static const struct reg_sequence patch_list[] = {
         {RT5682_I2C_CTRL, 0x000f},
         {RT5682_PLL2_INTERNAL, 0x8266},
         {RT5682_SAR_IL_CMD_3, 0x8365},
+       {RT5682_SAR_IL_CMD_6, 0x0110},
 };

 void rt5682_apply_patch_list(struct rt5682_priv *rt5682, struct device *dev)
--
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-03 12:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 12:37 [PATCH 1/2] Revert "ASoC: rt5682: Adjust headset volume button threshold" derek.fang
2021-08-02 12:37 ` [PATCH 2/2] ASoC: rt5682: Adjust the headset volume button threshold derek.fang
2021-08-03 12:50   ` Derek [方德義]

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.