[cip-dev][isar-cip-core][PATCH] swupdate-config: Remove runtime dependency efibootguard-dev

[cip-dev][isar-cip-core][PATCH] swupdate-config: Remove runtime dependency efibootguard-dev

[Quirin Gylstorff]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

efibootguard-dev is only a build time dependency and
not an runtime dependency.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
 classes/swupdate-config.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/swupdate-config.bbclass b/classes/swupdate-config.bbclass
index dfa3579..e4879c7 100644
--- a/classes/swupdate-config.bbclass
+++ b/classes/swupdate-config.bbclass
@@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"
 
 KFEATURE_efibootguard = ""
 KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
-KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
+KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
 KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
 KFEATURE_efibootguard[KCONFIG_SNIPPETS] = "file://swupdate_defconfig_efibootguard.snippet"
 
-- 
2.20.1


[-- Attachment #2: Type: text/plain, Size: 429 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6663): https://lists.cip-project.org/g/cip-dev/message/6663
Mute This Topic: https://lists.cip-project.org/mt/84765287/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev][isar-cip-core][PATCH] swupdate-config: Remove runtime dependency efibootguard-dev

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]

On 09.08.21 12:29, Q. Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> efibootguard-dev is only a build time dependency and
> not an runtime dependency.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  classes/swupdate-config.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/classes/swupdate-config.bbclass b/classes/swupdate-config.bbclass
> index dfa3579..e4879c7 100644
> --- a/classes/swupdate-config.bbclass
> +++ b/classes/swupdate-config.bbclass
> @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"
>  
>  KFEATURE_efibootguard = ""
>  KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
> -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
> +KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
>  KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
>  KFEATURE_efibootguard[KCONFIG_SNIPPETS] = "file://swupdate_defconfig_efibootguard.snippet"
>  
> 

-dev makes no sense, but don't we have any dep on libs? Or are they
statically linked?

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

[-- Attachment #2: Type: text/plain, Size: 429 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6664): https://lists.cip-project.org/g/cip-dev/message/6664
Mute This Topic: https://lists.cip-project.org/mt/84765287/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev][isar-cip-core][PATCH] swupdate-config: Remove runtime dependency efibootguard-dev

[Quirin Gylstorff]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]



On 8/9/21 2:54 PM, Jan Kiszka wrote:
> On 09.08.21 12:29, Q. Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> efibootguard-dev is only a build time dependency and
>> not an runtime dependency.
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>   classes/swupdate-config.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/classes/swupdate-config.bbclass b/classes/swupdate-config.bbclass
>> index dfa3579..e4879c7 100644
>> --- a/classes/swupdate-config.bbclass
>> +++ b/classes/swupdate-config.bbclass
>> @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"
>>   
>>   KFEATURE_efibootguard = ""
>>   KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
>> -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
>> +KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
>>   KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
>>   KFEATURE_efibootguard[KCONFIG_SNIPPETS] = "file://swupdate_defconfig_efibootguard.snippet"
>>   
>>
> 
> -dev makes no sense, but don't we have any dep on libs? Or are they
> statically linked?

It is statically linked - efibootguard-dev contains only libebgenv.a.

Quirin

> 
> Jan
> 

[-- Attachment #2: Type: text/plain, Size: 429 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6665): https://lists.cip-project.org/g/cip-dev/message/6665
Mute This Topic: https://lists.cip-project.org/mt/84765287/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev][isar-cip-core][PATCH] swupdate-config: Remove runtime dependency efibootguard-dev

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]

On 09.08.21 15:49, Gylstorff Quirin wrote:
> 
> 
> On 8/9/21 2:54 PM, Jan Kiszka wrote:
>> On 09.08.21 12:29, Q. Gylstorff wrote:
>>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>
>>> efibootguard-dev is only a build time dependency and
>>> not an runtime dependency.
>>>
>>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>> ---
>>>   classes/swupdate-config.bbclass | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/classes/swupdate-config.bbclass
>>> b/classes/swupdate-config.bbclass
>>> index dfa3579..e4879c7 100644
>>> --- a/classes/swupdate-config.bbclass
>>> +++ b/classes/swupdate-config.bbclass
>>> @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"
>>>     KFEATURE_efibootguard = ""
>>>   KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
>>> -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
>>> +KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
>>>   KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
>>>   KFEATURE_efibootguard[KCONFIG_SNIPPETS] =
>>> "file://swupdate_defconfig_efibootguard.snippet"
>>>  
>>
>> -dev makes no sense, but don't we have any dep on libs? Or are they
>> statically linked?
> 
> It is statically linked - efibootguard-dev contains only libebgenv.a.
> 

Ah, yeah, part the SWUpdate's problems...

Thanks, applied.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

[-- Attachment #2: Type: text/plain, Size: 429 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6666): https://lists.cip-project.org/g/cip-dev/message/6666
Mute This Topic: https://lists.cip-project.org/mt/84765287/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev][isar-cip-core][PATCH] swupdate-config: Remove runtime dependency efibootguard-dev

[Christian Storm]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

> >>> efibootguard-dev is only a build time dependency and
> >>> not an runtime dependency.
> >>>
> >>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> >>> ---
> >>>   classes/swupdate-config.bbclass | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/classes/swupdate-config.bbclass
> >>> b/classes/swupdate-config.bbclass
> >>> index dfa3579..e4879c7 100644
> >>> --- a/classes/swupdate-config.bbclass
> >>> +++ b/classes/swupdate-config.bbclass
> >>> @@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"
> >>>     KFEATURE_efibootguard = ""
> >>>   KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
> >>> -KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
> >>> +KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
> >>>   KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
> >>>   KFEATURE_efibootguard[KCONFIG_SNIPPETS] =
> >>> "file://swupdate_defconfig_efibootguard.snippet"
> >>>  
> >>
> >> -dev makes no sense, but don't we have any dep on libs? Or are they
> >> statically linked?
> > 
> > It is statically linked - efibootguard-dev contains only libebgenv.a.
> > 
> 
> Ah, yeah, part the SWUpdate's problems...

Well, meanwhile, this pattern has been deprecated in favor of
using https://github.com/sbabic/libubootenv
I guess it's about time for EFI Boot Guard to catch up..


Kind regards,
   Christian

-- 
Dr. Christian Storm
Siemens AG, Technology, T RDA IOT SES-DE
Otto-Hahn-Ring 6, 81739 München, Germany

[-- Attachment #2: Type: text/plain, Size: 429 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6668): https://lists.cip-project.org/g/cip-dev/message/6668
Mute This Topic: https://lists.cip-project.org/mt/84765287/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-