[PATCH] tty: replace in_irq() with in_hardirq()

[PATCH] tty: replace in_irq() with in_hardirq()

[Changbin Du]

Replace the obsolete and ambiguos macro in_irq() with new
macro in_hardirq().

Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
 drivers/tty/sysrq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 6628792431dc..c911196ac893 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -258,7 +258,7 @@ static void sysrq_handle_showallcpus(int key)
 	if (!trigger_all_cpu_backtrace()) {
 		struct pt_regs *regs = NULL;
 
-		if (in_irq())
+		if (in_hardirq())
 			regs = get_irq_regs();
 		if (regs) {
 			pr_info("CPU%d:\n", smp_processor_id());
@@ -280,7 +280,7 @@ static void sysrq_handle_showregs(int key)
 {
 	struct pt_regs *regs = NULL;
 
-	if (in_irq())
+	if (in_hardirq())
 		regs = get_irq_regs();
 	if (regs)
 		show_regs(regs);
-- 
2.30.2

Re: [PATCH] tty: replace in_irq() with in_hardirq()

[Jiri Slaby]

On 14. 08. 21, 2:50, Changbin Du wrote:
> Replace the obsolete and ambiguos macro in_irq() with new
> macro in_hardirq().

... which is just a new name.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
>   drivers/tty/sysrq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 6628792431dc..c911196ac893 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -258,7 +258,7 @@ static void sysrq_handle_showallcpus(int key)
>   	if (!trigger_all_cpu_backtrace()) {
>   		struct pt_regs *regs = NULL;
>   
> -		if (in_irq())
> +		if (in_hardirq())
>   			regs = get_irq_regs();
>   		if (regs) {
>   			pr_info("CPU%d:\n", smp_processor_id());
> @@ -280,7 +280,7 @@ static void sysrq_handle_showregs(int key)
>   {
>   	struct pt_regs *regs = NULL;
>   
> -	if (in_irq())
> +	if (in_hardirq())
>   		regs = get_irq_regs();
>   	if (regs)
>   		show_regs(regs);
> 


-- 
js
suse labs