All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: Shreeya Patel <shreeya.patel@collabora.com>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH 11/11] unicode: only export internal symbols for the selftests
Date: Wed, 18 Aug 2021 16:06:51 +0200	[thread overview]
Message-ID: <20210818140651.17181-12-hch@lst.de> (raw)
In-Reply-To: <20210818140651.17181-1-hch@lst.de>

The exported symbols in utf8-norm.c are not needed for normal
file system consumers, so move them to conditional _GPL exports
just for the selftest.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/unicode/utf8-norm.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/fs/unicode/utf8-norm.c b/fs/unicode/utf8-norm.c
index 829c7e2ad764..768f8ab448b8 100644
--- a/fs/unicode/utf8-norm.c
+++ b/fs/unicode/utf8-norm.c
@@ -17,7 +17,6 @@ int utf8version_is_supported(const struct unicode_map *um, unsigned int version)
 	}
 	return 0;
 }
-EXPORT_SYMBOL(utf8version_is_supported);
 
 /*
  * UTF-8 valid ranges.
@@ -407,7 +406,6 @@ ssize_t utf8nlen(const struct unicode_map *um, enum utf8_normalization n,
 	}
 	return ret;
 }
-EXPORT_SYMBOL(utf8nlen);
 
 /*
  * Set up an utf8cursor for use by utf8byte().
@@ -442,7 +440,6 @@ int utf8ncursor(struct utf8cursor *u8c, const struct unicode_map *um,
 		return -1;
 	return 0;
 }
-EXPORT_SYMBOL(utf8ncursor);
 
 /*
  * Get one byte from the normalized form of the string described by u8c.
@@ -588,4 +585,10 @@ int utf8byte(struct utf8cursor *u8c)
 		}
 	}
 }
-EXPORT_SYMBOL(utf8byte);
+
+#ifdef CONFIG_UNICODE_NORMALIZATION_SELFTEST_MODULE
+EXPORT_SYMBOL_GPL(utf8version_is_supported);
+EXPORT_SYMBOL_GPL(utf8nlen);
+EXPORT_SYMBOL_GPL(utf8ncursor);
+EXPORT_SYMBOL_GPL(utf8byte);
+#endif
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	Shreeya Patel <shreeya.patel@collabora.com>,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH 11/11] unicode: only export internal symbols for the selftests
Date: Wed, 18 Aug 2021 16:06:51 +0200	[thread overview]
Message-ID: <20210818140651.17181-12-hch@lst.de> (raw)
In-Reply-To: <20210818140651.17181-1-hch@lst.de>

The exported symbols in utf8-norm.c are not needed for normal
file system consumers, so move them to conditional _GPL exports
just for the selftest.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/unicode/utf8-norm.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/fs/unicode/utf8-norm.c b/fs/unicode/utf8-norm.c
index 829c7e2ad764..768f8ab448b8 100644
--- a/fs/unicode/utf8-norm.c
+++ b/fs/unicode/utf8-norm.c
@@ -17,7 +17,6 @@ int utf8version_is_supported(const struct unicode_map *um, unsigned int version)
 	}
 	return 0;
 }
-EXPORT_SYMBOL(utf8version_is_supported);
 
 /*
  * UTF-8 valid ranges.
@@ -407,7 +406,6 @@ ssize_t utf8nlen(const struct unicode_map *um, enum utf8_normalization n,
 	}
 	return ret;
 }
-EXPORT_SYMBOL(utf8nlen);
 
 /*
  * Set up an utf8cursor for use by utf8byte().
@@ -442,7 +440,6 @@ int utf8ncursor(struct utf8cursor *u8c, const struct unicode_map *um,
 		return -1;
 	return 0;
 }
-EXPORT_SYMBOL(utf8ncursor);
 
 /*
  * Get one byte from the normalized form of the string described by u8c.
@@ -588,4 +585,10 @@ int utf8byte(struct utf8cursor *u8c)
 		}
 	}
 }
-EXPORT_SYMBOL(utf8byte);
+
+#ifdef CONFIG_UNICODE_NORMALIZATION_SELFTEST_MODULE
+EXPORT_SYMBOL_GPL(utf8version_is_supported);
+EXPORT_SYMBOL_GPL(utf8nlen);
+EXPORT_SYMBOL_GPL(utf8ncursor);
+EXPORT_SYMBOL_GPL(utf8byte);
+#endif
-- 
2.30.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2021-08-18 14:24 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 14:06 unicode cleanups, and split the data table into a separate module Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] " Christoph Hellwig
2021-08-18 14:06 ` [PATCH 01/11] ext4: simplify ext4_sb_read_encoding Christoph Hellwig
2021-08-18 14:06   ` [f2fs-dev] " Christoph Hellwig
2021-08-23 14:51   ` Gabriel Krisman Bertazi
2021-08-23 14:51     ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-09-08 20:53   ` Theodore Ts'o
2021-09-08 20:53     ` [f2fs-dev] " Theodore Ts'o
2021-08-18 14:06 ` [PATCH 02/11] f2fs: simplify f2fs_sb_read_encoding Christoph Hellwig
2021-08-18 14:06   ` [f2fs-dev] " Christoph Hellwig
2021-08-23 14:52   ` Gabriel Krisman Bertazi
2021-08-23 14:52     ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-08-24  6:21   ` Chao Yu
2021-08-24  6:21     ` Chao Yu
2021-08-18 14:06 ` [PATCH 03/11] unicode: remove the charset field from struct unicode_map Christoph Hellwig
2021-08-18 14:06   ` [f2fs-dev] " Christoph Hellwig
2021-08-23 14:53   ` Gabriel Krisman Bertazi
2021-08-23 14:53     ` Gabriel Krisman Bertazi
2021-08-18 14:06 ` [f2fs-dev] [PATCH 04/11] unicode: mark the version field in struct unicode_map unsigned Christoph Hellwig
2021-08-18 14:06   ` Christoph Hellwig
2021-08-23 14:54   ` Gabriel Krisman Bertazi
2021-08-23 14:54     ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-08-18 14:06 ` [f2fs-dev] [PATCH 05/11] unicode: pass a UNICODE_AGE() tripple to utf8_load Christoph Hellwig
2021-08-18 14:06   ` Christoph Hellwig
2021-08-23 15:02   ` Gabriel Krisman Bertazi
2021-08-23 15:02     ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-08-24  7:34     ` Christoph Hellwig
2021-08-24  7:34       ` [f2fs-dev] " Christoph Hellwig
2021-09-06 22:13   ` Gabriel Krisman Bertazi
2021-09-06 22:13     ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-09-06 22:16     ` Gabriel Krisman Bertazi
2021-09-06 22:16       ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-09-08  6:19       ` Christoph Hellwig
2021-09-08  6:19         ` [f2fs-dev] " Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 06/11] unicode: remove the unused utf8{, n}age{min, max} functions Christoph Hellwig
2021-08-18 14:06   ` [PATCH 06/11] unicode: remove the unused utf8{,n}age{min,max} functions Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 07/11] unicode: simplify utf8len Christoph Hellwig
2021-08-18 14:06   ` Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 08/11] unicode: move utf8cursor to utf8-selftest.c Christoph Hellwig
2021-08-18 14:06   ` Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 09/11] unicode: cache the normalization tables in struct unicode_map Christoph Hellwig
2021-08-18 14:06   ` Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 10/11] unicode: Add utf8-data module Christoph Hellwig
2021-08-18 14:06   ` Christoph Hellwig
2021-08-18 14:06 ` Christoph Hellwig [this message]
2021-08-18 14:06   ` [f2fs-dev] [PATCH 11/11] unicode: only export internal symbols for the selftests Christoph Hellwig
2021-08-18 14:56   ` Matthew Wilcox
2021-08-18 14:56     ` [f2fs-dev] " Matthew Wilcox
2021-08-18 14:58     ` Christoph Hellwig
2021-08-18 14:58       ` [f2fs-dev] " Christoph Hellwig
2021-09-15  6:59 unicode cleanups, and split the data table into a separate module v2 Christoph Hellwig
2021-09-15  7:00 ` [PATCH 11/11] unicode: only export internal symbols for the selftests Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818140651.17181-12-hch@lst.de \
    --to=hch@lst.de \
    --cc=krisman@collabora.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=shreeya.patel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.