From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Shreeya Patel <shreeya.patel@collabora.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 01/11] ext4: simplify ext4_sb_read_encoding
Date: Mon, 23 Aug 2021 10:51:45 -0400 [thread overview]
Message-ID: <87bl5o2ozi.fsf@collabora.com> (raw)
In-Reply-To: <20210818140651.17181-2-hch@lst.de> (Christoph Hellwig's message of "Wed, 18 Aug 2021 16:06:41 +0200")
Christoph Hellwig <hch@lst.de> writes:
> Return the encoding table as the return value instead of as an argument,
> and don't bother with the encoding flags as the caller can handle that
> trivially.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me. Feel free to add
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
--
Gabriel Krisman Bertazi
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Shreeya Patel <shreeya.patel@collabora.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 01/11] ext4: simplify ext4_sb_read_encoding
Date: Mon, 23 Aug 2021 10:51:45 -0400 [thread overview]
Message-ID: <87bl5o2ozi.fsf@collabora.com> (raw)
In-Reply-To: <20210818140651.17181-2-hch@lst.de> (Christoph Hellwig's message of "Wed, 18 Aug 2021 16:06:41 +0200")
Christoph Hellwig <hch@lst.de> writes:
> Return the encoding table as the return value instead of as an argument,
> and don't bother with the encoding flags as the caller can handle that
> trivially.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me. Feel free to add
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
--
Gabriel Krisman Bertazi
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-08-23 14:51 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 14:06 unicode cleanups, and split the data table into a separate module Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] " Christoph Hellwig
2021-08-18 14:06 ` [PATCH 01/11] ext4: simplify ext4_sb_read_encoding Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] " Christoph Hellwig
2021-08-23 14:51 ` Gabriel Krisman Bertazi [this message]
2021-08-23 14:51 ` Gabriel Krisman Bertazi
2021-09-08 20:53 ` Theodore Ts'o
2021-09-08 20:53 ` [f2fs-dev] " Theodore Ts'o
2021-08-18 14:06 ` [PATCH 02/11] f2fs: simplify f2fs_sb_read_encoding Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] " Christoph Hellwig
2021-08-23 14:52 ` Gabriel Krisman Bertazi
2021-08-23 14:52 ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-08-24 6:21 ` Chao Yu
2021-08-24 6:21 ` Chao Yu
2021-08-18 14:06 ` [PATCH 03/11] unicode: remove the charset field from struct unicode_map Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] " Christoph Hellwig
2021-08-23 14:53 ` Gabriel Krisman Bertazi
2021-08-23 14:53 ` Gabriel Krisman Bertazi
2021-08-18 14:06 ` [f2fs-dev] [PATCH 04/11] unicode: mark the version field in struct unicode_map unsigned Christoph Hellwig
2021-08-18 14:06 ` Christoph Hellwig
2021-08-23 14:54 ` Gabriel Krisman Bertazi
2021-08-23 14:54 ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-08-18 14:06 ` [f2fs-dev] [PATCH 05/11] unicode: pass a UNICODE_AGE() tripple to utf8_load Christoph Hellwig
2021-08-18 14:06 ` Christoph Hellwig
2021-08-23 15:02 ` Gabriel Krisman Bertazi
2021-08-23 15:02 ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-08-24 7:34 ` Christoph Hellwig
2021-08-24 7:34 ` [f2fs-dev] " Christoph Hellwig
2021-09-06 22:13 ` Gabriel Krisman Bertazi
2021-09-06 22:13 ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-09-06 22:16 ` Gabriel Krisman Bertazi
2021-09-06 22:16 ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-09-08 6:19 ` Christoph Hellwig
2021-09-08 6:19 ` [f2fs-dev] " Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 06/11] unicode: remove the unused utf8{, n}age{min, max} functions Christoph Hellwig
2021-08-18 14:06 ` [PATCH 06/11] unicode: remove the unused utf8{,n}age{min,max} functions Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 07/11] unicode: simplify utf8len Christoph Hellwig
2021-08-18 14:06 ` Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 08/11] unicode: move utf8cursor to utf8-selftest.c Christoph Hellwig
2021-08-18 14:06 ` Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 09/11] unicode: cache the normalization tables in struct unicode_map Christoph Hellwig
2021-08-18 14:06 ` Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] [PATCH 10/11] unicode: Add utf8-data module Christoph Hellwig
2021-08-18 14:06 ` Christoph Hellwig
2021-08-18 14:06 ` [PATCH 11/11] unicode: only export internal symbols for the selftests Christoph Hellwig
2021-08-18 14:06 ` [f2fs-dev] " Christoph Hellwig
2021-08-18 14:56 ` Matthew Wilcox
2021-08-18 14:56 ` [f2fs-dev] " Matthew Wilcox
2021-08-18 14:58 ` Christoph Hellwig
2021-08-18 14:58 ` [f2fs-dev] " Christoph Hellwig
2021-09-15 6:59 unicode cleanups, and split the data table into a separate module v2 Christoph Hellwig
2021-09-15 6:59 ` [PATCH 01/11] ext4: simplify ext4_sb_read_encoding Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl5o2ozi.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.