* [PATCH bpf-next] libbpf: remove unused variable
@ 2021-08-20 16:55 Mauricio Vásquez
2021-08-20 18:06 ` Mauricio Vásquez Bernal
0 siblings, 1 reply; 2+ messages in thread
From: Mauricio Vásquez @ 2021-08-20 16:55 UTC (permalink / raw)
To: netdev, bpf
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Mauricio Vásquez
From: Mauricio Vásquez <mauriciov@microsoft.com>
Fixes: ddc7c3042614 ("libbpf: implement BPF CO-RE offset relocation algorithm")
Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
---
tools/lib/bpf/relo_core.c | 7 -------
1 file changed, 7 deletions(-)
diff --git tools/lib/bpf/relo_core.c tools/lib/bpf/relo_core.c
index 4016ed492d0c..52d8125b7cbe 100644
--- tools/lib/bpf/relo_core.c
+++ tools/lib/bpf/relo_core.c
@@ -417,13 +417,6 @@ static int bpf_core_match_member(const struct btf *local_btf,
return found;
} else if (strcmp(local_name, targ_name) == 0) {
/* matching named field */
- struct bpf_core_accessor *targ_acc;
-
- targ_acc = &spec->spec[spec->len++];
- targ_acc->type_id = targ_id;
- targ_acc->idx = i;
- targ_acc->name = targ_name;
-
*next_targ_id = m->type;
found = bpf_core_fields_are_compat(local_btf,
local_member->type,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] libbpf: remove unused variable
2021-08-20 16:55 [PATCH bpf-next] libbpf: remove unused variable Mauricio Vásquez
@ 2021-08-20 18:06 ` Mauricio Vásquez Bernal
0 siblings, 0 replies; 2+ messages in thread
From: Mauricio Vásquez Bernal @ 2021-08-20 18:06 UTC (permalink / raw)
To: netdev, bpf
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Mauricio Vásquez
On Fri, Aug 20, 2021 at 11:55 AM Mauricio Vásquez <mauricio@kinvolk.io> wrote:
>
> From: Mauricio Vásquez <mauriciov@microsoft.com>
>
> Fixes: ddc7c3042614 ("libbpf: implement BPF CO-RE offset relocation algorithm")
>
> Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
> ---
> tools/lib/bpf/relo_core.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git tools/lib/bpf/relo_core.c tools/lib/bpf/relo_core.c
> index 4016ed492d0c..52d8125b7cbe 100644
> --- tools/lib/bpf/relo_core.c
> +++ tools/lib/bpf/relo_core.c
> @@ -417,13 +417,6 @@ static int bpf_core_match_member(const struct btf *local_btf,
> return found;
> } else if (strcmp(local_name, targ_name) == 0) {
> /* matching named field */
> - struct bpf_core_accessor *targ_acc;
> -
> - targ_acc = &spec->spec[spec->len++];
> - targ_acc->type_id = targ_id;
> - targ_acc->idx = i;
> - targ_acc->name = targ_name;
> -
> *next_targ_id = m->type;
> found = bpf_core_fields_are_compat(local_btf,
> local_member->type,
> --
> 2.25.1
>
Forget that, it's used indeed. Sorry for the noise.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-20 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 16:55 [PATCH bpf-next] libbpf: remove unused variable Mauricio Vásquez
2021-08-20 18:06 ` Mauricio Vásquez Bernal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.