All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Huang Jianan <jnhuang95@gmail.com>
Cc: u-boot@lists.denx.de, xiang@kernel.org, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v2 2/3] fs/erofs: add lz4 1.8.3 decompressor
Date: Wed, 25 Aug 2021 18:39:53 -0400	[thread overview]
Message-ID: <20210825223953.GE858@bill-the-cat> (raw)
In-Reply-To: <20210823123646.9765-3-jnhuang95@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

On Mon, Aug 23, 2021 at 08:36:45PM +0800, Huang Jianan wrote:

> From: Huang Jianan <huangjianan@oppo.com>
> 
> In order to use the newest LZ4_decompress_safe_partial() which can
> now decode exactly the nb of bytes requested.
> 
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> ---
>  fs/erofs/Makefile |   3 +-
>  fs/erofs/lz4.c    | 534 ++++++++++++++++++++++++++++++++++++++++++++++
>  fs/erofs/lz4.h    |   5 +
>  3 files changed, 541 insertions(+), 1 deletion(-)
>  create mode 100644 fs/erofs/lz4.c
>  create mode 100644 fs/erofs/lz4.h

Why not use the existing lz4 support, or if it needs updating for new
features, update it?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tom Rini <trini@konsulko.com>
To: Huang Jianan <jnhuang95@gmail.com>
Cc: u-boot@lists.denx.de, linux-erofs@lists.ozlabs.org,
	huangjianan@oppo.com, xiang@kernel.org,
	hsiangkao@linux.alibaba.com, chao@kernel.org
Subject: Re: [PATCH v2 2/3] fs/erofs: add lz4 1.8.3 decompressor
Date: Wed, 25 Aug 2021 18:39:53 -0400	[thread overview]
Message-ID: <20210825223953.GE858@bill-the-cat> (raw)
In-Reply-To: <20210823123646.9765-3-jnhuang95@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

On Mon, Aug 23, 2021 at 08:36:45PM +0800, Huang Jianan wrote:

> From: Huang Jianan <huangjianan@oppo.com>
> 
> In order to use the newest LZ4_decompress_safe_partial() which can
> now decode exactly the nb of bytes requested.
> 
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> ---
>  fs/erofs/Makefile |   3 +-
>  fs/erofs/lz4.c    | 534 ++++++++++++++++++++++++++++++++++++++++++++++
>  fs/erofs/lz4.h    |   5 +
>  3 files changed, 541 insertions(+), 1 deletion(-)
>  create mode 100644 fs/erofs/lz4.c
>  create mode 100644 fs/erofs/lz4.h

Why not use the existing lz4 support, or if it needs updating for new
features, update it?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2021-08-25 22:40 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-22 15:48 [PATCH 1/3] fs/erofs: new filesystem Huang Jianan
2021-08-22 15:48 ` Huang Jianan
2021-08-22 15:48 ` [PATCH 2/3] fs/erofs: add lz4 1.8.3 decompressor Huang Jianan
2021-08-22 15:48   ` Huang Jianan
2021-08-22 15:48 ` [PATCH 3/3] fs/erofs: add lz4 decompression support Huang Jianan
2021-08-22 15:48   ` Huang Jianan
2021-08-23  4:24 ` [PATCH 1/3] fs/erofs: new filesystem Bin Meng
2021-08-23  4:24   ` Bin Meng
2021-08-23 11:46   ` Huang Jianan
2021-08-23 11:46     ` Huang Jianan
2021-08-23 12:36 ` [PATCH v2 0/3] " Huang Jianan
2021-08-23 12:36   ` Huang Jianan
2021-08-23 12:36   ` [PATCH v2 1/3] fs/erofs: add erofs filesystem support Huang Jianan
2021-08-23 12:36     ` Huang Jianan
2021-08-25 22:39     ` Tom Rini
2021-08-25 22:39       ` Tom Rini
2021-08-30 13:27       ` Huang Jianan
2021-08-30 13:27         ` Huang Jianan
2021-08-30 15:31         ` Huang Jianan
2021-08-30 15:31           ` Huang Jianan
2021-08-30 16:06           ` Tom Rini
2021-08-30 16:06             ` Tom Rini
2021-08-30 16:23             ` Gao Xiang
2021-08-30 16:23               ` Gao Xiang
2021-08-23 12:36   ` [PATCH v2 2/3] fs/erofs: add lz4 1.8.3 decompressor Huang Jianan
2021-08-23 12:36     ` Huang Jianan
2021-08-25 22:39     ` Tom Rini [this message]
2021-08-25 22:39       ` Tom Rini
2021-08-30 13:30       ` Huang Jianan
2021-08-30 13:30         ` Huang Jianan
2021-08-23 12:36   ` [PATCH v2 3/3] fs/erofs: add lz4 decompression support Huang Jianan
2021-08-23 12:36     ` Huang Jianan
2021-08-25  1:23   ` [PATCH v2 0/3] fs/erofs: new filesystem Gao Xiang
2021-08-25  1:23     ` Gao Xiang
2021-08-25 22:40   ` Tom Rini
2021-08-25 22:40     ` Tom Rini
2022-01-05 11:57     ` Gao Xiang
2022-01-05 11:57       ` Gao Xiang
2022-01-14 14:20       ` Huang Jianan
2022-01-14 14:20         ` Huang Jianan
2022-02-08 14:05   ` [PATCH v3 0/5] " Huang Jianan
2022-02-08 14:05     ` Huang Jianan
2022-02-08 14:05     ` [PATCH v3 1/5] fs/erofs: add erofs filesystem support Huang Jianan
2022-02-08 14:05       ` Huang Jianan
2022-02-08 14:05     ` [PATCH v3 2/5] lib/lz4: update LZ4 decompressor module Huang Jianan
2022-02-08 14:05       ` Huang Jianan
2022-02-08 14:05     ` [PATCH v3 3/5] fs/erofs: add lz4 decompression support Huang Jianan
2022-02-08 14:05       ` Huang Jianan
2022-02-08 14:05     ` [PATCH v3 4/5] fs/erofs: add filesystem commands Huang Jianan
2022-02-08 14:05       ` Huang Jianan
2022-02-08 14:05     ` [PATCH v3 5/5] test/py: Add tests for the erofs Huang Jianan
2022-02-08 14:05       ` Huang Jianan
2022-02-10 13:03       ` Tom Rini
2022-02-10 13:03         ` Tom Rini
2022-02-10 12:43     ` [PATCH v3 0/5] fs/erofs: new filesystem Gao Xiang
2022-02-10 12:43       ` Gao Xiang
2022-02-10 13:34       ` Tom Rini
2022-02-10 13:34         ` Tom Rini
2022-02-10 14:08         ` Gao Xiang
2022-02-10 14:08           ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825223953.GE858@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=jnhuang95@gmail.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=u-boot@lists.denx.de \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.