From: Gao Xiang <hsiangkao@linux.alibaba.com> To: Tom Rini <trini@konsulko.com> Cc: u-boot@lists.denx.de, xiang@kernel.org, linux-erofs@lists.ozlabs.org Subject: Re: [PATCH v2 1/3] fs/erofs: add erofs filesystem support Date: Tue, 31 Aug 2021 00:23:18 +0800 [thread overview] Message-ID: <YS0F9mFDrUFXGbH3@B-P7TQMD6M-0146.local> (raw) In-Reply-To: <20210830160646.GY858@bill-the-cat> On Mon, Aug 30, 2021 at 12:06:46PM -0400, Tom Rini wrote: > On Mon, Aug 30, 2021 at 11:31:28PM +0800, Huang Jianan wrote: > > 在 2021/8/30 21:27, Huang Jianan 写道: > > > > > > > > > 在 2021/8/26 6:39, Tom Rini 写道: > > > > On Mon, Aug 23, 2021 at 08:36:44PM +0800, Huang Jianan wrote: > > > > > > > > > From: Huang Jianan <huangjianan@oppo.com> > > > > > > > > > > This patch mainly deals with uncompressed files. > > > > > > > > > > Signed-off-by: Huang Jianan <huangjianan@oppo.com> > > > > > --- > > > > > fs/Kconfig | 1 + > > > > > fs/Makefile | 1 + > > > > > fs/erofs/Kconfig | 12 ++ > > > > > fs/erofs/Makefile | 7 + > > > > > fs/erofs/data.c | 124 ++++++++++++++ > > > > > fs/erofs/erofs_fs.h | 384 > > > > > ++++++++++++++++++++++++++++++++++++++++++++ > > > > > fs/erofs/fs.c | 231 ++++++++++++++++++++++++++ > > > > > fs/erofs/internal.h | 203 +++++++++++++++++++++++ > > > > > fs/erofs/namei.c | 238 +++++++++++++++++++++++++++ > > > > > fs/erofs/super.c | 65 ++++++++ > > > > > fs/fs.c | 22 +++ > > > > > include/erofs.h | 19 +++ > > > > > include/fs.h | 1 + > > > > > 13 files changed, 1308 insertions(+) > > > > > create mode 100644 fs/erofs/Kconfig > > > > > create mode 100644 fs/erofs/Makefile > > > > > create mode 100644 fs/erofs/data.c > > > > > create mode 100644 fs/erofs/erofs_fs.h > > > > > create mode 100644 fs/erofs/fs.c > > > > > create mode 100644 fs/erofs/internal.h > > > > > create mode 100644 fs/erofs/namei.c > > > > > create mode 100644 fs/erofs/super.c > > > > > create mode 100644 include/erofs.h > > > > Do the style problems checkpatch.pl complains about here match what's in > > > > the linux kernel? I expect at lease some of them come from using custom > > > > debug/etc macros rather than the standard logging functions. Thanks. > > > > > > The code is mainly come from erofs-utils, thems it has the same problem, > > > i > > > will fix it ASAP. > > > > > > Thanks, > > > Jianan > > > > > I have checked checkpatch.pl complains, some need to be fixed, and some > > come frome using custom macros. It seems that there are still some warnings > > that are inconsistent with the linux kernel, such as : > > > > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where > > possible > > #835: FILE: fs/erofs/fs.c:224: > > +#ifdef CONFIG_LIB_UUID > > > > WARNING: Possible switch case/default not preceded by break or fallthrough > > comment > > #763: FILE: fs/erofs/zmap.c:489: > > + case Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD: > > > > erofs-utils is written according to the linux kernel coding style, I expect > > this > > part can be consistent in order to reduce maintenance burden and keep > > with the latest feature. > > Yes, please fix what can be easily fixed and still kept in sync with > other projects. Agreed, erofs-utils follows linux kernel style. Maybe we could fix both together if easily fixed... Thanks, Gao Xiang > > -- > Tom
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@linux.alibaba.com> To: Tom Rini <trini@konsulko.com> Cc: Huang Jianan <jnhuang95@gmail.com>, u-boot@lists.denx.de, linux-erofs@lists.ozlabs.org, huangjianan@oppo.com, xiang@kernel.org, chao@kernel.org Subject: Re: [PATCH v2 1/3] fs/erofs: add erofs filesystem support Date: Tue, 31 Aug 2021 00:23:18 +0800 [thread overview] Message-ID: <YS0F9mFDrUFXGbH3@B-P7TQMD6M-0146.local> (raw) In-Reply-To: <20210830160646.GY858@bill-the-cat> On Mon, Aug 30, 2021 at 12:06:46PM -0400, Tom Rini wrote: > On Mon, Aug 30, 2021 at 11:31:28PM +0800, Huang Jianan wrote: > > 在 2021/8/30 21:27, Huang Jianan 写道: > > > > > > > > > 在 2021/8/26 6:39, Tom Rini 写道: > > > > On Mon, Aug 23, 2021 at 08:36:44PM +0800, Huang Jianan wrote: > > > > > > > > > From: Huang Jianan <huangjianan@oppo.com> > > > > > > > > > > This patch mainly deals with uncompressed files. > > > > > > > > > > Signed-off-by: Huang Jianan <huangjianan@oppo.com> > > > > > --- > > > > > fs/Kconfig | 1 + > > > > > fs/Makefile | 1 + > > > > > fs/erofs/Kconfig | 12 ++ > > > > > fs/erofs/Makefile | 7 + > > > > > fs/erofs/data.c | 124 ++++++++++++++ > > > > > fs/erofs/erofs_fs.h | 384 > > > > > ++++++++++++++++++++++++++++++++++++++++++++ > > > > > fs/erofs/fs.c | 231 ++++++++++++++++++++++++++ > > > > > fs/erofs/internal.h | 203 +++++++++++++++++++++++ > > > > > fs/erofs/namei.c | 238 +++++++++++++++++++++++++++ > > > > > fs/erofs/super.c | 65 ++++++++ > > > > > fs/fs.c | 22 +++ > > > > > include/erofs.h | 19 +++ > > > > > include/fs.h | 1 + > > > > > 13 files changed, 1308 insertions(+) > > > > > create mode 100644 fs/erofs/Kconfig > > > > > create mode 100644 fs/erofs/Makefile > > > > > create mode 100644 fs/erofs/data.c > > > > > create mode 100644 fs/erofs/erofs_fs.h > > > > > create mode 100644 fs/erofs/fs.c > > > > > create mode 100644 fs/erofs/internal.h > > > > > create mode 100644 fs/erofs/namei.c > > > > > create mode 100644 fs/erofs/super.c > > > > > create mode 100644 include/erofs.h > > > > Do the style problems checkpatch.pl complains about here match what's in > > > > the linux kernel? I expect at lease some of them come from using custom > > > > debug/etc macros rather than the standard logging functions. Thanks. > > > > > > The code is mainly come from erofs-utils, thems it has the same problem, > > > i > > > will fix it ASAP. > > > > > > Thanks, > > > Jianan > > > > > I have checked checkpatch.pl complains, some need to be fixed, and some > > come frome using custom macros. It seems that there are still some warnings > > that are inconsistent with the linux kernel, such as : > > > > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where > > possible > > #835: FILE: fs/erofs/fs.c:224: > > +#ifdef CONFIG_LIB_UUID > > > > WARNING: Possible switch case/default not preceded by break or fallthrough > > comment > > #763: FILE: fs/erofs/zmap.c:489: > > + case Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD: > > > > erofs-utils is written according to the linux kernel coding style, I expect > > this > > part can be consistent in order to reduce maintenance burden and keep > > with the latest feature. > > Yes, please fix what can be easily fixed and still kept in sync with > other projects. Agreed, erofs-utils follows linux kernel style. Maybe we could fix both together if easily fixed... Thanks, Gao Xiang > > -- > Tom
next prev parent reply other threads:[~2021-08-30 16:23 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-22 15:48 [PATCH 1/3] fs/erofs: new filesystem Huang Jianan 2021-08-22 15:48 ` Huang Jianan 2021-08-22 15:48 ` [PATCH 2/3] fs/erofs: add lz4 1.8.3 decompressor Huang Jianan 2021-08-22 15:48 ` Huang Jianan 2021-08-22 15:48 ` [PATCH 3/3] fs/erofs: add lz4 decompression support Huang Jianan 2021-08-22 15:48 ` Huang Jianan 2021-08-23 4:24 ` [PATCH 1/3] fs/erofs: new filesystem Bin Meng 2021-08-23 4:24 ` Bin Meng 2021-08-23 11:46 ` Huang Jianan 2021-08-23 11:46 ` Huang Jianan 2021-08-23 12:36 ` [PATCH v2 0/3] " Huang Jianan 2021-08-23 12:36 ` Huang Jianan 2021-08-23 12:36 ` [PATCH v2 1/3] fs/erofs: add erofs filesystem support Huang Jianan 2021-08-23 12:36 ` Huang Jianan 2021-08-25 22:39 ` Tom Rini 2021-08-25 22:39 ` Tom Rini 2021-08-30 13:27 ` Huang Jianan 2021-08-30 13:27 ` Huang Jianan 2021-08-30 15:31 ` Huang Jianan 2021-08-30 15:31 ` Huang Jianan 2021-08-30 16:06 ` Tom Rini 2021-08-30 16:06 ` Tom Rini 2021-08-30 16:23 ` Gao Xiang [this message] 2021-08-30 16:23 ` Gao Xiang 2021-08-23 12:36 ` [PATCH v2 2/3] fs/erofs: add lz4 1.8.3 decompressor Huang Jianan 2021-08-23 12:36 ` Huang Jianan 2021-08-25 22:39 ` Tom Rini 2021-08-25 22:39 ` Tom Rini 2021-08-30 13:30 ` Huang Jianan 2021-08-30 13:30 ` Huang Jianan 2021-08-23 12:36 ` [PATCH v2 3/3] fs/erofs: add lz4 decompression support Huang Jianan 2021-08-23 12:36 ` Huang Jianan 2021-08-25 1:23 ` [PATCH v2 0/3] fs/erofs: new filesystem Gao Xiang 2021-08-25 1:23 ` Gao Xiang 2021-08-25 22:40 ` Tom Rini 2021-08-25 22:40 ` Tom Rini 2022-01-05 11:57 ` Gao Xiang 2022-01-05 11:57 ` Gao Xiang 2022-01-14 14:20 ` Huang Jianan 2022-01-14 14:20 ` Huang Jianan 2022-02-08 14:05 ` [PATCH v3 0/5] " Huang Jianan 2022-02-08 14:05 ` Huang Jianan 2022-02-08 14:05 ` [PATCH v3 1/5] fs/erofs: add erofs filesystem support Huang Jianan 2022-02-08 14:05 ` Huang Jianan 2022-02-08 14:05 ` [PATCH v3 2/5] lib/lz4: update LZ4 decompressor module Huang Jianan 2022-02-08 14:05 ` Huang Jianan 2022-02-08 14:05 ` [PATCH v3 3/5] fs/erofs: add lz4 decompression support Huang Jianan 2022-02-08 14:05 ` Huang Jianan 2022-02-08 14:05 ` [PATCH v3 4/5] fs/erofs: add filesystem commands Huang Jianan 2022-02-08 14:05 ` Huang Jianan 2022-02-08 14:05 ` [PATCH v3 5/5] test/py: Add tests for the erofs Huang Jianan 2022-02-08 14:05 ` Huang Jianan 2022-02-10 13:03 ` Tom Rini 2022-02-10 13:03 ` Tom Rini 2022-02-10 12:43 ` [PATCH v3 0/5] fs/erofs: new filesystem Gao Xiang 2022-02-10 12:43 ` Gao Xiang 2022-02-10 13:34 ` Tom Rini 2022-02-10 13:34 ` Tom Rini 2022-02-10 14:08 ` Gao Xiang 2022-02-10 14:08 ` Gao Xiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YS0F9mFDrUFXGbH3@B-P7TQMD6M-0146.local \ --to=hsiangkao@linux.alibaba.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=trini@konsulko.com \ --cc=u-boot@lists.denx.de \ --cc=xiang@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.