From: Vladimir Oltean <olteanv@gmail.com>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC net-next 2/2] net: dsa: tag_mtk: handle VLAN tag insertion on TX
Date: Thu, 26 Aug 2021 17:13:26 +0300 [thread overview]
Message-ID: <20210826141326.xa52776uh3r3jpg4@skbuf> (raw)
In-Reply-To: <20210826052956.3101243-1-dqfext@gmail.com>
On Thu, Aug 26, 2021 at 01:29:56PM +0800, DENG Qingfang wrote:
> On Thu, Aug 26, 2021 at 03:03:49AM +0300, Vladimir Oltean wrote:
> >
> > You cannot just remove the old code. Only things like 8021q uppers will
> > send packets with the VLAN in the hwaccel area.
> >
> > If you have an application that puts the VLAN in the actual AF_PACKET
> > payload, like:
> >
> > https://github.com/vladimiroltean/tsn-scripts/blob/master/isochron/send.c
> >
> > then you need to handle the VLAN being in the skb payload.
>
> I've actually tested this (only apply patch 2 without .features) and it
> still worked.
>
> The comment says the VLAN tag need to be combined with the special tag in
> order to perform VLAN table lookup,
It does say this.
> so we can set its destination port vector to all zeroes and the switch
> will forward it like a data frame (TX forward offload),
And it does not say this. So this is supported after all with mt7530?
Are you looking to add support for that?
> but as we allow multiple bridges which are either VLAN-unaware or
> VLAN-aware with the same VID, there is no way to determine the
> destination bridge unless we maintain some VLAN translation mapping.
What does "VLAN translation mapping" mean, practically?
Other drivers which cannot remap VIDs to internal VLANs just restrict a
single VLAN-aware bridge, and potentially multiple VLAN-unaware ones.
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC net-next 2/2] net: dsa: tag_mtk: handle VLAN tag insertion on TX
Date: Thu, 26 Aug 2021 17:13:26 +0300 [thread overview]
Message-ID: <20210826141326.xa52776uh3r3jpg4@skbuf> (raw)
In-Reply-To: <20210826052956.3101243-1-dqfext@gmail.com>
On Thu, Aug 26, 2021 at 01:29:56PM +0800, DENG Qingfang wrote:
> On Thu, Aug 26, 2021 at 03:03:49AM +0300, Vladimir Oltean wrote:
> >
> > You cannot just remove the old code. Only things like 8021q uppers will
> > send packets with the VLAN in the hwaccel area.
> >
> > If you have an application that puts the VLAN in the actual AF_PACKET
> > payload, like:
> >
> > https://github.com/vladimiroltean/tsn-scripts/blob/master/isochron/send.c
> >
> > then you need to handle the VLAN being in the skb payload.
>
> I've actually tested this (only apply patch 2 without .features) and it
> still worked.
>
> The comment says the VLAN tag need to be combined with the special tag in
> order to perform VLAN table lookup,
It does say this.
> so we can set its destination port vector to all zeroes and the switch
> will forward it like a data frame (TX forward offload),
And it does not say this. So this is supported after all with mt7530?
Are you looking to add support for that?
> but as we allow multiple bridges which are either VLAN-unaware or
> VLAN-aware with the same VID, there is no way to determine the
> destination bridge unless we maintain some VLAN translation mapping.
What does "VLAN translation mapping" mean, practically?
Other drivers which cannot remap VIDs to internal VLANs just restrict a
single VLAN-aware bridge, and potentially multiple VLAN-unaware ones.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC net-next 2/2] net: dsa: tag_mtk: handle VLAN tag insertion on TX
Date: Thu, 26 Aug 2021 17:13:26 +0300 [thread overview]
Message-ID: <20210826141326.xa52776uh3r3jpg4@skbuf> (raw)
In-Reply-To: <20210826052956.3101243-1-dqfext@gmail.com>
On Thu, Aug 26, 2021 at 01:29:56PM +0800, DENG Qingfang wrote:
> On Thu, Aug 26, 2021 at 03:03:49AM +0300, Vladimir Oltean wrote:
> >
> > You cannot just remove the old code. Only things like 8021q uppers will
> > send packets with the VLAN in the hwaccel area.
> >
> > If you have an application that puts the VLAN in the actual AF_PACKET
> > payload, like:
> >
> > https://github.com/vladimiroltean/tsn-scripts/blob/master/isochron/send.c
> >
> > then you need to handle the VLAN being in the skb payload.
>
> I've actually tested this (only apply patch 2 without .features) and it
> still worked.
>
> The comment says the VLAN tag need to be combined with the special tag in
> order to perform VLAN table lookup,
It does say this.
> so we can set its destination port vector to all zeroes and the switch
> will forward it like a data frame (TX forward offload),
And it does not say this. So this is supported after all with mt7530?
Are you looking to add support for that?
> but as we allow multiple bridges which are either VLAN-unaware or
> VLAN-aware with the same VID, there is no way to determine the
> destination bridge unless we maintain some VLAN translation mapping.
What does "VLAN translation mapping" mean, practically?
Other drivers which cannot remap VIDs to internal VLANs just restrict a
single VLAN-aware bridge, and potentially multiple VLAN-unaware ones.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-26 14:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 8:38 [RFC net-next 0/2] DSA slave with customise netdev features DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-25 8:38 ` [RFC net-next 1/2] net: dsa: allow taggers to " DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-26 0:01 ` Vladimir Oltean
2021-08-26 0:01 ` Vladimir Oltean
2021-08-26 0:01 ` Vladimir Oltean
2021-08-26 11:28 ` Florian Fainelli
2021-08-26 11:28 ` Florian Fainelli
2021-08-26 11:28 ` Florian Fainelli
2021-08-25 8:38 ` [RFC net-next 2/2] net: dsa: tag_mtk: handle VLAN tag insertion on TX DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-26 0:03 ` Vladimir Oltean
2021-08-26 0:03 ` Vladimir Oltean
2021-08-26 0:03 ` Vladimir Oltean
2021-08-26 5:29 ` DENG Qingfang
2021-08-26 5:29 ` DENG Qingfang
2021-08-26 5:29 ` DENG Qingfang
2021-08-26 11:37 ` Florian Fainelli
2021-08-26 11:37 ` Florian Fainelli
2021-08-26 11:37 ` Florian Fainelli
2021-08-26 14:13 ` Vladimir Oltean [this message]
2021-08-26 14:13 ` Vladimir Oltean
2021-08-26 14:13 ` Vladimir Oltean
2021-08-26 15:27 ` DENG Qingfang
2021-08-26 15:27 ` DENG Qingfang
2021-08-26 15:27 ` DENG Qingfang
2021-08-26 0:00 ` [RFC net-next 0/2] DSA slave with customise netdev features Vladimir Oltean
2021-08-26 0:00 ` Vladimir Oltean
2021-08-26 0:00 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826141326.xa52776uh3r3jpg4@skbuf \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.