From: Florian Fainelli <f.fainelli@gmail.com>
To: DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [RFC net-next 1/2] net: dsa: allow taggers to customise netdev features
Date: Thu, 26 Aug 2021 13:28:29 +0200 [thread overview]
Message-ID: <4b61ce72-87ec-cf8b-9f71-67eb329a9ce6@gmail.com> (raw)
In-Reply-To: <20210825083832.2425886-2-dqfext@gmail.com>
On 8/25/2021 10:38 AM, DENG Qingfang wrote:
> Allow taggers to add netdev features, such as VLAN offload, to slave
> devices, which will make it possible for taggers to handle VLAN tags
> themselves.
>
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Besides transmit VLAN tag offload, do you think there are other netdev
feature bits that would warrant something like this as opposed to a more
structured approach with adding a specific boolean/flag that is specific
to the netdev feature you want to propagate towards the DSA slave_dev?
Still:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [RFC net-next 1/2] net: dsa: allow taggers to customise netdev features
Date: Thu, 26 Aug 2021 13:28:29 +0200 [thread overview]
Message-ID: <4b61ce72-87ec-cf8b-9f71-67eb329a9ce6@gmail.com> (raw)
In-Reply-To: <20210825083832.2425886-2-dqfext@gmail.com>
On 8/25/2021 10:38 AM, DENG Qingfang wrote:
> Allow taggers to add netdev features, such as VLAN offload, to slave
> devices, which will make it possible for taggers to handle VLAN tags
> themselves.
>
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Besides transmit VLAN tag offload, do you think there are other netdev
feature bits that would warrant something like this as opposed to a more
structured approach with adding a specific boolean/flag that is specific
to the netdev feature you want to propagate towards the DSA slave_dev?
Still:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [RFC net-next 1/2] net: dsa: allow taggers to customise netdev features
Date: Thu, 26 Aug 2021 13:28:29 +0200 [thread overview]
Message-ID: <4b61ce72-87ec-cf8b-9f71-67eb329a9ce6@gmail.com> (raw)
In-Reply-To: <20210825083832.2425886-2-dqfext@gmail.com>
On 8/25/2021 10:38 AM, DENG Qingfang wrote:
> Allow taggers to add netdev features, such as VLAN offload, to slave
> devices, which will make it possible for taggers to handle VLAN tags
> themselves.
>
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Besides transmit VLAN tag offload, do you think there are other netdev
feature bits that would warrant something like this as opposed to a more
structured approach with adding a specific boolean/flag that is specific
to the netdev feature you want to propagate towards the DSA slave_dev?
Still:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-26 11:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 8:38 [RFC net-next 0/2] DSA slave with customise netdev features DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-25 8:38 ` [RFC net-next 1/2] net: dsa: allow taggers to " DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-26 0:01 ` Vladimir Oltean
2021-08-26 0:01 ` Vladimir Oltean
2021-08-26 0:01 ` Vladimir Oltean
2021-08-26 11:28 ` Florian Fainelli [this message]
2021-08-26 11:28 ` Florian Fainelli
2021-08-26 11:28 ` Florian Fainelli
2021-08-25 8:38 ` [RFC net-next 2/2] net: dsa: tag_mtk: handle VLAN tag insertion on TX DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-25 8:38 ` DENG Qingfang
2021-08-26 0:03 ` Vladimir Oltean
2021-08-26 0:03 ` Vladimir Oltean
2021-08-26 0:03 ` Vladimir Oltean
2021-08-26 5:29 ` DENG Qingfang
2021-08-26 5:29 ` DENG Qingfang
2021-08-26 5:29 ` DENG Qingfang
2021-08-26 11:37 ` Florian Fainelli
2021-08-26 11:37 ` Florian Fainelli
2021-08-26 11:37 ` Florian Fainelli
2021-08-26 14:13 ` Vladimir Oltean
2021-08-26 14:13 ` Vladimir Oltean
2021-08-26 14:13 ` Vladimir Oltean
2021-08-26 15:27 ` DENG Qingfang
2021-08-26 15:27 ` DENG Qingfang
2021-08-26 15:27 ` DENG Qingfang
2021-08-26 0:00 ` [RFC net-next 0/2] DSA slave with customise netdev features Vladimir Oltean
2021-08-26 0:00 ` Vladimir Oltean
2021-08-26 0:00 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b61ce72-87ec-cf8b-9f71-67eb329a9ce6@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.