From: kernel test robot <lkp@intel.com> To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org Cc: kbuild-all@lists.01.org, Nicholas Piggin <npiggin@gmail.com> Subject: Re: [PATCH v2 3/4] powerpc/64s/interrupt: Don't enable MSR[EE] in irq handlers unless perf is in use Date: Thu, 26 Aug 2021 23:04:07 +0800 [thread overview] Message-ID: <202108262232.PzC05uqr-lkp@intel.com> (raw) In-Reply-To: <20210825123714.706201-4-npiggin@gmail.com> [-- Attachment #1: Type: text/plain, Size: 6119 bytes --] Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.14-rc7 next-20210826] [cannot apply to scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-interrupt-speedups/20210825-204209 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allnoconfig (attached as .config) compiler: powerpc-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/a0eb195f49a01ed45b3f97815470f9c8acaa4991 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nicholas-Piggin/powerpc-64s-interrupt-speedups/20210825-204209 git checkout a0eb195f49a01ed45b3f97815470f9c8acaa4991 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): arch/powerpc/kernel/irq.c: In function '__do_irq': >> arch/powerpc/kernel/irq.c:742:13: error: implicit declaration of function 'should_hard_irq_enable'; did you mean 'do_hard_irq_enable'? [-Werror=implicit-function-declaration] 742 | if (should_hard_irq_enable()) | ^~~~~~~~~~~~~~~~~~~~~~ | do_hard_irq_enable In file included from <command-line>: In function 'do_hard_irq_enable', inlined from '__do_irq' at arch/powerpc/kernel/irq.c:743:3: >> include/linux/compiler_types.h:328:45: error: call to '__compiletime_assert_34' declared with attribute error: BUILD_BUG failed 328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:309:25: note: in definition of macro '__compiletime_assert' 309 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:328:9: note: in expansion of macro '_compiletime_assert' 328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ arch/powerpc/include/asm/hw_irq.h:447:9: note: in expansion of macro 'BUILD_BUG' 447 | BUILD_BUG(); | ^~~~~~~~~ cc1: all warnings being treated as errors -- arch/powerpc/kernel/time.c: In function '____timer_interrupt': >> arch/powerpc/kernel/time.c:570:13: error: implicit declaration of function 'should_hard_irq_enable'; did you mean 'do_hard_irq_enable'? [-Werror=implicit-function-declaration] 570 | if (should_hard_irq_enable()) { | ^~~~~~~~~~~~~~~~~~~~~~ | do_hard_irq_enable In file included from <command-line>: In function 'do_hard_irq_enable', inlined from '____timer_interrupt' at arch/powerpc/kernel/time.c:584:3, inlined from 'timer_interrupt' at arch/powerpc/kernel/time.c:553:1: >> include/linux/compiler_types.h:328:45: error: call to '__compiletime_assert_34' declared with attribute error: BUILD_BUG failed 328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:309:25: note: in definition of macro '__compiletime_assert' 309 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:328:9: note: in expansion of macro '_compiletime_assert' 328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ arch/powerpc/include/asm/hw_irq.h:447:9: note: in expansion of macro 'BUILD_BUG' 447 | BUILD_BUG(); | ^~~~~~~~~ cc1: all warnings being treated as errors vim +742 arch/powerpc/kernel/irq.c 727 728 void __do_irq(struct pt_regs *regs) 729 { 730 unsigned int irq; 731 732 trace_irq_entry(regs); 733 734 /* 735 * Query the platform PIC for the interrupt & ack it. 736 * 737 * This will typically lower the interrupt line to the CPU 738 */ 739 irq = ppc_md.get_irq(); 740 741 /* We can hard enable interrupts now to allow perf interrupts */ > 742 if (should_hard_irq_enable()) 743 do_hard_irq_enable(); 744 745 /* And finally process it */ 746 if (unlikely(!irq)) 747 __this_cpu_inc(irq_stat.spurious_irqs); 748 else 749 generic_handle_irq(irq); 750 751 trace_irq_exit(regs); 752 } 753 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 7152 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 3/4] powerpc/64s/interrupt: Don't enable MSR[EE] in irq handlers unless perf is in use Date: Thu, 26 Aug 2021 23:04:07 +0800 [thread overview] Message-ID: <202108262232.PzC05uqr-lkp@intel.com> (raw) In-Reply-To: <20210825123714.706201-4-npiggin@gmail.com> [-- Attachment #1: Type: text/plain, Size: 6242 bytes --] Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.14-rc7 next-20210826] [cannot apply to scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-interrupt-speedups/20210825-204209 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allnoconfig (attached as .config) compiler: powerpc-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/a0eb195f49a01ed45b3f97815470f9c8acaa4991 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nicholas-Piggin/powerpc-64s-interrupt-speedups/20210825-204209 git checkout a0eb195f49a01ed45b3f97815470f9c8acaa4991 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): arch/powerpc/kernel/irq.c: In function '__do_irq': >> arch/powerpc/kernel/irq.c:742:13: error: implicit declaration of function 'should_hard_irq_enable'; did you mean 'do_hard_irq_enable'? [-Werror=implicit-function-declaration] 742 | if (should_hard_irq_enable()) | ^~~~~~~~~~~~~~~~~~~~~~ | do_hard_irq_enable In file included from <command-line>: In function 'do_hard_irq_enable', inlined from '__do_irq' at arch/powerpc/kernel/irq.c:743:3: >> include/linux/compiler_types.h:328:45: error: call to '__compiletime_assert_34' declared with attribute error: BUILD_BUG failed 328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:309:25: note: in definition of macro '__compiletime_assert' 309 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:328:9: note: in expansion of macro '_compiletime_assert' 328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ arch/powerpc/include/asm/hw_irq.h:447:9: note: in expansion of macro 'BUILD_BUG' 447 | BUILD_BUG(); | ^~~~~~~~~ cc1: all warnings being treated as errors -- arch/powerpc/kernel/time.c: In function '____timer_interrupt': >> arch/powerpc/kernel/time.c:570:13: error: implicit declaration of function 'should_hard_irq_enable'; did you mean 'do_hard_irq_enable'? [-Werror=implicit-function-declaration] 570 | if (should_hard_irq_enable()) { | ^~~~~~~~~~~~~~~~~~~~~~ | do_hard_irq_enable In file included from <command-line>: In function 'do_hard_irq_enable', inlined from '____timer_interrupt' at arch/powerpc/kernel/time.c:584:3, inlined from 'timer_interrupt' at arch/powerpc/kernel/time.c:553:1: >> include/linux/compiler_types.h:328:45: error: call to '__compiletime_assert_34' declared with attribute error: BUILD_BUG failed 328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:309:25: note: in definition of macro '__compiletime_assert' 309 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:328:9: note: in expansion of macro '_compiletime_assert' 328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ arch/powerpc/include/asm/hw_irq.h:447:9: note: in expansion of macro 'BUILD_BUG' 447 | BUILD_BUG(); | ^~~~~~~~~ cc1: all warnings being treated as errors vim +742 arch/powerpc/kernel/irq.c 727 728 void __do_irq(struct pt_regs *regs) 729 { 730 unsigned int irq; 731 732 trace_irq_entry(regs); 733 734 /* 735 * Query the platform PIC for the interrupt & ack it. 736 * 737 * This will typically lower the interrupt line to the CPU 738 */ 739 irq = ppc_md.get_irq(); 740 741 /* We can hard enable interrupts now to allow perf interrupts */ > 742 if (should_hard_irq_enable()) 743 do_hard_irq_enable(); 744 745 /* And finally process it */ 746 if (unlikely(!irq)) 747 __this_cpu_inc(irq_stat.spurious_irqs); 748 else 749 generic_handle_irq(irq); 750 751 trace_irq_exit(regs); 752 } 753 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 7152 bytes --]
next prev parent reply other threads:[~2021-08-26 15:06 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-25 12:37 [PATCH v2 0/4] powerpc/64s: interrupt speedups Nicholas Piggin 2021-08-25 12:37 ` [PATCH v2 1/4] powerpc/64: handle MSR EE and RI in interrupt entry wrapper Nicholas Piggin 2021-08-27 7:31 ` Daniel Axtens 2021-08-30 7:32 ` Nicholas Piggin 2021-08-25 12:37 ` [PATCH v2 2/4] powerpc/64s/perf: add power_pmu_wants_prompt_pmi to say whether perf wants PMIs to be soft-NMI Nicholas Piggin 2021-08-25 12:37 ` [PATCH v2 3/4] powerpc/64s/interrupt: Don't enable MSR[EE] in irq handlers unless perf is in use Nicholas Piggin 2021-08-26 15:04 ` kernel test robot [this message] 2021-08-26 15:04 ` kernel test robot 2021-08-27 1:33 ` Nicholas Piggin 2021-08-27 1:33 ` Nicholas Piggin 2021-08-25 12:37 ` [PATCH v2 4/4] powerpc/64s/interrupt: avoid saving CFAR in some asynchronous interrupts Nicholas Piggin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202108262232.PzC05uqr-lkp@intel.com \ --to=lkp@intel.com \ --cc=kbuild-all@lists.01.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=npiggin@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.