* [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page
@ 2021-08-30 14:53 Jia He
2021-09-01 19:57 ` Sean Christopherson
2021-09-06 10:13 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Jia He @ 2021-08-30 14:53 UTC (permalink / raw)
To: Paolo Bonzini, Sean Christopherson
Cc: Vitaly Kuznetsov, Wanpeng Li, Jim Mattson, Joerg Roedel,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, kvm, linux-kernel, Jia He
After reverting and restoring the fast tlb invalidation patch series,
the mmio_cached is not removed. Hence a unused field is left in
kvm_mmu_page.
Cc: Sean Christopherson <seanjc@google.com>
Signed-off-by: Jia He <justin.he@arm.com>
---
arch/x86/kvm/mmu/mmu_internal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
index 35567293c1fd..3e6f21c1871a 100644
--- a/arch/x86/kvm/mmu/mmu_internal.h
+++ b/arch/x86/kvm/mmu/mmu_internal.h
@@ -37,7 +37,6 @@ struct kvm_mmu_page {
bool unsync;
u8 mmu_valid_gen;
- bool mmio_cached;
bool lpage_disallowed; /* Can't be replaced by an equiv large page */
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page
2021-08-30 14:53 [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page Jia He
@ 2021-09-01 19:57 ` Sean Christopherson
2021-09-06 10:13 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2021-09-01 19:57 UTC (permalink / raw)
To: Jia He
Cc: Paolo Bonzini, Vitaly Kuznetsov, Wanpeng Li, Jim Mattson,
Joerg Roedel, Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, kvm, linux-kernel
On Mon, Aug 30, 2021, Jia He wrote:
> After reverting and restoring the fast tlb invalidation patch series,
> the mmio_cached is not removed. Hence a unused field is left in
> kvm_mmu_page.
>
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Jia He <justin.he@arm.com>
Reviewed-by: Sean Christopherson <seanjc@google.com>
There's also additional cleanup we can do to take advantage of the free byte.
I'll include this patch in a follow-up mini-series to hopefully make life a bit
easier for Paolo.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page
2021-08-30 14:53 [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page Jia He
2021-09-01 19:57 ` Sean Christopherson
@ 2021-09-06 10:13 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-09-06 10:13 UTC (permalink / raw)
To: Jia He, Sean Christopherson
Cc: Vitaly Kuznetsov, Wanpeng Li, Jim Mattson, Joerg Roedel,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, kvm, linux-kernel
On 30/08/21 16:53, Jia He wrote:
> After reverting and restoring the fast tlb invalidation patch series,
> the mmio_cached is not removed. Hence a unused field is left in
> kvm_mmu_page.
>
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
> arch/x86/kvm/mmu/mmu_internal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
> index 35567293c1fd..3e6f21c1871a 100644
> --- a/arch/x86/kvm/mmu/mmu_internal.h
> +++ b/arch/x86/kvm/mmu/mmu_internal.h
> @@ -37,7 +37,6 @@ struct kvm_mmu_page {
>
> bool unsync;
> u8 mmu_valid_gen;
> - bool mmio_cached;
> bool lpage_disallowed; /* Can't be replaced by an equiv large page */
>
> /*
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-06 10:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 14:53 [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page Jia He
2021-09-01 19:57 ` Sean Christopherson
2021-09-06 10:13 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.