All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Qi Liu <liuqi115@huawei.com>
Cc: suzuki.poulose@arm.com, mike.leach@linaro.org,
	coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com
Subject: Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device
Date: Thu, 2 Sep 2021 11:51:37 -0600	[thread overview]
Message-ID: <20210902175137.GC1078000@p14s> (raw)
In-Reply-To: <20210719111737.47891-1-liuqi115@huawei.com>

On Mon, Jul 19, 2021 at 07:17:35PM +0800, Qi Liu wrote:
> This patchset add support for SMB(System Memory Buffer) device, SMB
> obtains CPU instructions from Coresight ETM device and stores these
> messages in system memory.
> SMB is developed by Ultrasoc technology, which is acquired by Siemens,
> and we still use "Ultrasoc" to name document and driver.
> 
> Change since RFC:
> - Move ultrasoc driver to drivers/hwtracing/coresight.
> - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in
>   basic tracing function.
> - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core.
> - Address the comments from Mathieu and Suzuki.
> - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html
> 
> Qi Liu (2):
>   Documentation: tracing: Documentation for ultrasoc SMB drivers
>   coresight: ultrasoc: Add System Memory Buffer driver
> 
>  .../trace/coresight/ultrasoc-trace.rst        | 193 +++++
>  MAINTAINERS                                   |   7 +
>  drivers/hwtracing/coresight/Kconfig           |   3 +
>  drivers/hwtracing/coresight/Makefile          |   2 +
>  drivers/hwtracing/coresight/ultrasoc/Kconfig  |  12 +
>  drivers/hwtracing/coresight/ultrasoc/Makefile |   6 +
>  .../coresight/ultrasoc/ultrasoc-smb.c         | 722 ++++++++++++++++++
>  .../coresight/ultrasoc/ultrasoc-smb.h         | 142 ++++
>  8 files changed, 1087 insertions(+)

I have started to review this set.  Comments will follow shortly.

Thanks,
Mathieu


>  create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst
>  create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig
>  create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile
>  create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c
>  create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h
> 
> -- 
> 2.17.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Qi Liu <liuqi115@huawei.com>
Cc: suzuki.poulose@arm.com, mike.leach@linaro.org,
	coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com
Subject: Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device
Date: Thu, 2 Sep 2021 11:51:37 -0600	[thread overview]
Message-ID: <20210902175137.GC1078000@p14s> (raw)
In-Reply-To: <20210719111737.47891-1-liuqi115@huawei.com>

On Mon, Jul 19, 2021 at 07:17:35PM +0800, Qi Liu wrote:
> This patchset add support for SMB(System Memory Buffer) device, SMB
> obtains CPU instructions from Coresight ETM device and stores these
> messages in system memory.
> SMB is developed by Ultrasoc technology, which is acquired by Siemens,
> and we still use "Ultrasoc" to name document and driver.
> 
> Change since RFC:
> - Move ultrasoc driver to drivers/hwtracing/coresight.
> - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in
>   basic tracing function.
> - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core.
> - Address the comments from Mathieu and Suzuki.
> - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html
> 
> Qi Liu (2):
>   Documentation: tracing: Documentation for ultrasoc SMB drivers
>   coresight: ultrasoc: Add System Memory Buffer driver
> 
>  .../trace/coresight/ultrasoc-trace.rst        | 193 +++++
>  MAINTAINERS                                   |   7 +
>  drivers/hwtracing/coresight/Kconfig           |   3 +
>  drivers/hwtracing/coresight/Makefile          |   2 +
>  drivers/hwtracing/coresight/ultrasoc/Kconfig  |  12 +
>  drivers/hwtracing/coresight/ultrasoc/Makefile |   6 +
>  .../coresight/ultrasoc/ultrasoc-smb.c         | 722 ++++++++++++++++++
>  .../coresight/ultrasoc/ultrasoc-smb.h         | 142 ++++
>  8 files changed, 1087 insertions(+)

I have started to review this set.  Comments will follow shortly.

Thanks,
Mathieu


>  create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst
>  create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig
>  create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile
>  create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c
>  create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h
> 
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-09-02 17:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 11:17 [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device Qi Liu
2021-07-19 11:17 ` Qi Liu
2021-07-19 11:17 ` [PATCH 1/2] Documentation: tracing: Documentation for ultrasoc SMB drivers Qi Liu
2021-07-19 11:17   ` Qi Liu
2021-09-06 17:34   ` Mathieu Poirier
2021-09-06 17:34     ` Mathieu Poirier
2021-09-07  3:32     ` liuqi (BA)
2021-09-07  3:32       ` liuqi (BA)
2021-07-19 11:17 ` [PATCH 2/2] coresight: ultrasoc: Add System Memory Buffer driver Qi Liu
2021-07-19 11:17   ` Qi Liu
2021-09-06 17:30   ` Mathieu Poirier
2021-09-06 17:30     ` Mathieu Poirier
2021-09-07  9:32     ` liuqi (BA)
2021-09-07  9:32       ` liuqi (BA)
2021-08-04  8:05 ` [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device liuqi (BA)
2021-08-04  8:05   ` liuqi (BA)
2021-08-04 14:31   ` Mathieu Poirier
2021-08-04 14:31     ` Mathieu Poirier
2021-08-05  8:01     ` liuqi (BA)
2021-08-05  8:01       ` liuqi (BA)
2021-09-02 17:51 ` Mathieu Poirier [this message]
2021-09-02 17:51   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902175137.GC1078000@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=coresight@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liuqi115@huawei.com \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.