All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Bao Cheng Su <baocheng.su@siemens.com>,
	Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering
Date: Tue, 7 Sep 2021 21:44:42 -0500	[thread overview]
Message-ID: <20210908024442.jskmqqye432p4nmt@gatherer> (raw)
In-Reply-To: <0dce149347353556e38a0bdf9a9489ffc9cf66d2.1631032682.git.jan.kiszka@siemens.com>

On 18:37-20210907, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This ensures that the SD card will remain mmc0 across devices with and
> without eMMC.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> index a9fc1af03f27..785d931a2dd9 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> @@ -31,6 +31,8 @@ aliases {
>  		i2c4 = &main_i2c2;
>  		i2c5 = &main_i2c3;
>  		ethernet0 = &cpsw_port1;
> +		mmc0 = &sdhci1;
> +		mmc1 = &sdhci0;

Jan,

Responding in context of [1]. Suggestion from Aswath is to do the
following instead at SoC level:
+		mmc0 = &sdhci0;
+		mmc1 = &sdhci1;

>  	};
>  
>  	chosen { };
> -- 
> 2.31.1
> 
[1] https://lore.kernel.org/all/4cb6e76e-479f-5e06-778a-4788be53afb9@siemens.com/
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Bao Cheng Su <baocheng.su@siemens.com>,
	Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering
Date: Tue, 7 Sep 2021 21:44:42 -0500	[thread overview]
Message-ID: <20210908024442.jskmqqye432p4nmt@gatherer> (raw)
In-Reply-To: <0dce149347353556e38a0bdf9a9489ffc9cf66d2.1631032682.git.jan.kiszka@siemens.com>

On 18:37-20210907, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This ensures that the SD card will remain mmc0 across devices with and
> without eMMC.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> index a9fc1af03f27..785d931a2dd9 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> @@ -31,6 +31,8 @@ aliases {
>  		i2c4 = &main_i2c2;
>  		i2c5 = &main_i2c3;
>  		ethernet0 = &cpsw_port1;
> +		mmc0 = &sdhci1;
> +		mmc1 = &sdhci0;

Jan,

Responding in context of [1]. Suggestion from Aswath is to do the
following instead at SoC level:
+		mmc0 = &sdhci0;
+		mmc1 = &sdhci1;

>  	};
>  
>  	chosen { };
> -- 
> 2.31.1
> 
[1] https://lore.kernel.org/all/4cb6e76e-479f-5e06-778a-4788be53afb9@siemens.com/
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-08  2:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 16:37 [PATCH v2 0/4] arm64: dts: Update IOT2050 boards Jan Kiszka
2021-09-07 16:37 ` Jan Kiszka
2021-09-07 16:37 ` [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering Jan Kiszka
2021-09-07 16:37   ` Jan Kiszka
2021-09-08  2:44   ` Nishanth Menon [this message]
2021-09-08  2:44     ` Nishanth Menon
2021-09-08  5:25     ` Jan Kiszka
2021-09-08  5:25       ` Jan Kiszka
2021-09-08  5:48       ` Nishanth Menon
2021-09-08  5:48         ` Nishanth Menon
2021-09-08  6:06         ` Jan Kiszka
2021-09-08  6:06           ` Jan Kiszka
2021-09-07 16:38 ` [PATCH v2 2/4] arm64: dts: ti: iot2050: Disable SR2.0-only PRUs Jan Kiszka
2021-09-07 16:38   ` Jan Kiszka
2021-09-07 16:38 ` [PATCH v2 3/4] arm64: dts: ti: iot2050: Prepare for adding 2nd-generation boards Jan Kiszka
2021-09-07 16:38   ` Jan Kiszka
2021-09-07 16:38 ` [PATCH v2 4/4] arm64: dts: ti: iot2050: Add support for product generation 2 boards Jan Kiszka
2021-09-07 16:38   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210908024442.jskmqqye432p4nmt@gatherer \
    --to=nm@ti.com \
    --cc=baocheng.su@siemens.com \
    --cc=chao.zeng@siemens.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.