All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Bao Cheng Su <baocheng.su@siemens.com>,
	Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering
Date: Wed, 8 Sep 2021 08:06:00 +0200	[thread overview]
Message-ID: <448c6afe-0451-9927-8b8a-a9567cc03a92@siemens.com> (raw)
In-Reply-To: <20210908054844.7ym3flo6f2pryd2x@unplug>

On 08.09.21 07:48, Nishanth Menon wrote:
> On 07:25-20210908, Jan Kiszka wrote:
>> On 08.09.21 04:44, Nishanth Menon wrote:
>>> On 18:37-20210907, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> This ensures that the SD card will remain mmc0 across devices with and
>>>> without eMMC.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>> ---
>>>>  arch/arm64/boot/dts/ti/k3-am65.dtsi | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>>> index a9fc1af03f27..785d931a2dd9 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>>> @@ -31,6 +31,8 @@ aliases {
>>>>  		i2c4 = &main_i2c2;
>>>>  		i2c5 = &main_i2c3;
>>>>  		ethernet0 = &cpsw_port1;
>>>> +		mmc0 = &sdhci1;
>>>> +		mmc1 = &sdhci0;
>>>
>>> Jan,
>>>
>>> Responding in context of [1]. Suggestion from Aswath is to do the
>>> following instead at SoC level:
>>> +		mmc0 = &sdhci0;
>>> +		mmc1 = &sdhci1;
>>>
>>
>> Then I will leave this up to you and will go back to v1 of this patch
>> (as we require it the other way around).
> 
> Could you elaborate on the rationale as to why the other way around?
> That would probably provide the reasoning to override the SoC generic
> definitions in the board dts/dtsi as the exception case.
> 

As I wrote in v1: We have deployed devices that use mmcblk0 == SD card
in the field. Those should now be migrated to upstream kernel/DT, but
ideally without glitches in the interface.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Bao Cheng Su <baocheng.su@siemens.com>,
	Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering
Date: Wed, 8 Sep 2021 08:06:00 +0200	[thread overview]
Message-ID: <448c6afe-0451-9927-8b8a-a9567cc03a92@siemens.com> (raw)
In-Reply-To: <20210908054844.7ym3flo6f2pryd2x@unplug>

On 08.09.21 07:48, Nishanth Menon wrote:
> On 07:25-20210908, Jan Kiszka wrote:
>> On 08.09.21 04:44, Nishanth Menon wrote:
>>> On 18:37-20210907, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> This ensures that the SD card will remain mmc0 across devices with and
>>>> without eMMC.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>> ---
>>>>  arch/arm64/boot/dts/ti/k3-am65.dtsi | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>>> index a9fc1af03f27..785d931a2dd9 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>>> @@ -31,6 +31,8 @@ aliases {
>>>>  		i2c4 = &main_i2c2;
>>>>  		i2c5 = &main_i2c3;
>>>>  		ethernet0 = &cpsw_port1;
>>>> +		mmc0 = &sdhci1;
>>>> +		mmc1 = &sdhci0;
>>>
>>> Jan,
>>>
>>> Responding in context of [1]. Suggestion from Aswath is to do the
>>> following instead at SoC level:
>>> +		mmc0 = &sdhci0;
>>> +		mmc1 = &sdhci1;
>>>
>>
>> Then I will leave this up to you and will go back to v1 of this patch
>> (as we require it the other way around).
> 
> Could you elaborate on the rationale as to why the other way around?
> That would probably provide the reasoning to override the SoC generic
> definitions in the board dts/dtsi as the exception case.
> 

As I wrote in v1: We have deployed devices that use mmcblk0 == SD card
in the field. Those should now be migrated to upstream kernel/DT, but
ideally without glitches in the interface.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-08  6:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 16:37 [PATCH v2 0/4] arm64: dts: Update IOT2050 boards Jan Kiszka
2021-09-07 16:37 ` Jan Kiszka
2021-09-07 16:37 ` [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering Jan Kiszka
2021-09-07 16:37   ` Jan Kiszka
2021-09-08  2:44   ` Nishanth Menon
2021-09-08  2:44     ` Nishanth Menon
2021-09-08  5:25     ` Jan Kiszka
2021-09-08  5:25       ` Jan Kiszka
2021-09-08  5:48       ` Nishanth Menon
2021-09-08  5:48         ` Nishanth Menon
2021-09-08  6:06         ` Jan Kiszka [this message]
2021-09-08  6:06           ` Jan Kiszka
2021-09-07 16:38 ` [PATCH v2 2/4] arm64: dts: ti: iot2050: Disable SR2.0-only PRUs Jan Kiszka
2021-09-07 16:38   ` Jan Kiszka
2021-09-07 16:38 ` [PATCH v2 3/4] arm64: dts: ti: iot2050: Prepare for adding 2nd-generation boards Jan Kiszka
2021-09-07 16:38   ` Jan Kiszka
2021-09-07 16:38 ` [PATCH v2 4/4] arm64: dts: ti: iot2050: Add support for product generation 2 boards Jan Kiszka
2021-09-07 16:38   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=448c6afe-0451-9927-8b8a-a9567cc03a92@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=baocheng.su@siemens.com \
    --cc=chao.zeng@siemens.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.