* [PATCH] drm/panel-orientation-quirks: add Valve Steam Deck
@ 2021-09-11 10:24 Simon Ser
2021-09-11 18:54 ` Sam Ravnborg
0 siblings, 1 reply; 4+ messages in thread
From: Simon Ser @ 2021-09-11 10:24 UTC (permalink / raw)
To: dri-devel; +Cc: Jared Baldridge, Emil Velikov, Daniel Vetter, Hans de Goede
Valve's Steam Deck has a 800x1280 LCD screen.
Signed-off-by: Simon Ser <contact@emersion.fr>
Cc: Jared Baldridge <jrb@expunge.us>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Hans de Goede <hdegoede@redhat.com>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index f6bdec7fa925..3018d1dcd271 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -231,6 +231,13 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
},
.driver_data = (void *)&lcd800x1280_rightside_up,
+ }, { /* Valve Steam Deck */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
+ },
+ .driver_data = (void *)&lcd800x1280_rightside_up,
},
{}
};
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel-orientation-quirks: add Valve Steam Deck
2021-09-11 10:24 [PATCH] drm/panel-orientation-quirks: add Valve Steam Deck Simon Ser
@ 2021-09-11 18:54 ` Sam Ravnborg
2021-09-12 13:13 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Sam Ravnborg @ 2021-09-11 18:54 UTC (permalink / raw)
To: Simon Ser
Cc: dri-devel, Jared Baldridge, Emil Velikov, Daniel Vetter, Hans de Goede
Hi Simon,
On Sat, Sep 11, 2021 at 10:24:40AM +0000, Simon Ser wrote:
> Valve's Steam Deck has a 800x1280 LCD screen.
>
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Jared Baldridge <jrb@expunge.us>
> Cc: Emil Velikov <emil.l.velikov@gmail.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Hans de Goede <hdegoede@redhat.com>
The sorting is off - "Valve Steam Deck" comes before "VIOS LTH17"
With the sorting fixed:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
(Not that I know this code, but I wanted to avoid this patch meeting the
same fate as the patch from Hans that was left with no feedback for a
long time).
Sam
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index f6bdec7fa925..3018d1dcd271 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -231,6 +231,13 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
> },
> .driver_data = (void *)&lcd800x1280_rightside_up,
> + }, { /* Valve Steam Deck */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> + },
> + .driver_data = (void *)&lcd800x1280_rightside_up,
> },
> {}
> };
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel-orientation-quirks: add Valve Steam Deck
2021-09-11 18:54 ` Sam Ravnborg
@ 2021-09-12 13:13 ` Hans de Goede
2021-09-12 16:41 ` Simon Ser
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2021-09-12 13:13 UTC (permalink / raw)
To: Sam Ravnborg, Simon Ser
Cc: dri-devel, Jared Baldridge, Emil Velikov, Daniel Vetter
Hi,
On 9/11/21 8:54 PM, Sam Ravnborg wrote:
> Hi Simon,
> On Sat, Sep 11, 2021 at 10:24:40AM +0000, Simon Ser wrote:
>> Valve's Steam Deck has a 800x1280 LCD screen.
>>
>> Signed-off-by: Simon Ser <contact@emersion.fr>
>> Cc: Jared Baldridge <jrb@expunge.us>
>> Cc: Emil Velikov <emil.l.velikov@gmail.com>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>
>
> The sorting is off - "Valve Steam Deck" comes before "VIOS LTH17"
>
> With the sorting fixed:
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> (Not that I know this code, but I wanted to avoid this patch meeting the
> same fate as the patch from Hans that was left with no feedback for a
> long time).
Sam thank you for Ack-ing this, I also notices the ordering
issue and I've fixed this up while applying this.
I'm doing a test-build now and then I will push out the fixed-up
version to drm-misc-next.
Regards,
Hans
>> ---
>> drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> index f6bdec7fa925..3018d1dcd271 100644
>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> @@ -231,6 +231,13 @@ static const struct dmi_system_id orientation_data[] = {
>> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
>> },
>> .driver_data = (void *)&lcd800x1280_rightside_up,
>> + }, { /* Valve Steam Deck */
>> + .matches = {
>> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
>> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
>> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>> + },
>> + .driver_data = (void *)&lcd800x1280_rightside_up,
>> },
>> {}
>> };
>> --
>> 2.33.0
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-12 16:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11 10:24 [PATCH] drm/panel-orientation-quirks: add Valve Steam Deck Simon Ser
2021-09-11 18:54 ` Sam Ravnborg
2021-09-12 13:13 ` Hans de Goede
2021-09-12 16:41 ` Simon Ser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.