* [PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk
@ 2021-09-13 18:14 Julian Sikorski
2021-09-14 8:27 ` Oliver Neukum
2021-09-14 10:21 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Julian Sikorski @ 2021-09-13 18:14 UTC (permalink / raw)
To: linux-usb; +Cc: oneukum, hdegoede, Julian Sikorski
Further testing has revealed that LaCie Rugged USB3-FW does work with
uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.
Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/linux-usb/2167ea48-e273-a336-a4e0-10a4e883e75e@redhat.com/
---
drivers/usb/storage/unusual_uas.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index c35a6db993f1..4051c8cd0cd8 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -50,7 +50,7 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
"LaCie",
"Rugged USB3-FW",
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
- US_FL_IGNORE_UAS),
+ US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
/*
* Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk
2021-09-13 18:14 [PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk Julian Sikorski
@ 2021-09-14 8:27 ` Oliver Neukum
2021-09-14 10:21 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Oliver Neukum @ 2021-09-14 8:27 UTC (permalink / raw)
To: Julian Sikorski, linux-usb; +Cc: oneukum, hdegoede, Julian Sikorski
On 13.09.21 20:14, Julian Sikorski wrote:
> Further testing has revealed that LaCie Rugged USB3-FW does work with
> uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.
>
> Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Link: https://lore.kernel.org/linux-usb/2167ea48-e273-a336-a4e0-10a4e883e75e@redhat.com/
Acked-by: Oliver Neukum <oneukum@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk
2021-09-13 18:14 [PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk Julian Sikorski
2021-09-14 8:27 ` Oliver Neukum
@ 2021-09-14 10:21 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-09-14 10:21 UTC (permalink / raw)
To: Julian Sikorski, linux-usb; +Cc: oneukum, Julian Sikorski
Hi,
On 9/13/21 8:14 PM, Julian Sikorski wrote:
> Further testing has revealed that LaCie Rugged USB3-FW does work with
> uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.
>
> Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Link: https://lore.kernel.org/linux-usb/2167ea48-e273-a336-a4e0-10a4e883e75e@redhat.com/
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/usb/storage/unusual_uas.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index c35a6db993f1..4051c8cd0cd8 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -50,7 +50,7 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
> "LaCie",
> "Rugged USB3-FW",
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> - US_FL_IGNORE_UAS),
> + US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
>
> /*
> * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-14 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 18:14 [PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk Julian Sikorski
2021-09-14 8:27 ` Oliver Neukum
2021-09-14 10:21 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.