[PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk

[PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk

[Julian Sikorski]

Further testing has revealed that LaCie Rugged USB3-FW does work with
uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.

Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/linux-usb/2167ea48-e273-a336-a4e0-10a4e883e75e@redhat.com/
---
 drivers/usb/storage/unusual_uas.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index c35a6db993f1..4051c8cd0cd8 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -50,7 +50,7 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
 		"LaCie",
 		"Rugged USB3-FW",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
-		US_FL_IGNORE_UAS),
+		US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
 
 /*
  * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
-- 
2.31.1

Re: [PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk

[Oliver Neukum]

On 13.09.21 20:14, Julian Sikorski wrote:
> Further testing has revealed that LaCie Rugged USB3-FW does work with
> uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.
>
> Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Link: https://lore.kernel.org/linux-usb/2167ea48-e273-a336-a4e0-10a4e883e75e@redhat.com/
Acked-by: Oliver Neukum <oneukum@suse.com>

Re: [PATCH] Re-enable UAS for LaCie Rugged USB3-FW with fk quirk

[Hans de Goede]

Hi,

On 9/13/21 8:14 PM, Julian Sikorski wrote:
> Further testing has revealed that LaCie Rugged USB3-FW does work with
> uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.
> 
> Signed-off-by: Julian Sikorski <belegdol+github@gmail.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Link: https://lore.kernel.org/linux-usb/2167ea48-e273-a336-a4e0-10a4e883e75e@redhat.com/

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/usb/storage/unusual_uas.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index c35a6db993f1..4051c8cd0cd8 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -50,7 +50,7 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
>  		"LaCie",
>  		"Rugged USB3-FW",
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> -		US_FL_IGNORE_UAS),
> +		US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
>  
>  /*
>   * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
>