All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	kernel test robot <lkp@intel.com>,
	llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error: static_assert expression is not an integral constant expression
Date: Mon, 13 Sep 2021 16:02:46 -0300	[thread overview]
Message-ID: <20210913190246.GA4065468@nvidia.com> (raw)
In-Reply-To: <YT+eJY4JoobVsKWu@archlinux-ax161>

On Mon, Sep 13, 2021 at 11:53:25AM -0700, Nathan Chancellor wrote:
> On Mon, Sep 13, 2021 at 03:38:13PM -0300, Jason Gunthorpe wrote:
> > On Mon, Sep 13, 2021 at 10:00:02AM -0700, Nick Desaulniers wrote:
> > 
> > > > This macro would like to know that the passed in member name has a u64
> > > > type, all the things I've come up with fail on clang - but many work
> > > > fine on gcc. Frankly I think this case is a clang bug myself..
> > > 
> > > Perhaps, though this assertion looks a bit like offsetof() to me. I
> > > wonder if that can help here?
> > 
> > The assertion would logically like to be this:
> > 
> >          static_assert(typecheck(((struct qib_port *)0)->N, u64))
> 
> This works for me with both GCC and clang, if that is acceptable to you?
> It fails if you change one of the variables to 'u32'.

Yes, thanks. Can't say I've even heard of __same_type before :\ would
be nice if this was in typecheck.h along with the other variations of
the same idea. Presumably it is a little bit different from those
somehow?

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: kbuild-all@lists.01.org
Subject: Re: drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error: static_assert expression is not an integral constant expression
Date: Mon, 13 Sep 2021 16:02:46 -0300	[thread overview]
Message-ID: <20210913190246.GA4065468@nvidia.com> (raw)
In-Reply-To: <YT+eJY4JoobVsKWu@archlinux-ax161>

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Mon, Sep 13, 2021 at 11:53:25AM -0700, Nathan Chancellor wrote:
> On Mon, Sep 13, 2021 at 03:38:13PM -0300, Jason Gunthorpe wrote:
> > On Mon, Sep 13, 2021 at 10:00:02AM -0700, Nick Desaulniers wrote:
> > 
> > > > This macro would like to know that the passed in member name has a u64
> > > > type, all the things I've come up with fail on clang - but many work
> > > > fine on gcc. Frankly I think this case is a clang bug myself..
> > > 
> > > Perhaps, though this assertion looks a bit like offsetof() to me. I
> > > wonder if that can help here?
> > 
> > The assertion would logically like to be this:
> > 
> >          static_assert(typecheck(((struct qib_port *)0)->N, u64))
> 
> This works for me with both GCC and clang, if that is acceptable to you?
> It fails if you change one of the variables to 'u32'.

Yes, thanks. Can't say I've even heard of __same_type before :\ would
be nice if this was in typecheck.h along with the other variations of
the same idea. Presumably it is a little bit different from those
somehow?

Jason

  reply	other threads:[~2021-09-13 19:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11 12:17 drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error: static_assert expression is not an integral constant expression kernel test robot
2021-09-11 12:17 ` kernel test robot
2021-09-13 16:53 ` Jason Gunthorpe
2021-09-13 16:53   ` Jason Gunthorpe
2021-09-13 17:00   ` Nick Desaulniers
2021-09-13 17:00     ` Nick Desaulniers
2021-09-13 17:00     ` Nick Desaulniers
2021-09-13 18:38     ` Jason Gunthorpe
2021-09-13 18:38       ` Jason Gunthorpe
2021-09-13 18:53       ` Nathan Chancellor
2021-09-13 18:53         ` Nathan Chancellor
2021-09-13 19:02         ` Jason Gunthorpe [this message]
2021-09-13 19:02           ` Jason Gunthorpe
2021-09-13 19:13           ` Nathan Chancellor
2021-09-13 19:13             ` Nathan Chancellor
2021-09-13 19:16             ` Jason Gunthorpe
2021-09-13 19:16               ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913190246.GA4065468@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.