All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	kernel test robot <lkp@intel.com>,
	llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error: static_assert expression is not an integral constant expression
Date: Mon, 13 Sep 2021 11:53:25 -0700	[thread overview]
Message-ID: <YT+eJY4JoobVsKWu@archlinux-ax161> (raw)
In-Reply-To: <20210913183813.GY2505917@nvidia.com>

On Mon, Sep 13, 2021 at 03:38:13PM -0300, Jason Gunthorpe wrote:
> On Mon, Sep 13, 2021 at 10:00:02AM -0700, Nick Desaulniers wrote:
> 
> > > This macro would like to know that the passed in member name has a u64
> > > type, all the things I've come up with fail on clang - but many work
> > > fine on gcc. Frankly I think this case is a clang bug myself..
> > 
> > Perhaps, though this assertion looks a bit like offsetof() to me. I
> > wonder if that can help here?
> 
> The assertion would logically like to be this:
> 
>          static_assert(typecheck(((struct qib_port *)0)->N, u64))

This works for me with both GCC and clang, if that is acceptable to you?
It fails if you change one of the variables to 'u32'.

Cheers,
Nathan

diff --git a/drivers/infiniband/hw/qib/qib_sysfs.c b/drivers/infiniband/hw/qib/qib_sysfs.c
index 452e2355d24e..0a3b28142c05 100644
--- a/drivers/infiniband/hw/qib/qib_sysfs.c
+++ b/drivers/infiniband/hw/qib/qib_sysfs.c
@@ -403,7 +403,7 @@ static ssize_t diagc_attr_store(struct ib_device *ibdev, u32 port_num,
 }
 
 #define QIB_DIAGC_ATTR(N)                                                      \
-	static_assert(&((struct qib_ibport *)0)->rvp.n_##N != (u64 *)NULL);    \
+	static_assert(__same_type(((struct qib_ibport *)0)->rvp.n_##N, u64));  \
 	static struct qib_diagc_attr qib_diagc_attr_##N = {                    \
 		.attr = __ATTR(N, 0664, diagc_attr_show, diagc_attr_store),    \
 		.counter =                                                     \

WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error: static_assert expression is not an integral constant expression
Date: Mon, 13 Sep 2021 11:53:25 -0700	[thread overview]
Message-ID: <YT+eJY4JoobVsKWu@archlinux-ax161> (raw)
In-Reply-To: <20210913183813.GY2505917@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]

On Mon, Sep 13, 2021 at 03:38:13PM -0300, Jason Gunthorpe wrote:
> On Mon, Sep 13, 2021 at 10:00:02AM -0700, Nick Desaulniers wrote:
> 
> > > This macro would like to know that the passed in member name has a u64
> > > type, all the things I've come up with fail on clang - but many work
> > > fine on gcc. Frankly I think this case is a clang bug myself..
> > 
> > Perhaps, though this assertion looks a bit like offsetof() to me. I
> > wonder if that can help here?
> 
> The assertion would logically like to be this:
> 
>          static_assert(typecheck(((struct qib_port *)0)->N, u64))

This works for me with both GCC and clang, if that is acceptable to you?
It fails if you change one of the variables to 'u32'.

Cheers,
Nathan

diff --git a/drivers/infiniband/hw/qib/qib_sysfs.c b/drivers/infiniband/hw/qib/qib_sysfs.c
index 452e2355d24e..0a3b28142c05 100644
--- a/drivers/infiniband/hw/qib/qib_sysfs.c
+++ b/drivers/infiniband/hw/qib/qib_sysfs.c
@@ -403,7 +403,7 @@ static ssize_t diagc_attr_store(struct ib_device *ibdev, u32 port_num,
 }
 
 #define QIB_DIAGC_ATTR(N)                                                      \
-	static_assert(&((struct qib_ibport *)0)->rvp.n_##N != (u64 *)NULL);    \
+	static_assert(__same_type(((struct qib_ibport *)0)->rvp.n_##N, u64));  \
 	static struct qib_diagc_attr qib_diagc_attr_##N = {                    \
 		.attr = __ATTR(N, 0664, diagc_attr_show, diagc_attr_store),    \
 		.counter =                                                     \

  reply	other threads:[~2021-09-13 18:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11 12:17 drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error: static_assert expression is not an integral constant expression kernel test robot
2021-09-11 12:17 ` kernel test robot
2021-09-13 16:53 ` Jason Gunthorpe
2021-09-13 16:53   ` Jason Gunthorpe
2021-09-13 17:00   ` Nick Desaulniers
2021-09-13 17:00     ` Nick Desaulniers
2021-09-13 17:00     ` Nick Desaulniers
2021-09-13 18:38     ` Jason Gunthorpe
2021-09-13 18:38       ` Jason Gunthorpe
2021-09-13 18:53       ` Nathan Chancellor [this message]
2021-09-13 18:53         ` Nathan Chancellor
2021-09-13 19:02         ` Jason Gunthorpe
2021-09-13 19:02           ` Jason Gunthorpe
2021-09-13 19:13           ` Nathan Chancellor
2021-09-13 19:13             ` Nathan Chancellor
2021-09-13 19:16             ` Jason Gunthorpe
2021-09-13 19:16               ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YT+eJY4JoobVsKWu@archlinux-ax161 \
    --to=nathan@kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=jgg@nvidia.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.