* [Buildroot] [PATCH] package/ffmpeg: fix build on mips_32
@ 2021-09-13 20:45 Giulio Benetti
2021-09-22 20:34 ` Arnout Vandecappelle
0 siblings, 1 reply; 2+ messages in thread
From: Giulio Benetti @ 2021-09-13 20:45 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Giulio Benetti, Mahyar Koshkouei
mips_32 is not supported by ffmpeg and it tries to build with loongson3
SIMD support that leads to build failure due to:
/tmp/ccFO2LRa.s: Assembler messages:
/tmp/ccFO2LRa.s:15314: Error: opcode not supported on this processor: mips32 (mips32) `dmult $2,$6'
/tmp/ccFO2LRa.s:15316: Error: opcode not supported on this processor: mips32 (mips32) `dsrl $2,$2,32'
So let's --disable-asm to prevent using those unsupported opcodes.
Fixes:
http://autobuild.buildroot.net/results/f01/f01d9cedec8e1b371308d0f7af561a75883fa27c/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/ffmpeg/ffmpeg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
index 8ff8ea8c6c..5e405d0f60 100644
--- a/package/ffmpeg/ffmpeg.mk
+++ b/package/ffmpeg/ffmpeg.mk
@@ -508,7 +508,7 @@ FFMPEG_CONF_OPTS += --enable-mipsfpu
endif
# Fix build failure on "addi opcode not supported"
-ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
+ifeq ($(BR2_mips_32)$(BR2_mips_32r6)$(BR2_mips_64r6),y)
FFMPEG_CONF_OPTS += --disable-asm
endif
endif # MIPS
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH] package/ffmpeg: fix build on mips_32
2021-09-13 20:45 [Buildroot] [PATCH] package/ffmpeg: fix build on mips_32 Giulio Benetti
@ 2021-09-22 20:34 ` Arnout Vandecappelle
0 siblings, 0 replies; 2+ messages in thread
From: Arnout Vandecappelle @ 2021-09-22 20:34 UTC (permalink / raw)
To: Giulio Benetti, buildroot; +Cc: Bernd Kuhls, Mahyar Koshkouei
On 13/09/2021 22:45, Giulio Benetti wrote:
> mips_32 is not supported by ffmpeg and it tries to build with loongson3
> SIMD support that leads to build failure due to:
> /tmp/ccFO2LRa.s: Assembler messages:
> /tmp/ccFO2LRa.s:15314: Error: opcode not supported on this processor: mips32 (mips32) `dmult $2,$6'
> /tmp/ccFO2LRa.s:15316: Error: opcode not supported on this processor: mips32 (mips32) `dsrl $2,$2,32'
I don't think *any* of the archs we define in Config.in.mips supports these
instructions... It's just that these are the only ones we test in the autobuilders.
>
> So let's --disable-asm to prevent using those unsupported opcodes.
>
> Fixes:
> http://autobuild.buildroot.net/results/f01/f01d9cedec8e1b371308d0f7af561a75883fa27c/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/ffmpeg/ffmpeg.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
> index 8ff8ea8c6c..5e405d0f60 100644
> --- a/package/ffmpeg/ffmpeg.mk
> +++ b/package/ffmpeg/ffmpeg.mk
> @@ -508,7 +508,7 @@ FFMPEG_CONF_OPTS += --enable-mipsfpu
> endif
>
> # Fix build failure on "addi opcode not supported"
> -ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
> +ifeq ($(BR2_mips_32)$(BR2_mips_32r6)$(BR2_mips_64r6),y)
> FFMPEG_CONF_OPTS += --disable-asm
Given that mips seems so problematic, I think it's best to disable asm on mips
in general, not even for specific subarches.
If someone needs some specific subarch to be optimized, they can give us a
(tested!) patch that enables asm again for that specific subarch.
Regards,
Arnout
> endif
> endif # MIPS
>
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-22 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 20:45 [Buildroot] [PATCH] package/ffmpeg: fix build on mips_32 Giulio Benetti
2021-09-22 20:34 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.