From: Guenter Roeck <linux@roeck-us.net>
To: Adam Borowski <kilobyte@angband.pl>
Cc: "Pali Rohár" <pali@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: (dell-smm) Don't build the proc interface if there's no /proc
Date: Wed, 15 Sep 2021 08:16:13 -0700 [thread overview]
Message-ID: <20210915151613.GA3272120@roeck-us.net> (raw)
In-Reply-To: <20210915143801.43419-1-kilobyte@angband.pl>
On Wed, Sep 15, 2021 at 04:38:01PM +0200, Adam Borowski wrote:
There should be some description here.
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Otherwise, for the content:
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Guenter wrote:
> > > -#if IS_ENABLED(CONFIG_I8K)
> > > +#if IS_ENABLED(CONFIG_I8K) && IS_ENABLED(CONFIG_PROCFS)
>
> > This should be expressed as Kconfig dependency: I8K should depend on PROCFS.
> > Otherwise the configuration flag is misleading.
>
> Right, I did not notice I8K does nothing otherwise.
>
> arch/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 4e001bbbb425..a7365695ff72 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1253,6 +1253,7 @@ config I8K
> tristate "Dell i8k legacy laptop support"
> select HWMON
> select SENSORS_DELL_SMM
> + depends on PROC_FS
> help
> This option enables legacy /proc/i8k userspace interface in hwmon
> dell-smm-hwmon driver. Character file /proc/i8k reports bios version,
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-09-15 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 13:47 [PATCH] hwmon: (dell-smm) Don't build the proc interface if there's no /proc Adam Borowski
2021-09-15 14:20 ` Guenter Roeck
2021-09-15 14:38 ` [PATCH v2] " Adam Borowski
2021-09-15 15:16 ` Guenter Roeck [this message]
2021-09-15 15:17 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915151613.GA3272120@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=kilobyte@angband.pl \
--cc=linux-hwmon@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.