From: Guenter Roeck <linux@roeck-us.net>
To: "Adam Borowski" <kilobyte@angband.pl>,
"Pali Rohár" <pali@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Don't build the proc interface if there's no /proc
Date: Wed, 15 Sep 2021 07:20:15 -0700 [thread overview]
Message-ID: <7a259cc4-69a8-fc0c-e256-5d82b6f1bb35@roeck-us.net> (raw)
In-Reply-To: <20210915134718.55897-1-kilobyte@angband.pl>
On 9/15/21 6:47 AM, Adam Borowski wrote:
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 774c1b0715d9..f381dfe1b427 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -403,7 +403,7 @@ static int __init i8k_get_dell_signature(int req_fn)
> return regs.eax == 1145651527 && regs.edx == 1145392204 ? 0 : -1;
> }
>
> -#if IS_ENABLED(CONFIG_I8K)
> +#if IS_ENABLED(CONFIG_I8K) && IS_ENABLED(CONFIG_PROCFS)
>
This should be expressed as Kconfig dependency: I8K should depend on PROCFS.
Otherwise the configuration flag is misleading.
Guenter
next prev parent reply other threads:[~2021-09-15 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 13:47 [PATCH] hwmon: (dell-smm) Don't build the proc interface if there's no /proc Adam Borowski
2021-09-15 14:20 ` Guenter Roeck [this message]
2021-09-15 14:38 ` [PATCH v2] " Adam Borowski
2021-09-15 15:16 ` Guenter Roeck
2021-09-15 15:17 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a259cc4-69a8-fc0c-e256-5d82b6f1bb35@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=kilobyte@angband.pl \
--cc=linux-hwmon@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.