All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, maz@kernel.org,
	catalin.marinas@arm.com, mark.rutland@arm.com,
	james.morse@arm.com, anshuman.khandual@arm.com,
	leo.yan@linaro.org, mike.leach@linaro.org,
	mathieu.poirier@linaro.org, will@kernel.org,
	lcherian@marvell.com, coresight@lists.linaro.org,
	Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH v2 04/17] coresight: trbe: Add a helper to pad a given buffer area
Date: Tue, 21 Sep 2021 14:41:08 +0100	[thread overview]
Message-ID: <20210921134121.2423546-5-suzuki.poulose@arm.com> (raw)
In-Reply-To: <20210921134121.2423546-1-suzuki.poulose@arm.com>

Refactor the helper to pad a given AUX buffer area to allow
"filling" ignore packets, without moving any handle pointers.
This will be useful in working around errata, where we may
have to fill the buffer after a session.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/hwtracing/coresight/coresight-trbe.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c
index 063c4505a203..a32ef083aa36 100644
--- a/drivers/hwtracing/coresight/coresight-trbe.c
+++ b/drivers/hwtracing/coresight/coresight-trbe.c
@@ -227,12 +227,18 @@ static void trbe_stop_and_truncate_event(struct perf_output_handle *handle)
  * consumed from the user space. The enabled TRBE buffer area is a moving subset of
  * the allocated perf auxiliary buffer.
  */
+
+static void __trbe_pad_buf(struct trbe_buf *buf, u64 offset, int len)
+{
+	memset((void *)buf->trbe_base + offset, ETE_IGNORE_PACKET, len);
+}
+
 static void trbe_pad_buf(struct perf_output_handle *handle, int len)
 {
 	struct trbe_buf *buf = etm_perf_sink_config(handle);
 	u64 head = PERF_IDX2OFF(handle->head, buf);
 
-	memset((void *)buf->trbe_base + head, ETE_IGNORE_PACKET, len);
+	__trbe_pad_buf(buf, head, len);
 	if (!buf->snapshot)
 		perf_aux_output_skip(handle, len);
 }
-- 
2.24.1


WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, maz@kernel.org,
	catalin.marinas@arm.com, mark.rutland@arm.com,
	james.morse@arm.com, anshuman.khandual@arm.com,
	leo.yan@linaro.org, mike.leach@linaro.org,
	mathieu.poirier@linaro.org, will@kernel.org,
	lcherian@marvell.com, coresight@lists.linaro.org,
	Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH v2 04/17] coresight: trbe: Add a helper to pad a given buffer area
Date: Tue, 21 Sep 2021 14:41:08 +0100	[thread overview]
Message-ID: <20210921134121.2423546-5-suzuki.poulose@arm.com> (raw)
In-Reply-To: <20210921134121.2423546-1-suzuki.poulose@arm.com>

Refactor the helper to pad a given AUX buffer area to allow
"filling" ignore packets, without moving any handle pointers.
This will be useful in working around errata, where we may
have to fill the buffer after a session.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/hwtracing/coresight/coresight-trbe.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c
index 063c4505a203..a32ef083aa36 100644
--- a/drivers/hwtracing/coresight/coresight-trbe.c
+++ b/drivers/hwtracing/coresight/coresight-trbe.c
@@ -227,12 +227,18 @@ static void trbe_stop_and_truncate_event(struct perf_output_handle *handle)
  * consumed from the user space. The enabled TRBE buffer area is a moving subset of
  * the allocated perf auxiliary buffer.
  */
+
+static void __trbe_pad_buf(struct trbe_buf *buf, u64 offset, int len)
+{
+	memset((void *)buf->trbe_base + offset, ETE_IGNORE_PACKET, len);
+}
+
 static void trbe_pad_buf(struct perf_output_handle *handle, int len)
 {
 	struct trbe_buf *buf = etm_perf_sink_config(handle);
 	u64 head = PERF_IDX2OFF(handle->head, buf);
 
-	memset((void *)buf->trbe_base + head, ETE_IGNORE_PACKET, len);
+	__trbe_pad_buf(buf, head, len);
 	if (!buf->snapshot)
 		perf_aux_output_skip(handle, len);
 }
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-09-21 13:41 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21 13:41 [PATCH v2 00/17] arm64: Self-hosted trace related errata workarounds Suzuki K Poulose
2021-09-21 13:41 ` Suzuki K Poulose
2021-09-21 13:41 ` [PATCH v2 01/17] coresight: trbe: Fix incorrect access of the sink specific data Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22  5:41   ` Anshuman Khandual
2021-09-22  5:41     ` Anshuman Khandual
2021-09-30 17:57   ` Mathieu Poirier
2021-09-30 17:57     ` Mathieu Poirier
2021-09-21 13:41 ` [PATCH v2 02/17] coresight: trbe: Add infrastructure for Errata handling Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22  6:47   ` Anshuman Khandual
2021-09-22  6:47     ` Anshuman Khandual
2021-10-05 16:46   ` Mathieu Poirier
2021-10-05 16:46     ` Mathieu Poirier
2021-09-21 13:41 ` [PATCH v2 03/17] coresight: trbe: Add a helper to calculate the trace generated Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-30 17:54   ` Mathieu Poirier
2021-09-30 17:54     ` Mathieu Poirier
2021-10-01  8:36     ` Suzuki K Poulose
2021-10-01  8:36       ` Suzuki K Poulose
2021-10-01 15:15       ` Mathieu Poirier
2021-10-01 15:15         ` Mathieu Poirier
2021-10-01 15:22         ` Suzuki K Poulose
2021-10-01 15:22           ` Suzuki K Poulose
2021-09-21 13:41 ` Suzuki K Poulose [this message]
2021-09-21 13:41   ` [PATCH v2 04/17] coresight: trbe: Add a helper to pad a given buffer area Suzuki K Poulose
2021-09-21 13:41 ` [PATCH v2 05/17] coresight: trbe: Decouple buffer base from the hardware base Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-21 13:41 ` [PATCH v2 06/17] coresight: trbe: Allow driver to choose a different alignment Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-21 13:41 ` [PATCH v2 07/17] arm64: Add Neoverse-N2, Cortex-A710 CPU part definition Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22  6:57   ` Anshuman Khandual
2021-09-22  6:57     ` Anshuman Khandual
2021-09-21 13:41 ` [PATCH v2 08/17] arm64: Add erratum detection for TRBE overwrite in FILL mode Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-21 13:41 ` [PATCH v2 09/17] coresight: trbe: Workaround TRBE errata " Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-23  6:13   ` Anshuman Khandual
2021-09-23  6:13     ` Anshuman Khandual
2021-09-28 10:40     ` Suzuki K Poulose
2021-09-28 10:40       ` Suzuki K Poulose
2021-10-01  4:21       ` Anshuman Khandual
2021-10-01  4:21         ` Anshuman Khandual
2021-10-01 17:15   ` Mathieu Poirier
2021-10-01 17:15     ` Mathieu Poirier
2021-10-04  8:46     ` Suzuki K Poulose
2021-10-04  8:46       ` Suzuki K Poulose
2021-10-04 16:47       ` Mathieu Poirier
2021-10-04 16:47         ` Mathieu Poirier
2021-09-21 13:41 ` [PATCH v2 10/17] arm64: Enable workaround for TRBE " Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22  7:23   ` Anshuman Khandual
2021-09-22  7:23     ` Anshuman Khandual
2021-09-22  8:11     ` Suzuki K Poulose
2021-09-22  8:11       ` Suzuki K Poulose
2021-10-01  4:35       ` Anshuman Khandual
2021-10-01  4:35         ` Anshuman Khandual
2021-10-07 16:09   ` Catalin Marinas
2021-10-07 16:09     ` Catalin Marinas
2021-09-21 13:41 ` [PATCH v2 11/17] arm64: errata: Add workaround for TSB flush failures Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22  7:39   ` Anshuman Khandual
2021-09-22  7:39     ` Anshuman Khandual
2021-09-22 12:03     ` Suzuki K Poulose
2021-09-22 12:03       ` Suzuki K Poulose
2021-10-01  4:38       ` Anshuman Khandual
2021-10-01  4:38         ` Anshuman Khandual
2021-10-07 16:10   ` Catalin Marinas
2021-10-07 16:10     ` Catalin Marinas
2021-09-21 13:41 ` [PATCH v2 12/17] coresight: trbe: Add a helper to fetch cpudata from perf handle Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22  7:59   ` Anshuman Khandual
2021-09-22  7:59     ` Anshuman Khandual
2021-10-04 17:42   ` Mathieu Poirier
2021-10-04 17:42     ` Mathieu Poirier
2021-10-05 22:35     ` Suzuki K Poulose
2021-10-05 22:35       ` Suzuki K Poulose
2021-10-06 17:15       ` Mathieu Poirier
2021-10-06 17:15         ` Mathieu Poirier
2021-10-07  9:18         ` Suzuki K Poulose
2021-10-07  9:18           ` Suzuki K Poulose
2021-09-21 13:41 ` [PATCH v2 13/17] coresight: trbe: Add a helper to determine the minimum buffer size Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22  9:51   ` Anshuman Khandual
2021-09-22  9:51     ` Anshuman Khandual
2021-09-21 13:41 ` [PATCH v2 14/17] coresight: trbe: Make sure we have enough space Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22  9:58   ` Anshuman Khandual
2021-09-22  9:58     ` Anshuman Khandual
2021-09-22 10:16     ` Suzuki K Poulose
2021-09-22 10:16       ` Suzuki K Poulose
2021-10-01  4:40       ` Anshuman Khandual
2021-10-01  4:40         ` Anshuman Khandual
2021-09-21 13:41 ` [PATCH v2 15/17] arm64: Add erratum detection for TRBE write to out-of-range Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22 10:59   ` Anshuman Khandual
2021-09-22 10:59     ` Anshuman Khandual
2021-10-07 16:10   ` Catalin Marinas
2021-10-07 16:10     ` Catalin Marinas
2021-09-21 13:41 ` [PATCH v2 16/17] coresight: trbe: Work around write to out of range Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-23  3:15   ` Anshuman Khandual
2021-09-23  3:15     ` Anshuman Khandual
2021-09-28 10:32     ` Suzuki K Poulose
2021-09-28 10:32       ` Suzuki K Poulose
2021-10-01  4:56       ` Anshuman Khandual
2021-10-01  4:56         ` Anshuman Khandual
2021-09-21 13:41 ` [PATCH v2 17/17] arm64: Advertise TRBE erratum workaround for write to out-of-range address Suzuki K Poulose
2021-09-21 13:41   ` Suzuki K Poulose
2021-09-22 11:03   ` Anshuman Khandual
2021-09-22 11:03     ` Anshuman Khandual
2021-10-07 16:11   ` Catalin Marinas
2021-10-07 16:11     ` Catalin Marinas
2021-10-05 17:04 ` [PATCH v2 00/17] arm64: Self-hosted trace related errata workarounds Mathieu Poirier
2021-10-05 17:04   ` Mathieu Poirier
2021-10-08  7:32 ` Will Deacon
2021-10-08  7:32   ` Will Deacon
2021-10-08  9:25   ` Suzuki K Poulose
2021-10-08  9:25     ` Suzuki K Poulose
2021-10-08  9:52     ` Will Deacon
2021-10-08  9:52       ` Will Deacon
2021-10-08  9:57       ` Suzuki K Poulose
2021-10-08  9:57         ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210921134121.2423546-5-suzuki.poulose@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=james.morse@arm.com \
    --cc=lcherian@marvell.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=maz@kernel.org \
    --cc=mike.leach@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.