[Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host

[Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host

[Fabrice Fontaine]

Make a standard install (i.e. with pvcreate) for host as it is needed
for libvirt

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/lvm2/lvm2.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 3a94aebfd4..d918b5f5b6 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -72,8 +72,7 @@ HOST_LVM2_CONF_OPTS = \
 	--disable-fsadm \
 	--disable-readline \
 	--disable-selinux
-HOST_LVM2_MAKE_OPTS = device-mapper
-HOST_LVM2_INSTALL_OPTS = install_device-mapper
+HOST_LVM2_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/libvirt: add host-lvm2 dependency

[Fabrice Fontaine]

host-lvm2 is needed to avoid the following build failure raised since
the addition of the package in commit
ccfc90e1010e42e6529afae3a5ea8bf7226dabc1:

Program pvcreate found: NO

../output-1/build/libvirt-7.7.0/meson.build:1888:6: ERROR: Program 'pvcreate' not found

Fixes:
 - http://autobuild.buildroot.org/results/13c12086a0ce06c348d5971b56b5f4f27fa0f317

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libvirt/libvirt.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libvirt/libvirt.mk b/package/libvirt/libvirt.mk
index 0f6c7cef7f..3118de4d58 100644
--- a/package/libvirt/libvirt.mk
+++ b/package/libvirt/libvirt.mk
@@ -180,7 +180,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_LVM2_STANDARD_INSTALL),y)
 LIBVIRT_CONF_OPTS += -Dstorage_lvm=enabled
-LIBVIRT_DEPENDENCIES += lvm2
+LIBVIRT_DEPENDENCIES += host-lvm2 lvm2
 else
 LIBVIRT_CONF_OPTS += -Dstorage_lvm=disabled
 endif
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host

[Yann E. MORIN]

Fabrice, All,

On 2021-09-24 23:39 +0200, Fabrice Fontaine spake thusly:
> Make a standard install (i.e. with pvcreate) for host as it is needed
> for libvirt
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/lvm2/lvm2.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 3a94aebfd4..d918b5f5b6 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -72,8 +72,7 @@ HOST_LVM2_CONF_OPTS = \
>  	--disable-fsadm \
>  	--disable-readline \
>  	--disable-selinux
> -HOST_LVM2_MAKE_OPTS = device-mapper
> -HOST_LVM2_INSTALL_OPTS = install_device-mapper
> +HOST_LVM2_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install

DESTDIR must not be used for host variants.

Indeed, they are already configured with --prefix=$(HOST_DIR) :
    https://git.buildroot.org/buildroot/tree/package/pkg-autotools.mk#n223

And DESTDIR is for out-of-tree installation, but for host packages we do
not install out-of-tree as their prefix is already correct.
    https://www.gnu.org/software/automake/manual/automake.html#DESTDIR

If the install fails because of things installed in /etc and such, then
appropriate --sysconfdir=$(HOST_DIR)/etc et al. should be specified
instead. Or maybe we only need 'make install-exec' ?

Regards,
Yann E. MORIN.

>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host

[Yann E. MORIN]

Fabrice, All,

On 2021-09-25 08:32 +0200, Yann E. MORIN spake thusly:
> On 2021-09-24 23:39 +0200, Fabrice Fontaine spake thusly:
> > Make a standard install (i.e. with pvcreate) for host as it is needed
> > for libvirt
> > 
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/lvm2/lvm2.mk | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> > index 3a94aebfd4..d918b5f5b6 100644
> > --- a/package/lvm2/lvm2.mk
> > +++ b/package/lvm2/lvm2.mk
> > @@ -72,8 +72,7 @@ HOST_LVM2_CONF_OPTS = \
> >  	--disable-fsadm \
> >  	--disable-readline \
> >  	--disable-selinux
> > -HOST_LVM2_MAKE_OPTS = device-mapper
> > -HOST_LVM2_INSTALL_OPTS = install_device-mapper
> > +HOST_LVM2_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install
> 
> DESTDIR must not be used for host variants.
> 
> Indeed, they are already configured with --prefix=$(HOST_DIR) :
>     https://git.buildroot.org/buildroot/tree/package/pkg-autotools.mk#n223
> 
> And DESTDIR is for out-of-tree installation, but for host packages we do
> not install out-of-tree as their prefix is already correct.
>     https://www.gnu.org/software/automake/manual/automake.html#DESTDIR
> 
> If the install fails because of things installed in /etc and such, then
> appropriate --sysconfdir=$(HOST_DIR)/etc et al. should be specified
> instead. Or maybe we only need 'make install-exec' ?

lvm2 does not support install-exec... :-/

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host

[Fabrice Fontaine]

Yann,

Le sam. 25 sept. 2021 à 08:49, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
>
> Fabrice, All,
>
> On 2021-09-25 08:32 +0200, Yann E. MORIN spake thusly:
> > On 2021-09-24 23:39 +0200, Fabrice Fontaine spake thusly:
> > > Make a standard install (i.e. with pvcreate) for host as it is needed
> > > for libvirt
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > > ---
> > >  package/lvm2/lvm2.mk | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> > > index 3a94aebfd4..d918b5f5b6 100644
> > > --- a/package/lvm2/lvm2.mk
> > > +++ b/package/lvm2/lvm2.mk
> > > @@ -72,8 +72,7 @@ HOST_LVM2_CONF_OPTS = \
> > >     --disable-fsadm \
> > >     --disable-readline \
> > >     --disable-selinux
> > > -HOST_LVM2_MAKE_OPTS = device-mapper
> > > -HOST_LVM2_INSTALL_OPTS = install_device-mapper
> > > +HOST_LVM2_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install
> >
> > DESTDIR must not be used for host variants.
> >
> > Indeed, they are already configured with --prefix=$(HOST_DIR) :
> >     https://git.buildroot.org/buildroot/tree/package/pkg-autotools.mk#n223
> >
> > And DESTDIR is for out-of-tree installation, but for host packages we do
> > not install out-of-tree as their prefix is already correct.
> >     https://www.gnu.org/software/automake/manual/automake.html#DESTDIR
> >
> > If the install fails because of things installed in /etc and such, then
> > appropriate --sysconfdir=$(HOST_DIR)/etc et al. should be specified
> > instead. Or maybe we only need 'make install-exec' ?
>
> lvm2 does not support install-exec... :-/
Thanks for your review, I'll send a v2 which will use --with-confdir.
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot