* [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host
@ 2021-09-26 20:34 Fabrice Fontaine
2021-09-26 20:34 ` [Buildroot] [PATCH v3, 2/2] package/libvirt: add host-lvm2 dependency Fabrice Fontaine
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2021-09-26 20:34 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine, Jared Bents
Use the standard install for the host, so e.g. pvcreate is installed as
well. pvcreate is needed for libvirt.
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v2 -> v3 (after review of Arnout Vandecappelle):
- Update commit message and drop HOST_LVM2_INSTALL_OPTS
Changes v1 -> v2 (after review of Yann E. Morin):
- Use --with-confdir instead of DESTDIR
package/lvm2/lvm2.mk | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 3a94aebfd4..70da10696c 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -71,9 +71,8 @@ HOST_LVM2_CONF_OPTS = \
--disable-dmeventd \
--disable-fsadm \
--disable-readline \
- --disable-selinux
-HOST_LVM2_MAKE_OPTS = device-mapper
-HOST_LVM2_INSTALL_OPTS = install_device-mapper
+ --disable-selinux \
+ --with-confdir=$(HOST_DIR)/etc
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v3, 2/2] package/libvirt: add host-lvm2 dependency
2021-09-26 20:34 [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Fabrice Fontaine
@ 2021-09-26 20:34 ` Fabrice Fontaine
2021-10-06 14:18 ` Peter Korsgaard
2021-09-27 14:35 ` [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Arnout Vandecappelle
2021-10-06 14:17 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2021-09-26 20:34 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine, Jared Bents
host-lvm2 is needed to avoid the following build failure raised since
the addition of the package in commit
ccfc90e1010e42e6529afae3a5ea8bf7226dabc1:
Program pvcreate found: NO
../output-1/build/libvirt-7.7.0/meson.build:1888:6: ERROR: Program 'pvcreate' not found
Fixes:
- http://autobuild.buildroot.org/results/13c12086a0ce06c348d5971b56b5f4f27fa0f317
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libvirt/libvirt.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libvirt/libvirt.mk b/package/libvirt/libvirt.mk
index 0f6c7cef7f..3118de4d58 100644
--- a/package/libvirt/libvirt.mk
+++ b/package/libvirt/libvirt.mk
@@ -180,7 +180,7 @@ endif
ifeq ($(BR2_PACKAGE_LVM2_STANDARD_INSTALL),y)
LIBVIRT_CONF_OPTS += -Dstorage_lvm=enabled
-LIBVIRT_DEPENDENCIES += lvm2
+LIBVIRT_DEPENDENCIES += host-lvm2 lvm2
else
LIBVIRT_CONF_OPTS += -Dstorage_lvm=disabled
endif
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host
2021-09-26 20:34 [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Fabrice Fontaine
2021-09-26 20:34 ` [Buildroot] [PATCH v3, 2/2] package/libvirt: add host-lvm2 dependency Fabrice Fontaine
@ 2021-09-27 14:35 ` Arnout Vandecappelle
2021-10-06 14:17 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-09-27 14:35 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Jared Bents
On 26/09/2021 22:34, Fabrice Fontaine wrote:
> Use the standard install for the host, so e.g. pvcreate is installed as
> well. pvcreate is needed for libvirt.
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Both applied ot master, thanks.
Regards,
Arnout
> ---
> Changes v2 -> v3 (after review of Arnout Vandecappelle):
> - Update commit message and drop HOST_LVM2_INSTALL_OPTS
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Use --with-confdir instead of DESTDIR
>
> package/lvm2/lvm2.mk | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 3a94aebfd4..70da10696c 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -71,9 +71,8 @@ HOST_LVM2_CONF_OPTS = \
> --disable-dmeventd \
> --disable-fsadm \
> --disable-readline \
> - --disable-selinux
> -HOST_LVM2_MAKE_OPTS = device-mapper
> -HOST_LVM2_INSTALL_OPTS = install_device-mapper
> + --disable-selinux \
> + --with-confdir=$(HOST_DIR)/etc
>
> $(eval $(autotools-package))
> $(eval $(host-autotools-package))
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host
2021-09-26 20:34 [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Fabrice Fontaine
2021-09-26 20:34 ` [Buildroot] [PATCH v3, 2/2] package/libvirt: add host-lvm2 dependency Fabrice Fontaine
2021-09-27 14:35 ` [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Arnout Vandecappelle
@ 2021-10-06 14:17 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2021-10-06 14:17 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Jared Bents, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Use the standard install for the host, so e.g. pvcreate is installed as
> well. pvcreate is needed for libvirt.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Arnout Vandecappelle):
> - Update commit message and drop HOST_LVM2_INSTALL_OPTS
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Use --with-confdir instead of DESTDIR
Committed to 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-06 14:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-26 20:34 [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Fabrice Fontaine
2021-09-26 20:34 ` [Buildroot] [PATCH v3, 2/2] package/libvirt: add host-lvm2 dependency Fabrice Fontaine
2021-10-06 14:18 ` Peter Korsgaard
2021-09-27 14:35 ` [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Arnout Vandecappelle
2021-10-06 14:17 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.