From: Mark Brown <broonie@kernel.org>
To: Simon Trimmer <simont@opensource.cirrus.com>
Cc: lgirdwood@gmail.com, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ASoC: wm_adsp: Fix compilation when debugfs is disabled
Date: Wed, 29 Sep 2021 15:52:22 +0100 [thread overview]
Message-ID: <20210929145222.GR4199@sirena.org.uk> (raw)
In-Reply-To: <20210929145040.793252-1-simont@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On Wed, Sep 29, 2021 at 03:50:40PM +0100, Simon Trimmer wrote:
> +#if IS_ENABLED(CONFIG_DEBUG_FS)
> cs_dsp_init_debugfs(&dsp->cs_dsp, component->debugfs_root);
> +#endif
The more common pattern is to declare a static inline stub function
instead of the prototype if debugfs is disabled.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Simon Trimmer <simont@opensource.cirrus.com>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
kernel test robot <lkp@intel.com>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm_adsp: Fix compilation when debugfs is disabled
Date: Wed, 29 Sep 2021 15:52:22 +0100 [thread overview]
Message-ID: <20210929145222.GR4199@sirena.org.uk> (raw)
In-Reply-To: <20210929145040.793252-1-simont@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On Wed, Sep 29, 2021 at 03:50:40PM +0100, Simon Trimmer wrote:
> +#if IS_ENABLED(CONFIG_DEBUG_FS)
> cs_dsp_init_debugfs(&dsp->cs_dsp, component->debugfs_root);
> +#endif
The more common pattern is to declare a static inline stub function
instead of the prototype if debugfs is disabled.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-29 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 14:50 [PATCH] ASoC: wm_adsp: Fix compilation when debugfs is disabled Simon Trimmer
2021-09-29 14:50 ` Simon Trimmer
2021-09-29 14:52 ` Mark Brown [this message]
2021-09-29 14:52 ` Mark Brown
2021-09-29 15:27 ` Simon Trimmer
2021-09-29 15:27 ` Simon Trimmer
2021-09-29 20:35 ` Mark Brown
2021-09-29 20:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929145222.GR4199@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=patches@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.