From: "Michael S. Tsirkin" <mst@redhat.com> To: Cornelia Huck <cohuck@redhat.com> Cc: Halil Pasic <pasic@linux.ibm.com>, Jason Wang <jasowang@redhat.com>, Xie Yongji <xieyongji@bytedance.com>, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, markver@us.ibm.com, Christian Borntraeger <borntraeger@de.ibm.com>, linux-s390@vger.kernel.org Subject: Re: [RFC PATCH 1/1] virtio: write back features before verify Date: Sat, 2 Oct 2021 14:13:37 -0400 [thread overview] Message-ID: <20211002082128-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <87v92g3h9l.fsf@redhat.com> On Fri, Oct 01, 2021 at 05:18:46PM +0200, Cornelia Huck wrote: > I'd say we need a hack here so that we assume little-endian config space > if VERSION_1 has been offered; if your patch here works, I assume QEMU > does what we expect (assmuming little-endian as well.) I'm mostly > wondering what happens if you use a different VMM; can we expect it to > work similar to QEMU? Hard to say of course ... hopefully other VMMs are actually implementing the spec. E.g. IIUC rust vmm is modern only. > Even if it helps for s390, we should double-check > what happens for other architectures. > > > > >> > >> Anyone have any better suggestions? > >> > > > > There is the conditional compile, as an option but I would not say it is > > better. > > Yes, I agree. > > Anyone else have an idea? This is a nasty regression; we could revert the > patch, which would remove the symptoms and give us some time, but that > doesn't really feel right, I'd do that only as a last resort. Well we have Halil's hack (except I would limit it to only apply to BE, only do devices with validate, and only in modern mode), and we will fix QEMU to be spec compliant. Between these why do we need any conditional compiles? -- MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Cornelia Huck <cohuck@redhat.com> Cc: linux-s390@vger.kernel.org, markver@us.ibm.com, Christian Borntraeger <borntraeger@de.ibm.com>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Halil Pasic <pasic@linux.ibm.com>, Xie Yongji <xieyongji@bytedance.com> Subject: Re: [RFC PATCH 1/1] virtio: write back features before verify Date: Sat, 2 Oct 2021 14:13:37 -0400 [thread overview] Message-ID: <20211002082128-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <87v92g3h9l.fsf@redhat.com> On Fri, Oct 01, 2021 at 05:18:46PM +0200, Cornelia Huck wrote: > I'd say we need a hack here so that we assume little-endian config space > if VERSION_1 has been offered; if your patch here works, I assume QEMU > does what we expect (assmuming little-endian as well.) I'm mostly > wondering what happens if you use a different VMM; can we expect it to > work similar to QEMU? Hard to say of course ... hopefully other VMMs are actually implementing the spec. E.g. IIUC rust vmm is modern only. > Even if it helps for s390, we should double-check > what happens for other architectures. > > > > >> > >> Anyone have any better suggestions? > >> > > > > There is the conditional compile, as an option but I would not say it is > > better. > > Yes, I agree. > > Anyone else have an idea? This is a nasty regression; we could revert the > patch, which would remove the symptoms and give us some time, but that > doesn't really feel right, I'd do that only as a last resort. Well we have Halil's hack (except I would limit it to only apply to BE, only do devices with validate, and only in modern mode), and we will fix QEMU to be spec compliant. Between these why do we need any conditional compiles? -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-10-02 18:13 UTC|newest] Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-30 1:20 [RFC PATCH 1/1] virtio: write back features before verify Halil Pasic 2021-09-30 1:20 ` Halil Pasic 2021-09-30 8:04 ` Christian Borntraeger 2021-09-30 8:04 ` Christian Borntraeger 2021-09-30 9:28 ` Cornelia Huck 2021-09-30 9:28 ` Cornelia Huck 2021-09-30 11:03 ` Halil Pasic 2021-09-30 11:03 ` Halil Pasic 2021-09-30 11:31 ` Cornelia Huck 2021-09-30 11:31 ` Cornelia Huck 2021-10-01 14:22 ` Halil Pasic 2021-10-01 14:22 ` Halil Pasic 2021-10-01 15:18 ` Cornelia Huck 2021-10-01 15:18 ` Cornelia Huck 2021-10-02 18:13 ` Michael S. Tsirkin [this message] 2021-10-02 18:13 ` Michael S. Tsirkin 2021-10-04 2:23 ` Halil Pasic 2021-10-04 2:23 ` Halil Pasic 2021-10-04 9:07 ` Michael S. Tsirkin 2021-10-04 9:07 ` Michael S. Tsirkin 2021-10-04 9:07 ` Michael S. Tsirkin 2021-10-05 10:06 ` Cornelia Huck 2021-10-05 10:06 ` Cornelia Huck 2021-10-05 10:06 ` Cornelia Huck 2021-10-05 10:43 ` Halil Pasic 2021-10-05 10:43 ` Halil Pasic 2021-10-05 10:43 ` Halil Pasic 2021-10-05 11:11 ` Michael S. Tsirkin 2021-10-05 11:11 ` Michael S. Tsirkin 2021-10-05 11:11 ` Michael S. Tsirkin 2021-10-05 11:13 ` Cornelia Huck 2021-10-05 11:13 ` Cornelia Huck 2021-10-05 11:13 ` Cornelia Huck 2021-10-05 11:20 ` Michael S. Tsirkin 2021-10-05 11:20 ` Michael S. Tsirkin 2021-10-05 11:20 ` Michael S. Tsirkin 2021-10-05 11:59 ` Halil Pasic 2021-10-05 11:59 ` Halil Pasic 2021-10-05 11:59 ` Halil Pasic 2021-10-05 15:25 ` Cornelia Huck 2021-10-05 15:25 ` Cornelia Huck 2021-10-05 15:25 ` Cornelia Huck 2021-10-04 7:01 ` Cornelia Huck 2021-10-04 7:01 ` Cornelia Huck 2021-10-04 9:25 ` Halil Pasic 2021-10-04 9:25 ` Halil Pasic 2021-10-04 9:51 ` Cornelia Huck 2021-10-04 9:51 ` Cornelia Huck 2021-10-02 12:09 ` Michael S. Tsirkin 2021-10-02 12:09 ` Michael S. Tsirkin 2021-09-30 11:12 ` Michael S. Tsirkin 2021-09-30 11:12 ` Michael S. Tsirkin 2021-09-30 11:36 ` Cornelia Huck 2021-09-30 11:36 ` Cornelia Huck 2021-10-02 18:20 ` Michael S. Tsirkin 2021-10-02 18:20 ` Michael S. Tsirkin 2021-10-03 5:00 ` Halil Pasic 2021-10-03 5:00 ` Halil Pasic 2021-10-03 6:42 ` Michael S. Tsirkin 2021-10-03 6:42 ` Michael S. Tsirkin 2021-10-03 7:26 ` Michael S. Tsirkin 2021-10-03 7:26 ` Michael S. Tsirkin 2021-10-04 12:01 ` Cornelia Huck 2021-10-04 12:01 ` [virtio-dev] " Cornelia Huck 2021-10-04 12:01 ` Cornelia Huck 2021-10-04 12:54 ` Michael S. Tsirkin 2021-10-04 12:54 ` Michael S. Tsirkin 2021-10-04 14:27 ` Cornelia Huck 2021-10-04 14:27 ` [virtio-dev] " Cornelia Huck 2021-10-04 14:27 ` Cornelia Huck 2021-10-04 15:05 ` Michael S. Tsirkin 2021-10-04 15:05 ` [virtio-dev] " Michael S. Tsirkin 2021-10-04 15:05 ` Michael S. Tsirkin 2021-10-04 15:45 ` [virtio-dev] " Cornelia Huck 2021-10-04 15:45 ` Cornelia Huck 2021-10-04 15:45 ` Cornelia Huck 2021-10-04 20:01 ` Michael S. Tsirkin 2021-10-04 20:01 ` Michael S. Tsirkin 2021-10-05 7:38 ` Cornelia Huck 2021-10-05 7:38 ` Cornelia Huck 2021-10-05 7:38 ` Cornelia Huck 2021-10-05 11:17 ` Halil Pasic 2021-10-05 11:17 ` Halil Pasic 2021-10-05 11:22 ` Michael S. Tsirkin 2021-10-05 11:22 ` Michael S. Tsirkin 2021-10-05 15:20 ` Cornelia Huck 2021-10-05 15:20 ` Cornelia Huck 2021-10-05 15:20 ` Cornelia Huck 2021-10-05 15:20 ` Cornelia Huck 2021-10-01 7:21 ` Halil Pasic 2021-10-01 7:21 ` Halil Pasic 2021-10-02 10:21 ` Michael S. Tsirkin 2021-10-02 10:21 ` Michael S. Tsirkin 2021-10-04 12:19 ` Cornelia Huck 2021-10-04 12:19 ` Cornelia Huck 2021-10-04 12:19 ` Cornelia Huck 2021-10-04 13:11 ` Michael S. Tsirkin 2021-10-04 13:11 ` Michael S. Tsirkin 2021-10-04 13:11 ` Michael S. Tsirkin 2021-10-04 14:33 ` Cornelia Huck 2021-10-04 14:33 ` Cornelia Huck 2021-10-04 14:33 ` Cornelia Huck 2021-10-04 15:07 ` Michael S. Tsirkin 2021-10-04 15:07 ` Michael S. Tsirkin 2021-10-04 15:07 ` Michael S. Tsirkin 2021-10-04 15:50 ` Cornelia Huck 2021-10-04 15:50 ` Cornelia Huck 2021-10-04 15:50 ` Cornelia Huck 2021-10-04 19:17 ` Michael S. Tsirkin 2021-10-04 19:17 ` Michael S. Tsirkin 2021-10-04 19:17 ` Michael S. Tsirkin 2021-10-06 10:13 ` Cornelia Huck 2021-10-06 10:13 ` Cornelia Huck 2021-10-06 10:13 ` Cornelia Huck 2021-10-06 12:15 ` Michael S. Tsirkin 2021-10-06 12:15 ` Michael S. Tsirkin 2021-10-06 12:15 ` Michael S. Tsirkin 2021-10-05 7:25 ` Halil Pasic 2021-10-05 7:25 ` Halil Pasic 2021-10-05 7:25 ` Halil Pasic 2021-10-05 7:53 ` Michael S. Tsirkin 2021-10-05 7:53 ` Michael S. Tsirkin 2021-10-05 7:53 ` Michael S. Tsirkin 2021-10-05 10:46 ` Halil Pasic 2021-10-05 10:46 ` Halil Pasic 2021-10-05 10:46 ` Halil Pasic 2021-10-05 11:11 ` Michael S. Tsirkin 2021-10-05 11:11 ` Michael S. Tsirkin 2021-10-05 11:11 ` Michael S. Tsirkin 2021-10-01 14:34 ` Christian Borntraeger 2021-10-01 14:34 ` Christian Borntraeger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211002082128-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=cohuck@redhat.com \ --cc=jasowang@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=markver@us.ibm.com \ --cc=pasic@linux.ibm.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xieyongji@bytedance.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.